From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: RFC: locale-sensitive Emacs functions Date: Tue, 28 Mar 2017 12:37:16 -0700 Organization: UCLA Computer Science Department Message-ID: References: <87lgrq5ccp.fsf@lifelogs.com> <8Sj4h1O1rGU3p2OhVtn_8rleNKxYpeaUgnELj6kkM2iv3vXZWKaY0viThS1GwHfnf3EhDqooeJbfbOvbk-YBLpVI4znjtvf9Ot3G4ej8YJM=@protonmail.com> <721338e4-fad3-e33c-2a77-59107fbe1ff2@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1490729977 32524 195.159.176.226 (28 Mar 2017 19:39:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 28 Mar 2017 19:39:37 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 Cc: emacs-devel@gnu.org To: Gdobbins Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 28 21:39:31 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cswxd-0006gB-7m for ged-emacs-devel@m.gmane.org; Tue, 28 Mar 2017 21:39:21 +0200 Original-Received: from localhost ([::1]:54943 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cswxi-0007Z5-IN for ged-emacs-devel@m.gmane.org; Tue, 28 Mar 2017 15:39:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cswvn-0006DR-MN for emacs-devel@gnu.org; Tue, 28 Mar 2017 15:37:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cswvk-0003Pd-Gg for emacs-devel@gnu.org; Tue, 28 Mar 2017 15:37:27 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:45062) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cswvk-0003Ot-9k for emacs-devel@gnu.org; Tue, 28 Mar 2017 15:37:24 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4F0FA1600B9; Tue, 28 Mar 2017 12:37:21 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 0IvUs4UJR0bX; Tue, 28 Mar 2017 12:37:20 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 912C41600BA; Tue, 28 Mar 2017 12:37:20 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 630bs4lksasM; Tue, 28 Mar 2017 12:37:20 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 784C11600B9; Tue, 28 Mar 2017 12:37:20 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213459 Archived-At: Thanks, this looks like a reasonable way to proceed. Some comments: There is no need for any of those backslashes at line end. Also, please indent consistently. The manual needs to be updated, and there needs to be some test cases. > +The \\=' flag is ignored for all arguments except %d. This places too many constraints on the implementation. Instead, please say only that the behavior is defined for %d, and leave things undefined if the ' flag is used for any other conversion. We may want to add support for %'x at some point, for example. This should document what happens when the 0 and ' flags are both used. Are grouping characters inserted before zero-padding, or after? I think it's before (as in POSIX), but you should check this. > + if (apos_flag && INTEGERP (args[n])) I don't see why that "&& INTEGERP (args[n])" is needed. Please remove it. The code does not appear to do the right thing when the space or + flags are used, or when the integer is negative. It treats the leading sign or space as if it were a digit. The code assumes that format-digit-separator is ASCII; it might not be. Add test cases for the above corner cases. Adjust SPRINTF_BUFSIZE to account for the worst-case buffer size when %'d is used. I suppose it should be the maximum of its current value, and (INT_BUFSIZE_BOUND (printmax_t) + (INT_STRLEN_BOUND (printmax_t) - 2) * MAX_MULTIBYTE_LENGTH), but you should check this. Use an O(N) rather than an O(N**2) algorithm when inserting grouping characters.