all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Ken Brown <kbrown@cornell.edu>, "M. Nomiya" <nomiya@galaxy.dti.ne.jp>
Cc: emacs-devel@gnu.org
Subject: Re: make bootstrap error
Date: Thu, 14 Sep 2017 07:26:24 -0700	[thread overview]
Message-ID: <ac0dd945-94ae-1657-9c86-e5440b4e71a6@cs.ucla.edu> (raw)
In-Reply-To: <313ff71a-dfc4-943e-ddb9-97c9351fd0e0@cornell.edu>

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

Ken Brown wrote:
> Paul, any idea why SYS_renameat2 would be undefined on openSUSE 12.3 x86_64?

Haven't a clue, but the workaround should be easy enough. I installed the 
attached; please give it a try. If some platform other than Cygwin starts 
supporting renameat2 we can put a test into configure.ac and change "defined 
CYGWIN" to "HAVE_RENAME2".

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Port-renameat_noreplace-to-openSUSE-12.3.patch --]
[-- Type: text/x-patch; name="0001-Port-renameat_noreplace-to-openSUSE-12.3.patch", Size: 1090 bytes --]

From bc5485edeff0ccb3fbcc7fe6b6f13c666699e959 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Thu, 14 Sep 2017 07:23:13 -0700
Subject: [PATCH] Port renameat_noreplace to openSUSE 12.3

Problem reported by M. Nomiya in:
http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00363.html
* src/sysdep.c (renameat_noreplace):
Call renameat2 only if CYGWIN.
---
 src/sysdep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sysdep.c b/src/sysdep.c
index 318d4eb..1e6e0d0 100644
--- a/src/sysdep.c
+++ b/src/sysdep.c
@@ -2689,7 +2689,7 @@ renameat_noreplace (int srcfd, char const *src, int dstfd, char const *dst)
 {
 #if defined SYS_renameat2 && defined RENAME_NOREPLACE
   return syscall (SYS_renameat2, srcfd, src, dstfd, dst, RENAME_NOREPLACE);
-#elif defined RENAME_NOREPLACE	/* Cygwin >= 2.9.0. */
+#elif defined CYGWIN && defined RENAME_NOREPLACE
   return renameat2 (srcfd, src, dstfd, dst, RENAME_NOREPLACE);
 #elif defined RENAME_EXCL
   return renameatx_np (srcfd, src, dstfd, dst, RENAME_EXCL);
-- 
2.7.4


  reply	other threads:[~2017-09-14 14:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-14  4:16 make bootstrap error M.Nomiya
2017-09-14 12:00 ` Ken Brown
2017-09-14 12:11   ` M. Nomiya
2017-09-14 12:22     ` Ken Brown
2017-09-14 14:26       ` Paul Eggert [this message]
2017-09-14 22:12         ` M. Nomiya
  -- strict thread matches above, loose matches on Subject: below --
2017-07-30  4:20 Masaru Nomiya
2017-07-30  5:11 ` Tino Calancha
2017-07-30 11:35   ` Tino Calancha
2017-07-30 12:42     ` Masaru Nomiya
2017-07-30 12:56       ` Tino Calancha
2017-07-30 14:11     ` Eli Zaretskii
2017-07-30 15:36       ` Tino Calancha
2017-07-30 15:55         ` Eli Zaretskii
2017-08-02  9:13           ` Tino Calancha
2005-07-29 10:06 djh
2005-07-29 14:04 ` Eli Zaretskii
2003-06-28  2:51 Vinicius Jose Latorre
2003-05-18  2:20 Vinicius Jose Latorre
2003-05-18  2:32 ` Stefan Monnier
2003-05-04 17:42 Vinicius Jose Latorre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac0dd945-94ae-1657-9c86-e5440b4e71a6@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=kbrown@cornell.edu \
    --cc=nomiya@galaxy.dti.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.