From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Phil Estival Newsgroups: gmane.emacs.devel,gmane.emacs.orgmode Subject: Re: package submission : ob-sql-session Date: Mon, 4 Nov 2024 19:16:01 +0100 Message-ID: References: <1a69c5fb-4069-45c8-b37b-4d54ef88b92d@alphapapa.net> <3a694658-9184-4c45-ac17-6e6083a21517@7d.nz> <87msizq7g3.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38184"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Adam Porter , emacs-devel@gnu.org, Org Mode List To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 04 19:18:24 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t81eh-0009hQ-D6 for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Nov 2024 19:18:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t81dT-0003MZ-M1; Mon, 04 Nov 2024 13:17:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t81cc-0002oR-5T for emacs-devel@gnu.org; Mon, 04 Nov 2024 13:16:15 -0500 Original-Received: from smtp-8fac.mail.infomaniak.ch ([83.166.143.172]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t81cY-00059E-Pb for emacs-devel@gnu.org; Mon, 04 Nov 2024 13:16:13 -0500 Original-Received: from smtp-3-0001.mail.infomaniak.ch (smtp-3-0001.mail.infomaniak.ch [10.4.36.108]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4Xj05Z2pXbzfG; Mon, 4 Nov 2024 19:16:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=7d.nz; s=20240212; t=1730744162; bh=F5P2wvieBIXPhn44KbPE+sMraYIq/c7AR4S8qI4mG4k=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bY7PPtj5oHE5W5i6HkHKjjnK1c61HdviPpTHiaLCByeFGvZipYcgAaQ/VAXkgpkIx xuQkKLiwyjf6Bm8DPqyM1D6YRHbB7srircOHUDeiy6AQckK/FrOgwFUIulPsynQdsG lzHQmL+VvwENAgIiDuyGpj6umju1QCwF8vVWEhejZsmkIft2bwmtG8hH23X1JuTiB2 gXmlQmBLCohxIa5lVdxGzRBDgtA2e2QeG7qzv0iZPWmcTxGyP2gUFVtCZAZaslDELQ t689iDvF6OHjhe1koyie+bnXMw0yRBPw9AoLJtWpuFh+vM9wL66erk2MkXvnX0SQ3p 7p8yGAYBc5IGQ== Original-Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4Xj05Y4Md8zDVT; Mon, 4 Nov 2024 19:16:01 +0100 (CET) Content-Language: fr, en-US In-Reply-To: <87msizq7g3.fsf@localhost> X-Infomaniak-Routing: alpha Received-SPF: pass client-ip=83.166.143.172; envelope-from=pe@7d.nz; helo=smtp-8fac.mail.infomaniak.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325116 gmane.emacs.orgmode:163817 Archived-At: * [2024-10-20 14:34] Ihor Radchenko: > Phil Estival writes: > >>>> ob-sql-session : >>>> - handle large results >>>> - has :results tables >>>> - accept header variables (:var) >>>> - accept sql client shell commands >>>> - keep login parameters >>>> - prompt only for blank connection parameters >>>> - can use `with-environment-variables' >>>> - provide some more tests > > Have you considered integrating it into ob-sql itself? > If not, what are the obstacles? > Hello Ihor, yes I have. It grows ob-sql by approximately 300 lines. There are rooms for improvements. https://github.com/flintforge/ob-sql-session/blob/main/ob-sql.el Current status : - added support of :sessions to ob-sql.el, by merging ob-sql-session.el - restored support for sqlite (even if there is ob-sqlite.el) - added composite types for options - moved options from org-babel to a new group org-babel-sql TODO : - use `org-babel-prep-session' - verify headers and columns options - check use and storage of :dbconnection - minimize writings of temporary files - Tests Cheers, Phil