From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 34763@debbugs.gnu.org
Subject: bug#34763: 27.0.50; url-retrieve-synchronously misbehaves inside eldoc-documentation-function
Date: Thu, 4 Apr 2019 02:37:49 +0300 [thread overview]
Message-ID: <abded0e9-79ad-9b8b-668f-c489f3b49743@yandex.ru> (raw)
In-Reply-To: <83pnqsyw68.fsf@gnu.org>
On 15.03.2019 17:49, Eli Zaretskii wrote:
> The code in the functions that react to quit-flag being non-nil should
> be audited. They don't look clean to me, FWIW, and we don't generally
> do such things from Lisp, we normally quit on the C level. Maybe this
> whole sub-feature, whereby we show a message for interrupted
> transfers, should be rethought.
Apparently the idea is to handle quits, including contexts where
inhibit-quit is t (947612be2c71d2478179694e8dfa538b9e8e07c1).
So url-retrieve-synchronously uses with-local-quit around
accept-process-output, and I guess the idea was to handle quits inside
debugging output calls.
So url-http-debug also does the job of clearing the sentinel and the
filter of the connection's process.
But maybe that's not enough: it doesn't kill the process and/or remove
it from url-http-open-connections. (I'm guessing
url-http-mark-connection-as-free would normally be called later if the
sentinel wasn't removed).
I'm not quite clear on how error handling should work here anyway.
Asynchronous code is tricky that way.
next prev parent reply other threads:[~2019-04-03 23:37 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 21:34 bug#34763: 27.0.50; url-retrieve-synchronously misbehaves inside eldoc-documentation-function Dmitry Gutov
2019-03-11 0:18 ` Dmitry Gutov
2019-03-11 14:30 ` Eli Zaretskii
2019-03-12 9:08 ` Dmitry Gutov
2019-03-12 15:02 ` Dmitry Gutov
2019-03-12 17:18 ` Eli Zaretskii
2019-03-12 17:44 ` Dmitry Gutov
2019-03-12 18:00 ` Eli Zaretskii
2019-03-12 20:05 ` Dmitry Gutov
2019-03-13 16:49 ` Eli Zaretskii
2019-03-15 14:24 ` Dmitry Gutov
2019-03-15 15:47 ` Eli Zaretskii
2019-03-15 16:07 ` Dmitry Gutov
2019-03-15 14:29 ` Dmitry Gutov
2019-03-15 15:49 ` Eli Zaretskii
2019-04-03 23:37 ` Dmitry Gutov [this message]
2019-04-04 13:04 ` Eli Zaretskii
2019-04-04 13:29 ` Dmitry Gutov
2019-04-04 14:36 ` Eli Zaretskii
2019-04-05 0:29 ` Dmitry Gutov
2019-04-05 6:14 ` Eli Zaretskii
2019-04-08 10:25 ` Dmitry Gutov
2019-04-08 15:20 ` Eli Zaretskii
2019-04-08 16:42 ` Dmitry Gutov
2019-04-08 17:13 ` Eli Zaretskii
2019-04-09 0:48 ` Dmitry Gutov
2019-04-09 6:34 ` Eli Zaretskii
2019-04-10 1:44 ` Dmitry Gutov
2019-04-10 15:46 ` Eli Zaretskii
2019-04-11 1:03 ` Dmitry Gutov
2019-04-11 7:59 ` Andreas Schwab
2019-04-11 13:08 ` Dmitry Gutov
2019-04-11 15:08 ` Dmitry Gutov
2019-04-11 16:22 ` Eli Zaretskii
2019-04-11 16:31 ` Dmitry Gutov
2019-04-13 0:44 ` Dmitry Gutov
2019-05-15 5:16 ` Lars Ingebrigtsen
2019-05-21 1:02 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abded0e9-79ad-9b8b-668f-c489f3b49743@yandex.ru \
--to=dgutov@yandex.ru \
--cc=34763@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.