From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Building master fails on Windows 10 when testing etc/NEWS file Date: Wed, 18 Sep 2019 13:16:00 -0700 Organization: UCLA Computer Science Department Message-ID: References: <1d388216-eed3-ed6f-5710-18d38daefe58@cs.ucla.edu> <1840bbb1-50de-870d-99d9-b4340e3c3b92@cs.ucla.edu> <83a7b1vkob.fsf@gnu.org> <83zhj1txpi.fsf@gnu.org> <83y2yltt5j.fsf@gnu.org> <83v9tptpy1.fsf@gnu.org> <83tv99tpal.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="100670"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 Cc: rudalics@gmx.at, emacs-devel@gnu.org To: Eli Zaretskii , rcopley@gmail.com, lekktu@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 18 22:17:48 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iAgOZ-000Q0l-FY for ged-emacs-devel@m.gmane.org; Wed, 18 Sep 2019 22:17:47 +0200 Original-Received: from localhost ([::1]:34918 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAgOY-0005qT-BX for ged-emacs-devel@m.gmane.org; Wed, 18 Sep 2019 16:17:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39735) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAgN2-0005ps-Um for emacs-devel@gnu.org; Wed, 18 Sep 2019 16:16:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iAgN0-00064o-Bk for emacs-devel@gnu.org; Wed, 18 Sep 2019 16:16:12 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:43700) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iAgMw-000635-72; Wed, 18 Sep 2019 16:16:06 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1A8A6160571; Wed, 18 Sep 2019 13:16:04 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id GAO-sqXQn-hl; Wed, 18 Sep 2019 13:16:03 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 6FD1416059B; Wed, 18 Sep 2019 13:16:03 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 55tCKjlOfbRV; Wed, 18 Sep 2019 13:16:03 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 52186160571; Wed, 18 Sep 2019 13:16:03 -0700 (PDT) In-Reply-To: <83tv99tpal.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240153 Archived-At: On 9/18/19 11:47 AM, Eli Zaretskii wrote: > I guess the answer is so that file_test_errno could report the > offending file name... But the change failed to pay attention that > 'found' is used further down. > > So based on this hypothesis I fixed the code to not clobber the file > name found by openp. Thanks, that looks right to me.