From: Drew Adams <drew.adams@oracle.com>
To: "Mattias Engdegård" <mattiase@acm.org>,
"Stephen Leake" <stephen_leake@stephe-leake.org>,
"Yuri Khan" <yuri.v.khan@gmail.com>,
tomas@tuxteam.de
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: RE: master 68ae6fa: Improved light/dark colour predicate (bug#41544)
Date: Thu, 18 Jun 2020 12:35:52 -0700 (PDT) [thread overview]
Message-ID: <ab96761f-1d6a-49ce-a216-d749124bda79@default> (raw)
In-Reply-To: <5A6B8DE2-EADF-4D74-A0EA-DE5303F828D4@acm.org>
> Thanks to those who replied -- the originally proposed 0.325 luminance limit
> seems to be fairly uncontroversial and can be changed if evidence indicates
> that it was badly chosen. Most of all, the value seems to work well across
> all platforms and a sufficient variety of equipment, which is the important
> part.
>
> Special thanks to Yuri for helping me confirm that the theoretical 50%
> lightness of luminance 0.18 wasn't necessarily an optimal value in this case.
> Trust my own eyes, but verify!
>
> The constant has now been given a (provisional) name, for extra clarity and
> ease of adjustment.
Not to belabor this, and I don't recall all that's
involved.
But if there are different eyes, screens, whatever,
would it make sense to use a defvar, or even a defcustom,
instead of a defconst? Why decide this definitively
at design time? Does it make sense to hard-code it?
If the question isn't useful, please ignore.
next prev parent reply other threads:[~2020-06-18 19:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200610181238.9796.44750@vcs0.savannah.gnu.org>
[not found] ` <20200610181239.947C4204DF@vcs0.savannah.gnu.org>
2020-06-10 19:20 ` master 68ae6fa: Improved light/dark colour predicate (bug#41544) Stefan Monnier
2020-06-10 19:34 ` Mattias Engdegård
2020-06-10 20:01 ` Stefan Monnier
2020-06-11 5:15 ` Yuri Khan
2020-06-11 16:15 ` Mattias Engdegård
2020-06-11 19:22 ` Yuri Khan
2020-06-12 15:50 ` Mattias Engdegård
2020-06-12 16:22 ` tomas
2020-06-12 18:36 ` Yuri Khan
2020-06-13 10:55 ` Mattias Engdegård
2020-06-12 19:02 ` Drew Adams
2020-06-12 19:09 ` Stephen Leake
2020-06-18 19:28 ` Mattias Engdegård
2020-06-18 19:35 ` Drew Adams [this message]
2020-06-18 20:04 ` Mattias Engdegård
2020-06-18 20:32 ` Drew Adams
2020-06-21 7:51 ` Mattias Engdegård
2020-06-18 19:40 ` Basil L. Contovounesios
2020-06-18 19:58 ` Mattias Engdegård
2020-06-13 4:05 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab96761f-1d6a-49ce-a216-d749124bda79@default \
--to=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
--cc=stephen_leake@stephe-leake.org \
--cc=tomas@tuxteam.de \
--cc=yuri.v.khan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.