* Re: emacs-29 fbaf113bf38: rust-ts-mode: appropriately fontify doc strings
[not found] ` <20231201235520.4AE7EC40272@vcs2.savannah.gnu.org>
@ 2023-12-04 13:27 ` Arash Esbati
2023-12-04 13:42 ` Dmitry Gutov
0 siblings, 1 reply; 3+ messages in thread
From: Arash Esbati @ 2023-12-04 13:27 UTC (permalink / raw)
To: emacs-devel; +Cc: Christophe Troestler, Dmitry Gutov
Dmitry Gutov <dgutov@yandex.ru> writes:
> branch: emacs-29
> commit fbaf113bf38ee7db8416f0c0581d479c40b2d69c
> Author: Christophe Troestler <Christophe.Troestler@umons.ac.be>
> Commit: Dmitry Gutov <dmitry@gutov.dev>
>
> rust-ts-mode: appropriately fontify doc strings
>
> * lisp/progmodes/rust-ts-mode.el
> (rust-ts-mode--comment-docstring): New function.
> (rust-ts-mode--font-lock-settings): Use it
> (https://lists.gnu.org/archive/html/emacs-devel/2023-12/msg00019.html).
> [...]
> +(defun rust-ts-mode--comment-docstring (node override start end &rest _args)
> + "Use the comment or documentation face appropriately for comments."
> + (let* ((beg (treesit-node-start node))
> + (end (treesit-node-end node))
> + (face (save-excursion
> + (goto-char beg)
> + (if (looking-at "///")
> + 'font-lock-doc-face
> + 'font-lock-comment-face))))
> + (treesit-fontify-with-override beg end face override start end)))
> +
I think this change now produces:
In rust-ts-mode--comment-docstring:
progmodes/rust-ts-mode.el:296:61: Warning: Unused lexical argument ‘end’
This is with Emacs from master (cf11fdfd8e) on macOS.
Best, Arash
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: emacs-29 fbaf113bf38: rust-ts-mode: appropriately fontify doc strings
2023-12-04 13:27 ` emacs-29 fbaf113bf38: rust-ts-mode: appropriately fontify doc strings Arash Esbati
@ 2023-12-04 13:42 ` Dmitry Gutov
2023-12-04 15:04 ` Arash Esbati
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Gutov @ 2023-12-04 13:42 UTC (permalink / raw)
To: Arash Esbati, emacs-devel; +Cc: Christophe Troestler
On 04/12/2023 15:27, Arash Esbati wrote:
> Dmitry Gutov<dgutov@yandex.ru> writes:
>
>> branch: emacs-29
>> commit fbaf113bf38ee7db8416f0c0581d479c40b2d69c
>> Author: Christophe Troestler<Christophe.Troestler@umons.ac.be>
>> Commit: Dmitry Gutov<dmitry@gutov.dev>
>>
>> rust-ts-mode: appropriately fontify doc strings
>>
>> * lisp/progmodes/rust-ts-mode.el
>> (rust-ts-mode--comment-docstring): New function.
>> (rust-ts-mode--font-lock-settings): Use it
>> (https://lists.gnu.org/archive/html/emacs-devel/2023-12/msg00019.html).
>> [...]
>> +(defun rust-ts-mode--comment-docstring (node override start end &rest _args)
>> + "Use the comment or documentation face appropriately for comments."
>> + (let* ((beg (treesit-node-start node))
>> + (end (treesit-node-end node))
>> + (face (save-excursion
>> + (goto-char beg)
>> + (if (looking-at "///")
>> + 'font-lock-doc-face
>> + 'font-lock-comment-face))))
>> + (treesit-fontify-with-override beg end face override start end)))
>> +
> I think this change now produces:
>
> In rust-ts-mode--comment-docstring:
> progmodes/rust-ts-mode.el:296:61: Warning: Unused lexical argument ‘end’
>
> This is with Emacs from master (cf11fdfd8e) on macOS.
Thanks, but this has been fixed 2 days ago (in a547b0e2e83).
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: emacs-29 fbaf113bf38: rust-ts-mode: appropriately fontify doc strings
2023-12-04 13:42 ` Dmitry Gutov
@ 2023-12-04 15:04 ` Arash Esbati
0 siblings, 0 replies; 3+ messages in thread
From: Arash Esbati @ 2023-12-04 15:04 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: emacs-devel, Christophe Troestler
Dmitry Gutov <dmitry@gutov.dev> writes:
> Thanks, but this has been fixed 2 days ago (in a547b0e2e83).
Ah, this was on the release branch, so I just have to wait. Thanks, and
sorry for the noise.
Best, Arash
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-04 15:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <170147491995.22987.13141633400020290013@vcs2.savannah.gnu.org>
[not found] ` <20231201235520.4AE7EC40272@vcs2.savannah.gnu.org>
2023-12-04 13:27 ` emacs-29 fbaf113bf38: rust-ts-mode: appropriately fontify doc strings Arash Esbati
2023-12-04 13:42 ` Dmitry Gutov
2023-12-04 15:04 ` Arash Esbati
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.