From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chming Newsgroups: gmane.emacs.devel Subject: Re: The latest lisp/faces.el changes seem to break color-themes again Date: Thu, 16 Oct 2008 11:09:15 -0700 Message-ID: References: <87skqxw20c.fsf@anzu.internal.golden-gryphon.com> <87od1lvxa9.fsf@anzu.internal.golden-gryphon.com> <87abd4vfyb.fsf@grepfind.mwolson.org> <87tzbcfqfe.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1224180579 14886 80.91.229.12 (16 Oct 2008 18:09:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Oct 2008 18:09:39 +0000 (UTC) Cc: Michael Olson , emacs-devel@gnu.org To: "Chong Yidong" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 16 20:10:39 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KqXIt-0004oN-UC for ged-emacs-devel@m.gmane.org; Thu, 16 Oct 2008 20:10:32 +0200 Original-Received: from localhost ([127.0.0.1]:41885 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqXHp-0004Pr-4e for ged-emacs-devel@m.gmane.org; Thu, 16 Oct 2008 14:09:25 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KqXHk-0004PM-42 for emacs-devel@gnu.org; Thu, 16 Oct 2008 14:09:20 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KqXHi-0004P6-3M for emacs-devel@gnu.org; Thu, 16 Oct 2008 14:09:19 -0400 Original-Received: from [199.232.76.173] (port=45318 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqXHi-0004P3-0e for emacs-devel@gnu.org; Thu, 16 Oct 2008 14:09:18 -0400 Original-Received: from fk-out-0910.google.com ([209.85.128.190]:37744) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KqXHh-00066d-Ft for emacs-devel@gnu.org; Thu, 16 Oct 2008 14:09:17 -0400 Original-Received: by fk-out-0910.google.com with SMTP id 18so102904fkq.10 for ; Thu, 16 Oct 2008 11:09:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=WeMXhnmo+1weeNHVKIfTnb+ch/luQgLrAKrBKiDQTTk=; b=V0IQdyAVzaqxM2oVoUdH3zBMJbzq8v7iwpdfw1JtWOZNKFISvUETZ4Y9g61hLsll8U 3axYhP/ba3Ict1hfw2s6E/XyAAJX4YWM1ge8lJQTt3k8cdo0tmH5/qGRlTAWIuLhlVh6 uYTfPW3YpAte7SxDsbGcfpoEzcsqq2MuaGlf4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=rJHKbh3BwvqrujhnWqiJe7sqLmFnougJa4qkn5W9l5beN8A+C3HI6+rAjADbtkOE3j O/lg1cYJF310+pXo5ZLXISl2c+8CaOS3MeSAh+Gl9y2YBa/q0wTEf1SbfbW5ODJ0vpgK ySnnHwnsMUf5eNQvmPJPrzuyOOItnjtNClZrk= Original-Received: by 10.187.168.15 with SMTP id v15mr388280fao.100.1224180555388; Thu, 16 Oct 2008 11:09:15 -0700 (PDT) Original-Received: by 10.187.226.2 with HTTP; Thu, 16 Oct 2008 11:09:15 -0700 (PDT) In-Reply-To: <87tzbcfqfe.fsf@cyd.mit.edu> Content-Disposition: inline X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104559 Archived-At: On my side, the normal emacs startup is fine but it is broken if I am using multi-tty with emacsclient. Yesterday, I got some errors related to the face attribute. Today with cvs update, this is gone but still broken for emacsclient session. BTW, I am using color-theme. Thanks a lot, Max On Thu, Oct 16, 2008 at 9:36 AM, Chong Yidong wrote: > Michael Olson writes: > >> The problem could possibly be due to Emacs having problems with using >> ":foreground nil" in a defface statement. I just received a patch for >> EMMS to that effect. > > I just checked in a change to make internal-set-lisp-face-attribute > treat null foreground/background as equivalent to unspecified. This is > a Emacs 20'ism that ought to be phased out in your code, but AFAICT > there's no harm handling it. > > Let me know if there is anything else that breaks (I don't use > color-themes so I can't test the original report). > > >