From: "Charles A. Roelli" <charles@aurox.ch>
To: Anders Lindgren <andlind@gmail.com>
Cc: 25818@debbugs.gnu.org, alan@idiocy.org
Subject: bug#25818: 25.2; frame moved off display does not return (OS X)
Date: Thu, 27 Apr 2017 21:14:05 +0200 [thread overview]
Message-ID: <ab2fbb0e-c263-b2b7-964e-47d20efc8a35@aurox.ch> (raw)
In-Reply-To: <CABr8ebaEQZxQavng54WHGZg2Mem_vfJ-wNWHL=i+ffCZzSyrpg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 842 bytes --]
Hi Anders,
As discussed off-list, the copyright assignment is done.
I fixed the patch so that child frames are never constrained (after some
testing, it seems that a child frame cannot get stuck off screen as long
as its parent is still visible). To test this out, evaluate the
following from emacs -Q,
(progn
(setq test-frame (make-frame `((parent-frame . ,(selected-frame)))))
(set-frame-position test-frame 0 500))
and drag the parent frame down until its child is off screen. When the
parent is moved back up, the child should reappear with it. (Assuming
Spaces is off; not sure what would happen in OS X 10.9+ in this case
when Spaces is on... I guess the child would be constrained before it is
placed off screen?).
I've also CC'ed Alan since this change is related to the new frame
parameters.
Cheers,
Charles
[-- Attachment #2: 0001-Constrain-non-child-frames-to-screen-area-in-OS-X.patch --]
[-- Type: text/x-patch, Size: 1876 bytes --]
From d2ed9a7bed8872bd89c32d3475607a6e5a271198 Mon Sep 17 00:00:00 2001
From: Charles A. Roelli <charles@aurox.ch>
Date: Thu, 27 Apr 2017 20:44:09 +0200
Subject: [PATCH] Constrain non-child frames to screen area in OS X
* src/nsterm.m (constrainFrameRect:toScreen:): Constrain non-child
frames in OS X, if they would otherwise go offscreen.
Fixes: debbugs:25818
---
src/nsterm.m | 35 ++++++++++++++++++++++++++++++++++-
1 files changed, 34 insertions(+), 1 deletions(-)
diff --git a/src/nsterm.m b/src/nsterm.m
index 8c5eb06..f0495c4 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -8011,8 +8011,40 @@ - (NSRect)constrainFrameRect:(NSRect)frameRect toScreen:(NSScreen *)screen
NSTRACE_RETURN_RECT (frameRect);
return frameRect;
}
-#endif
+ else
+#endif /* MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_9 */
+ // Check that the proposed frameRect is visible in at least one
+ // screen. If it is not, ask the system to reposition it (only
+ // for non-child frames).
+
+ if (!FRAME_PARENT_FRAME (((EmacsView *)[self delegate])->emacsframe))
+ {
+ NSArray *screens = [NSScreen screens];
+ NSUInteger nr_screens = [screens count];
+
+ int i;
+ BOOL frame_on_screen = NO;
+
+ for (i = 0; i < nr_screens; ++i)
+ {
+ NSScreen *s = [screens objectAtIndex: i];
+ NSRect scrRect = [s frame];
+
+ if (NSIntersectsRect(frameRect, scrRect))
+ {
+ frame_on_screen = YES;
+ break;
+ }
+ }
+
+ if (!frame_on_screen)
+ {
+ NSTRACE_MSG ("Frame outside screens; constraining");
+ frameRect = [super constrainFrameRect:frameRect toScreen:screen];
+ NSTRACE_RETURN_RECT (frameRect);
+ return frameRect;
+ }
+ }
#endif
return constrain_frame_rect(frameRect,
--
1.7.4.4
next prev parent reply other threads:[~2017-04-27 19:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 20:04 bug#25818: 25.2; frame moved off display does not return (OS X) Charles A. Roelli
2017-02-23 8:49 ` martin rudalics
2017-02-26 11:26 ` Charles A. Roelli
2017-02-26 15:40 ` Charles A. Roelli
2017-02-26 16:45 ` martin rudalics
2017-02-26 19:42 ` Charles A. Roelli
2017-02-27 8:05 ` martin rudalics
2017-02-27 10:34 ` Charles A. Roelli
2017-02-27 20:47 ` Charles A. Roelli
2017-02-28 10:12 ` Charles A. Roelli
2017-02-28 13:20 ` Anders Lindgren
2017-02-28 15:05 ` Charles A. Roelli
2017-02-28 20:35 ` Anders Lindgren
2017-02-28 22:05 ` Drew Adams
2017-03-01 10:48 ` Anders Lindgren
2017-03-01 16:10 ` Drew Adams
2017-03-19 19:38 ` Charles A. Roelli
2017-03-27 18:22 ` Anders Lindgren
2017-04-02 14:14 ` Charles A. Roelli
2017-04-03 8:33 ` Anders Lindgren
2017-04-08 20:40 ` Charles A. Roelli
2017-04-09 19:13 ` Anders Lindgren
2017-04-10 19:54 ` Charles A. Roelli
2017-04-11 18:35 ` Anders Lindgren
2017-04-27 19:14 ` Charles A. Roelli [this message]
2017-04-27 20:05 ` Alan Third
2017-04-28 17:33 ` Charles A. Roelli
2017-05-02 20:33 ` Alan Third
2017-05-05 18:30 ` Charles A. Roelli
2017-04-29 10:30 ` martin rudalics
2017-04-29 11:15 ` Charles A. Roelli
2017-04-29 14:51 ` Alan Third
2017-04-29 17:23 ` Anders Lindgren
2017-04-30 8:32 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab2fbb0e-c263-b2b7-964e-47d20efc8a35@aurox.ch \
--to=charles@aurox.ch \
--cc=25818@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=andlind@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.