From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cNaOJTczGF+jZgAA0tVLHw (envelope-from ) for ; Wed, 22 Jul 2020 12:38:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id QOk8ITczGF83DgAAbx9fmQ (envelope-from ) for ; Wed, 22 Jul 2020 12:38:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E2501940223 for ; Wed, 22 Jul 2020 12:38:14 +0000 (UTC) Received: from localhost ([::1]:35810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jyE0j-0007s0-F3 for larch@yhetil.org; Wed, 22 Jul 2020 08:38:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyE0K-0007re-5e for emacs-orgmode@gnu.org; Wed, 22 Jul 2020 08:37:48 -0400 Received: from mout02.posteo.de ([185.67.36.66]:48527) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyE0H-000288-HB for emacs-orgmode@gnu.org; Wed, 22 Jul 2020 08:37:47 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 66FD02400FC for ; Wed, 22 Jul 2020 14:37:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1595421463; bh=KMHJH/GrtZxgBpVvT5NLOQMlWMreBVBdLwztzCeOHyM=; h=Subject:From:To:Cc:Date:From; b=DAlnDrP2bX7LNMa6fx3cxdZJlW5n1ccAYadiZO2ipn1RbDzWdBKz2TK2l5o+CIKLX bBvbJXf47stwQy5cLExfXNHBAytAKMntznKkwRtKeAswZS9bJJiyAVrnqyMQ/ird44 8HJQ9rbjWuFxPqpDlH/ty71UI23bqTnlkcFhrkebNYssjAg5ihe9OiU9Op3Wr3+QJM 7eORecpwjeEqpbDUooIWx0WdK2t3D2Wim49pb2FCgp9KOYRuPKK/sBrHF5DJW3jkNI /XcJAuxRrD6zgK7GoDSdHre5A9PNobc+x8FoDlJAnwsRbPxesWmfiIWPntDuLC07rU 3s6oGRMSdOIPg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BBZjy5HLVz9rxf; Wed, 22 Jul 2020 14:37:42 +0200 (CEST) Subject: Re: [PATCH] Use completing-read-multiple for org-set-tags-command From: Clemens To: Kyle Meyer References: <87imegyy2r.fsf@kyleam.com> Message-ID: Date: Wed, 22 Jul 2020 14:37:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=185.67.36.66; envelope-from=clemens.radermacher@posteo.de; helo=mout02.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/22 08:37:43 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.de header.s=2017 header.b=DAlnDrP2; dmarc=pass (policy=none) header.from=posteo.de; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: d84Zr4/xlG8j Now that I know that completion works for multiple tags with default completion I'm unsure if it is worth to proceed with this. I wondered how this would go unnoticed for such a long time in org and now I know that the failure was on my part. On the other hand switching to `completing-read-multiple` would improve the situation for completion frameworks which handle it correctly and would also be more idiomatic for this use case.