From: Paul Eggert <eggert@cs.ucla.edu>
To: Pip Cet <pipcet@gmail.com>
Cc: 39529@debbugs.gnu.org, federicotedin@gmail.com
Subject: bug#39529: 28.0.50; Metahelp does not contain help text
Date: Tue, 18 Feb 2020 17:21:58 -0800 [thread overview]
Message-ID: <aa08fc22-75b0-7fcd-0710-c8d009469d50@cs.ucla.edu> (raw)
In-Reply-To: <CAOqdjBdnS8vTHxKzrZ=+bTX3PDkTNX5WsaUNFGWMRFHcM7FGkw@mail.gmail.com>
On 2/18/20 11:56 AM, Pip Cet wrote:
> if we rely on the precise
> definitions of XHASH etc. that were in place prior to the January
> changes, no "quick fix" was needed; it was simply the case that the
> predicate used by hash tables created with :test equal diverged from
> the built-in `equal' predicate in one more way than was already
> documented. (Those documented deviations are that mutations of hash
> keys won't cause rehashing, and that equal will sometimes signal for
> (equal a b) but not for (equal b a)).
I'm not aware of these deviations - where are they documented?
What I see in the Emacs 27 documentation, under "Defining Hash
Comparisons", is the statement that the hash and equality functions'
"behavior should depend on only on properties of the keys that do not
change". This is true of 'equal' and 'sxhash-equal' if one does not
mutate any key that's in the hash table. So from what I can see, the
predicates are supposed to be the same, it's just that one can't mutate
keys.
Also, I don't understand what is meant by "the predicate used by hash
tables created with :test equal diverged from the built-in `equal'
predicate". cmpfn_equal simply calls Fequal, so how can their behaviors
diverge?
>>> The pure-cons hash, and many other places, assume "equal" means
>>> "equivalent" in some way. That's not true for bytecode objects, where
>>> a function always returning `nil' can be equal to one always returning
>>> `t'.
>>
>> Could you give an example of this? When I byte-compiled this:
>
> (defun f () (let ((x '(#1=(nil) . #1#)))
> (eq (car x) (cdr x))))
> (defun g () (let ((x '((nil) . (nil)))
> (eq (car x) (cdr x))))
>
> That's somewhat contrived; more realistic examples where this might
> actually be a problem would use string properties.
Although this example is a good one that illustrates a bug (or at least
a poorly-documented feature) in dumping, it hasn't changed because of
the January 7 changes to sxhash. The same issue exists in Emacs 27 (and
in Emacs 26 for that matter). So I'd rather address this issue
separately, perhaps simply by documenting it for now.
> I'll propose one more thing, which sounds horrible at first but might
> be the least horrible option: accept that `equal', the function, and
> `:test equal', the hash table predicate, have diverged significantly
> already.
Again I'm not following, because the two functions haven't diverged as
far as I can see.
next prev parent reply other threads:[~2020-02-19 1:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-09 19:06 bug#39529: 28.0.50; Metahelp does not contain help text Federico Tedin
2020-02-09 19:22 ` Eli Zaretskii
2020-02-09 19:34 ` Eli Zaretskii
2020-02-15 23:25 ` Paul Eggert
2020-02-16 15:35 ` Eli Zaretskii
2020-02-16 16:51 ` Pip Cet
2020-02-16 19:43 ` Paul Eggert
2020-02-18 19:56 ` Pip Cet
2020-02-19 1:21 ` Paul Eggert [this message]
2020-02-19 2:34 ` Pip Cet
2020-02-19 9:00 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa08fc22-75b0-7fcd-0710-c8d009469d50@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=39529@debbugs.gnu.org \
--cc=federicotedin@gmail.com \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.