From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>,
Stefan Kangas <stefankangas@gmail.com>
Cc: Dani Moncayo <dmoncayo@gmail.com>,
Stefan Monnier <monnier@iro.umontreal.ca>,
12443@debbugs.gnu.org
Subject: bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy)
Date: Tue, 25 Aug 2020 08:34:58 -0700 (PDT) [thread overview]
Message-ID: <aa071fef-7405-4d5a-b40e-aa951ae122f3@default> (raw)
In-Reply-To: <87imd669dh.fsf@gnus.org>
This is what I do in Icicles.
` icicle-handle-default-for-prompt' is called from
`(icicle-)completing-read' and `(icicle-)read-string'.
;; In `(icicle-)completing-read':
(setq prompt
(icicle-handle-default-for-prompt
prompt
;; If `insert-default-directory' then make DEF
;; in prompt relative to `default-directory'.
(if (and def1 (eq icicle-default-value t)
insert-default-directory)
(file-relative-name def1)
def1)
(and (eq icicle-default-value t)
;; Include in prompt only if
;; `insert-default-directory' does not
;; insert it as input.
(or (not insert-default-directory)
(not (icicle-file-name-input-p))
(not (equal def1 default-directory))))))
;; In `(icicle-)read-string':
(when default-value
(setq prompt (icicle-handle-default-for-prompt
prompt
default-value
(eq icicle-default-value t))))
(defun icicle-handle-default-for-prompt (prompt default include)
"Return PROMPT, possibly changed to format or remove the DEFAULT value.
Argument INCLUDE:
* nil means do not include DEFAULT in prompt. Remove it if there.
* non-nil means include DEFAULT, formatted according to
`icicle-default-in-prompt-format-function'.
In the existing PROMPT before modification, recognizes inclusion of
a default value according to these possible patterns:
`minibuffer-default-in-prompt-regexps'
\"(default ___):\"
\"(default is ___):\"
\" [___] \""
(when (consp default) (setq default (car default)))
(dolist ; Remove the default, if already there.
(rgx (if (boundp 'minibuffer-default-in-prompt-regexps)
minibuffer-default-in-prompt-regexps
'(("\\( (default\\(?: is\\)? \\(.*\\))\\):? \\'" 1)
("\\( \\[.*\\]\\):? *\\'" 1))))
(setq prompt (replace-regexp-in-string
(car rgx) "" prompt nil nil (cadr rgx))))
(if (and default include) ; Add non-nil DEFAULT, if INCLUDE.
(replace-regexp-in-string
".*\\(\\): *\\'"
(funcall icicle-default-in-prompt-format-function default)
prompt nil t 1)
prompt))
(defcustom icicle-default-in-prompt-format-function
(lambda (default) (format " (%s)" default))
"Function that formats the default value to include in the prompt.
The function must accept the default value (a string) as its (first)
argument and return a string, which is prepended to the first
occurrence of `: ' in the prompt. This option has no effect unless
`icicle-default-value' is t."
:group 'Icicles-Miscellaneous :type 'function)
next prev parent reply other threads:[~2020-08-25 15:34 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 13:53 bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy) Dani Moncayo
2012-09-14 15:56 ` Stefan Monnier
2012-09-14 16:39 ` Drew Adams
2012-09-14 19:17 ` Dani Moncayo
2012-09-14 19:10 ` Dani Moncayo
2012-09-14 19:41 ` Stefan Monnier
2012-09-14 20:42 ` Dani Moncayo
2012-09-14 20:50 ` Jambunathan K
2012-09-14 20:55 ` Drew Adams
2012-09-14 22:47 ` Juri Linkov
2020-08-25 12:30 ` Lars Ingebrigtsen
2020-08-25 12:55 ` Stefan Kangas
2020-08-25 13:45 ` Stefan Monnier
2020-08-25 15:19 ` Lars Ingebrigtsen
2020-08-25 15:34 ` Drew Adams [this message]
2020-08-25 16:19 ` Stefan Kangas
2020-08-25 18:23 ` Juri Linkov
2020-08-25 19:12 ` Lars Ingebrigtsen
2020-08-25 20:00 ` Stefan Monnier
2020-08-26 12:10 ` Lars Ingebrigtsen
2020-08-27 18:48 ` Juri Linkov
2020-08-28 14:11 ` Lars Ingebrigtsen
2020-08-28 15:21 ` Stefan Monnier
2020-08-30 13:16 ` Lars Ingebrigtsen
2020-09-06 15:02 ` Lars Ingebrigtsen
2020-09-06 17:46 ` Lars Ingebrigtsen
2020-09-06 18:10 ` Lars Ingebrigtsen
2020-09-06 18:49 ` Drew Adams
2020-09-06 20:18 ` Michael Heerdegen
2020-09-06 20:38 ` Lars Ingebrigtsen
2020-09-06 20:42 ` Lars Ingebrigtsen
2020-09-06 21:55 ` Michael Heerdegen
2020-09-06 21:57 ` Lars Ingebrigtsen
2020-09-06 21:50 ` Michael Heerdegen
2020-09-06 21:56 ` Lars Ingebrigtsen
2020-09-07 18:46 ` Juri Linkov
2020-09-07 19:27 ` Lars Ingebrigtsen
2020-09-08 18:32 ` Juri Linkov
2020-09-08 20:37 ` Lars Ingebrigtsen
2020-09-09 18:50 ` Juri Linkov
2020-09-10 13:14 ` Lars Ingebrigtsen
2020-09-11 9:11 ` Andrii Kolomoiets
2020-09-11 12:53 ` Lars Ingebrigtsen
2020-09-14 8:40 ` Andrii Kolomoiets
2020-09-14 11:15 ` Lars Ingebrigtsen
2020-10-13 2:31 ` Lars Ingebrigtsen
2020-09-12 19:04 ` Juri Linkov
2020-09-13 8:53 ` Juri Linkov
2020-09-13 14:30 ` Eli Zaretskii
2020-09-13 13:00 ` Lars Ingebrigtsen
2020-09-07 20:11 ` Lars Ingebrigtsen
2021-01-17 19:05 ` bug#12443: 24.2.50; Default values in the minibuffer prompt (fix Basil L. Contovounesios
2021-01-18 16:40 ` Lars Ingebrigtsen
2021-01-18 18:06 ` Basil L. Contovounesios
2020-08-28 14:13 ` bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy) Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa071fef-7405-4d5a-b40e-aa951ae122f3@default \
--to=drew.adams@oracle.com \
--cc=12443@debbugs.gnu.org \
--cc=dmoncayo@gmail.com \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.