From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#37415: Asserting failure setting frame parameters to non-fixnum values in early-init.el Date: Sun, 22 Sep 2019 19:54:00 +0200 Message-ID: References: <83v9tqvrm7.fsf@gnu.org> <9aae1b2e-bb5f-8634-5501-9aaff9f51266@gmx.at> <83imppvl9r.fsf@gnu.org> <14d4a455-254e-fdc2-0b64-791cfb0f7724@gmx.at> <83o8zgtlvq.fsf@gnu.org> <0936d492-c2bc-d4d3-7fcf-272d0fdbe087@gmx.at> <83a7ayss4b.fsf@gnu.org> <7b896377-d546-b428-adba-797ec988c4fa@gmx.at> <83r24aqadz.fsf@gnu.org> <83ftkprfzx.fsf@gnu.org> <83y2ygp9hz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="45800"; mail-complaints-to="usenet@blaine.gmane.org" Cc: lekktu@gmail.com, 37415@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 22 19:56:04 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iC65c-000Bp3-DR for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Sep 2019 19:56:04 +0200 Original-Received: from localhost ([::1]:48132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iC65a-0001Xw-5O for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Sep 2019 13:56:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35076) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iC64g-0001W7-TB for bug-gnu-emacs@gnu.org; Sun, 22 Sep 2019 13:55:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iC64f-0000Bj-5x for bug-gnu-emacs@gnu.org; Sun, 22 Sep 2019 13:55:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53917) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iC64e-0000Bb-Uf for bug-gnu-emacs@gnu.org; Sun, 22 Sep 2019 13:55:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iC64c-0001AZ-5r for bug-gnu-emacs@gnu.org; Sun, 22 Sep 2019 13:55:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Sep 2019 17:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37415 X-GNU-PR-Package: emacs Original-Received: via spool by 37415-submit@debbugs.gnu.org id=B37415.15691748554406 (code B ref 37415); Sun, 22 Sep 2019 17:55:02 +0000 Original-Received: (at 37415) by debbugs.gnu.org; 22 Sep 2019 17:54:15 +0000 Original-Received: from localhost ([127.0.0.1]:34501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iC63q-000190-Jl for submit@debbugs.gnu.org; Sun, 22 Sep 2019 13:54:14 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:40337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iC63o-00018m-Rm for 37415@debbugs.gnu.org; Sun, 22 Sep 2019 13:54:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1569174840; bh=3khoZEG15HTpkI9mw6kqqaJ7cmmhYKZORvXYcfBTg28=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=hTeWCW9foR7rYSF7jCSRnh+mstz7UxETlnUk4dIobibfIOCd6cdzMExpIVxbWu3m1 M2P5/PfYq+DnH2gCh+96wPahTco5F22LoEZAvALl8NC8nC8A13AbcbmNIpDRaDxWIS XGFJTWXg50OjvCc4PMV8BaHRUswo5JoAzuB0TQ78= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.40]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MdNY2-1hclJ142ZU-00ZN8H; Sun, 22 Sep 2019 19:54:00 +0200 In-Reply-To: <83y2ygp9hz.fsf@gnu.org> Content-Language: de-AT X-Provags-ID: V03:K1:TxhOXt4kAbj078PxlK2actyCaAay5l6sQpOO2kfKvp3Svuo2B67 eZLkI9uEQwwa352POo881pyU/LAIB9HSE+jQTOCpDucNLf4tZdIfrUxEZyPxsmYcUqMhsMH JpAFy7Hhml5phfq7qK7j8NjB9zJVyHFL7RLHF0DXlIJ40tnsy53j5V6MpTImtwY88H39dIy yBX08Un/HiTrXxr1AQOew== X-UI-Out-Filterresults: notjunk:1;V03:K0:r0gYqqGAweA=:2/+b0wKLjk7c4nvBgntZQj toooDtdkeIq98cIKTxXAQLFJU0GAnO/N89TZY3NFB9/mqFYk51ftRoUFD+FmdWTA0iR0rQ31y kOeD7xxDoWtdv6dVYqcJ+Np+wtdKsLCMX3/ikDPSrWcqBFyiDI30neEE2vhyBAfTtK5MAqCN9 CE52YL0i2ZnNMo+O12nw/nqffcuk8JQgfqrx8tjXlaINMyhSpd5uqTZHLB2J+7qkFoe+MLJ+e fhNyEjWXc2Sr/Cdp02U/iYk7LD6fT9cu24PCE8b94skdyKbF2lTMInCWpT7AgpWoRIPH1hYAh TTbON2OVQy1ao/wa0pHybj61mik4GPg7HXONfkjEBbNylHHu0I4/6JPLIxY1h99EyTW+Kg+IF LnOx0Ww4lQ0i3IBPsxoV1HWF4xfqhPrhwgtpKKhV9aHcICNVhIMiradkGcqVH7iiPCfIKMk9N ZtozYTlpZ1zrZ7QUfH7CNtAC9GEFh+JIek0QFfNttxp7Sh+4xe2O2m1w3GxSlkLSJkZa3+i+8 B53FsaiVt6S4rINqdxgOct7o2w6ZeVUrIyprwPStaZ4/wjxj1oxDYeKQ6b38pXdFy4H9MVrGe D/5AcQGvaO9xGUiu2b7En2bEz0u2+Srpbm8lLbZRZPRrL0ErhJUvr5i8p4hctLFabxpi3ZuCD /1qfS150YXNBACVkYakQ+5wGb70xVL9tfhSCXOnniz1u+u9kcVDr53Qa7z4ND4DmhNDrxdj7U kKqlVdV3wjM34SwuK3BCA7k9SIyXd7VDedLUCdDWhVBi4AZ/+TI3bQrq3+9Gxs1Qkx8z6vls X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166935 Archived-At: > No, I don't think using x_get_arg is wrong, because we still want to > determine whether to use CW_USEDEFAULT. Hmm ... > We cannot do this unless f->size_hint_flags are set so as to tell > w32_createwindow to use f->top_pos and/or f->left_pos. Otherwise, we > should put CW_USEDEFAULT in coords[]. IOW, how about the below? [...] > + if (!(f->size_hint_flags & USPosition || f->size_hint_flags & PPosition)) > + { > + /* When called with RES_TYPE_NUMBER, and there's no 'top' or > + 'left' parameters in the frame's parameter alist, > + gui_display_get_arg will return zero for anything that is > + neither a number nor Qunbound. If frame parameter alist does > + have 'left' or 'top', they are interpreted by > + gui_figure_window_size, which was already called, and which > + sets f->size_hint_flags. */ So you mean when size hints are not set, we are sure that gui_display_get_arg does not find anything in 'default-frame-alist' (ignoring, BTW 'initial-frame-alist') and finds a number here. This looks a bit fragile to me. Isn't the fact that left/top are unbound sufficient that we should use CW_USEDEFAULT and f->left_pos/f->top_pos otherwise. Or don't you want to call gui_display_get_arg twice? martin