From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Chris Moore" Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: hexl: doesn't play nicely with dynamic-completion-mode Date: Mon, 10 Sep 2007 20:43:50 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1189455197 25435 80.91.229.12 (10 Sep 2007 20:13:17 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 10 Sep 2007 20:13:17 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, rms@gnu.org To: "Stefan Monnier" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 11 06:13:04 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IUvjC-00086T-If for ged-emacs-devel@m.gmane.org; Tue, 11 Sep 2007 04:43:50 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUoEq-0007aD-4f for ged-emacs-devel@m.gmane.org; Mon, 10 Sep 2007 14:44:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IUoEn-0007YT-KG for emacs-devel@gnu.org; Mon, 10 Sep 2007 14:43:57 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IUoEl-0007V8-Uh for emacs-devel@gnu.org; Mon, 10 Sep 2007 14:43:57 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUoEl-0007Ux-St for emacs-devel@gnu.org; Mon, 10 Sep 2007 14:43:55 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUoEl-0001PX-9i for emacs-devel@gnu.org; Mon, 10 Sep 2007 14:43:55 -0400 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUoEO-0000kA-3U for emacs-pretest-bug@gnu.org; Mon, 10 Sep 2007 14:43:32 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1IUoEi-0001Op-Ne for emacs-pretest-bug@gnu.org; Mon, 10 Sep 2007 14:43:54 -0400 Original-Received: from el-out-1112.google.com ([209.85.162.179]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUoEi-0001Oa-BL for emacs-pretest-bug@gnu.org; Mon, 10 Sep 2007 14:43:52 -0400 Original-Received: by el-out-1112.google.com with SMTP id m34so159798ele for ; Mon, 10 Sep 2007 11:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=2ITxAPgKP8Ml5/AUKCeGxgDRkLk3IJdVOW6zs9KyIvQ=; b=XMQF4XN0IXfKA7/9rm2cX20fL6bTWuMMxurkP6dRU17EPbODoTVvZ+snuZ8ViIN4SwQs6i2c7o0Eww4FHu67pTymlERaWJh51pgJfflZKdsDo8SgaBCFMK4KW/EoehyPLAYIZtIkxo4iDOTJWaTcjh5hLo3cNwawOezcu7KnNPc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=ZBQ/ZhTHzRIZPfQw5DbMaf8r6xKhX1zUoJwosvxoyFDcRM06khir+tOydDw7RJDw6u4/Mo8kxsrYrW5Xn+GmhW+eYVBYVCKhkxeyjskkbCS9fdQz6rUY8qW+wK0GrSK2IHBcb4BbUm+bXCGjRjFeWfozJEx0LLOg29XZYL84Lsw= Original-Received: by 10.142.107.1 with SMTP id f1mr244903wfc.1189449830168; Mon, 10 Sep 2007 11:43:50 -0700 (PDT) Original-Received: by 10.143.4.2 with HTTP; Mon, 10 Sep 2007 11:43:50 -0700 (PDT) In-Reply-To: Content-Disposition: inline X-Google-Sender-Auth: f2cf9316a23bd116 X-Detected-Kernel: Linux 2.4-2.6 (Google crawlbot) X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:78492 gmane.emacs.pretest.bugs:19825 Archived-At: On 9/10/07, Stefan Monnier wrote: > hexl-mode should probably install a before-change-function that checks that > this-command is among the supported ones. This won't fix those problems, > but will at least catch them before they corrupt the buffer. Is there some way for a before-change-function to prevent a change? It can call 'error to prevent the change once, but this clears the before-change-function handler, so the 'bad' key won't be caught a 2nd time. Also, I notice that 'this-command is 'completion-separator-self-insert-command rather than 'self-insert-command in the hexl-mode before-change-function (after applying Richard's fix), so hexl-mode would need to know about all the modes which remap self-insert-command.