From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Chris Moore" Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: hexl: doesn't play nicely with dynamic-completion-mode Date: Sun, 9 Sep 2007 20:01:30 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1812386073==" X-Trace: sea.gmane.org 1189362441 13597 80.91.229.12 (9 Sep 2007 18:27:21 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 9 Sep 2007 18:27:21 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 10 04:27:08 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IUYai-000203-2Q for ged-emacs-devel@m.gmane.org; Mon, 10 Sep 2007 04:01:32 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUR6L-0007iw-7v for ged-emacs-devel@m.gmane.org; Sun, 09 Sep 2007 14:01:41 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IUR6H-0007ii-GT for emacs-devel@gnu.org; Sun, 09 Sep 2007 14:01:37 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IUR6F-0007i7-FK for emacs-devel@gnu.org; Sun, 09 Sep 2007 14:01:36 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUR6F-0007i4-8n for emacs-devel@gnu.org; Sun, 09 Sep 2007 14:01:35 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUR6E-0001jh-Nq for emacs-devel@gnu.org; Sun, 09 Sep 2007 14:01:34 -0400 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUR5s-0004bp-Od for emacs-pretest-bug@gnu.org; Sun, 09 Sep 2007 14:01:12 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1IUR6C-0001jO-Pt for emacs-pretest-bug@gnu.org; Sun, 09 Sep 2007 14:01:34 -0400 Original-Received: from rv-out-0910.google.com ([209.85.198.186]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUR6C-0001iv-88 for emacs-pretest-bug@gnu.org; Sun, 09 Sep 2007 14:01:32 -0400 Original-Received: by rv-out-0910.google.com with SMTP id c27so774355rvf for ; Sun, 09 Sep 2007 11:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:references:x-google-sender-auth; bh=MaYfCD4rTML5Ycu7BZhkKmotpr4nOsux8F3EBFXAzhA=; b=kbszz4n4SWxJHEFHVy5F7Xzb7u1VL1ftHJP2qhZ+r9Aal6D+ZWfTq5pGf9S0pATEjpzj+w/HDVZTKIrdtDoiUMZcjMkmFbTD04HsTZ3U/6AfTMpOlD67KBayDjD0JGJSeN22D/ndLQ6iJO0UUWT7CkdHZ6ZPaTHex8xZC+mDOPs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:references:x-google-sender-auth; b=Rhj1ip4C9KiR9+o0QE2MALHA+rk3zSjE0Fny6mRjcPxkjiY1mecJ0798+II1z5wNHw/p/M9apB4NqjOnfKUM/Zld3hnJ1au4jiNGlffOdiygLfegZ9HTLKfnJzYqzHdFE5t0Bm5saPBvwqAwQdo7NUzz1jtYmHgRuAZFJJ/MASw= Original-Received: by 10.143.162.8 with SMTP id p8mr187099wfo.1189360890796; Sun, 09 Sep 2007 11:01:30 -0700 (PDT) Original-Received: by 10.143.4.2 with HTTP; Sun, 9 Sep 2007 11:01:30 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: a719399c7af92362 X-Detected-Kernel: Linux 2.6 (newer, 2) X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:78322 gmane.emacs.pretest.bugs:19789 Archived-At: --===============1812386073== Content-Type: multipart/alternative; boundary="----=_Part_7938_28600511.1189360890792" ------=_Part_7938_28600511.1189360890792 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On 9/9/07, Richard Stallman wrote: > This is an inelegant way of doing it; > does it fix your problem? No, it doesn't. It ends up calling self-insert-command, which inserts the '.' character, rather than calling hexl-self-insert-command, which inserts the hex code for the '.' character. This is an inelegant way of doing it which does work: *** Backup/completion.el.~1~ Sun Sep 9 19:44:37 2007 --- completion.el Sun Sep 9 19:58:42 2007 *************** *** 2231,2238 **** (defun completion-separator-self-insert-command (arg) (interactive "p") ! (use-completion-before-separator) ! (self-insert-command arg)) (defun completion-separator-self-insert-autofilling (arg) (interactive "p") --- 2231,2241 ---- (defun completion-separator-self-insert-command (arg) (interactive "p") ! (message "major is '%s'" major-mode) ! (if (eq major-mode 'hexl-mode) ! (hexl-self-insert-command arg) ! (use-completion-before-separator) ! (self-insert-command arg))) (defun completion-separator-self-insert-autofilling (arg) (interactive "p") ------=_Part_7938_28600511.1189360890792 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On 9/9/07, Richard Stallman <rms@gnu.org> wrote:

This is an inelegant way of doing it;
does it fix your problem?

No, it doesn't.  It ends up calling self-insert-command, which inserts the '.' character, rather than calling hexl-self-insert-command, which inserts the hex code for the '.' character.

This is an inelegant way of doing it which does work:

*** Backup/completion.el.~1~    Sun Sep  9 19:44:37 2007
--- completion.el    Sun Sep  9 19:58:42 2007
***************
*** 2231,2238 ****
 
  (defun completion-separator-self-insert-command (arg)
    (interactive "p")
!   (use-completion-before-separator)
!   (self-insert-command arg))
 
  (defun completion-separator-self-insert-autofilling (arg)
    (interactive "p")
--- 2231,2241 ----
 
  (defun completion-separator-self-insert-command (arg)
    (interactive "p")
!   (message "major is '%s'" major-mode)
!   (if (eq major-mode 'hexl-mode)
!       (hexl-self-insert-command arg)
!     (use-completion-before-separator)
!     (self-insert-command arg)))
 
  (defun completion-separator-self-insert-autofilling (arg)
    (interactive "p")



------=_Part_7938_28600511.1189360890792-- --===============1812386073== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --===============1812386073==--