From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Charl P. Botha" Newsgroups: gmane.emacs.bugs Subject: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist Date: Fri, 16 Dec 2022 07:58:46 +0200 Message-ID: References: <94476C6A-CCEA-43CE-A6B7-0232998FCBCC@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=04f1092c324644f6aa046898ec265df1 Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38021"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.7.0-alpha0-1185-g841157300a-fm-20221208.002-g84115730 Cc: Eli Zaretskii , 59945@debbugs.gnu.org To: "Yuan Fu" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 16 09:37:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p66DU-0009aP-Kh for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Dec 2022 09:37:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p66DL-0006qY-FU; Fri, 16 Dec 2022 03:37:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p66DH-0006pc-0R for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2022 03:37:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p66DG-0000Q0-Lh for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2022 03:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p66DG-0005vm-CO for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2022 03:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Charl P. Botha" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Dec 2022 08:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59945 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59945-submit@debbugs.gnu.org id=B59945.167117978322784 (code B ref 59945); Fri, 16 Dec 2022 08:37:02 +0000 Original-Received: (at 59945) by debbugs.gnu.org; 16 Dec 2022 08:36:23 +0000 Original-Received: from localhost ([127.0.0.1]:47960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p66CZ-0005vQ-SM for submit@debbugs.gnu.org; Fri, 16 Dec 2022 03:36:23 -0500 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:54143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p63kY-0003x3-Oj for 59945@debbugs.gnu.org; Fri, 16 Dec 2022 00:59:15 -0500 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 9180C5C010A; Fri, 16 Dec 2022 00:59:09 -0500 (EST) Original-Received: from imap44 ([10.202.2.94]) by compute2.internal (MEProxy); Fri, 16 Dec 2022 00:59:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vxlabs.com; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1671170349; x=1671256749; bh=APmeFgAwwG iVv/GfXAsVaM71qhmEuX3LLzsBhOnSYUE=; b=XXQptWzGaYfm6uMZKEVgMhUB+g 1cu7d0TgXBRs3XZqOEb2DG46QXBh/mT+CZ27Ehut1oobfPyVjU8uV99d6R8G6KYU rl//7Gm1xNklYmc+JO4Di/ZTJwgEoulQU7ppgbYrXQc1kgHhuaX62uodGsA4NL4X Bid2vC0A3ypYcF8AuQk1tyDcrkXBLiwp1tM/+M8i8z/4hRKwpvOvkan+8xbJ9FVH GGjatgczkoUTdCfbo/UJajXipAWoKxekVswv4Fn78Zlccyf2rolAU3tWjdpbCL5L gi6QrSnMd7/1Is2LSxonUGgEa5Cc3oXijrW87wX4arQqo2+0c8FzJfytKUMA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1671170349; x=1671256749; bh=APmeFgAwwGiVv/GfXAsVaM71qhmE uX3LLzsBhOnSYUE=; b=nEQtR9dfqjbsskR5FjtHvdugQR9zxTFv0NguRayiwby/ xajzXfHiGOafskYiwYwGHlouCeQJIxxDu7oH/8TLNtuq5rX5kGcheQvvSBxNDnOY rW+pzWEYOzuBUnVgAjOs65iP3mBmjn/SkTkg319hbiBZlUfc0+k+OZWzzNH1QFLd zVWr4dQvZy8SNHdJeG8sOigu8O/3gh2d1QjgmF5o5erkyCjrpIACivm8p8lzvsVp W7v80KiXOgyuSwFNLibF9Ca2Yx8sd5+G+16XD7cgB21Xy0lNCC8UQcRkPdoJzug+ WSfAlBiTBgAk19qTwKFBmcvU6vTFKH9xT4d5OSS92Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeeigdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesmhdtreerreerjeenucfhrhhomhepfdevhhgr rhhlucfrrdcuuehothhhrgdfuceotghpsghothhhrgesvhiglhgrsghsrdgtohhmqeenuc ggtffrrghtthgvrhhnpedufeejiedvffefhfeiieehgfdtudejffevuedvueevudelledu veeffeejgfelueenucffohhmrghinhepghhnuhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegtphgsohhthhgrsehvgihlrggsshdr tghomh X-ME-Proxy: Feedback-ID: i502842e6:Fastmail Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id 15F2736A0073; Fri, 16 Dec 2022 00:59:08 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: <94476C6A-CCEA-43CE-A6B7-0232998FCBCC@gmail.com> X-Mailman-Approved-At: Fri, 16 Dec 2022 03:36:18 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251193 Archived-At: --04f1092c324644f6aa046898ec265df1 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Dear Yuan, On Fri, Dec 16, 2022, at 03:40, Yuan Fu wrote: > "Charl P. Botha" writes: >> In the meantime, I've sent my signed copyright assignment, and my emp= loyer's docusigned disclaimer of rights, to the FSF. >> >> I would be super grateful if you could add the commit when you can ma= ke the time. > > Thanks. Unless I=E2=80=99m missing something, your patch is a diff fil= e rather > than a patch file. You can generate one with > > git format-patch -1 --stdout >~/mypatch.patch > > Don=E2=80=99t worry about commit message this time, I=E2=80=99ll rewor= d your commit and > add it. But if you want to submit more patches in the future I recomme= nd > you to read CONTRIBUTE file under repo root, which describes the commit > message format Emacs uses. I followed the instructions at https://www.gnu.org/software/emacs/manual= /html_node/emacs/Sending-Patches.html which said to use "git format-patc= h master" and include either inline (which I did) or as a mime attachmen= t. I have now re-done it using your advice above, and included the patch fi= le as attachment to this email. Next time (would be great if it happens), I'll attach by default. Kind regards, Charl --04f1092c324644f6aa046898ec265df1 Content-Disposition: attachment; filename="cpb-fix-empty-pairs-js-ts.patch" Content-Type: application/octet-stream; name="cpb-fix-empty-pairs-js-ts.patch" Content-Transfer-Encoding: BASE64 RnJvbSAwMWM0ZjNhZGU1YzYxYjk2NzE4YmJmMzZiMmVkN2I0YjFlZDg0YWEwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiQ2hhcmwgUC4gQm90aGEiIDxjcGJvdGhhQHZ4bGFi cy5jb20+CkRhdGU6IFNhdCwgMTAgRGVjIDIwMjIgMTk6MDk6MzggKzAyMDAKU3ViamVjdDog W1BBVENIXSBGaXggZW1wdHkgcGFpcnMgaW4ganMgdHJlZS1zaXR0ZXIgaW1lbnUgYWxpc3QK ClRoZSBjdXJyZW50IGpzLS10cmVlc2l0LWltZW51LCB1c2VkIGJ5IHRoZSBKYXZhU2NyaXB0 LCBUeXBlU2NyaXB0IGFuZApUU1ggdHJlZS1zaXR0ZXIgbW9kZXMsIHdvdWxkIHJldHVybiBl bXB0eSBwYWlycyBpbiB0aGUgaW1lbnUgYWxpc3QgaWYKdGhlcmUgd2VyZSBub25lIG9mIHRo YXQgdHlwZSBvZiBzeW1ib2wuCgpUaGlzIHdvdWxkIGJyZWFrIGJvdGggdGhlIGJ1aWx0IGlu IGltZW51IGFuZCBhbHNvIHBhY2thZ2VzIGxpa2UKY29uc3VsdC1pbWVudS4KClNlZSBodHRw czovL2dpdGh1Yi5jb20vbWluYWQvY29uc3VsdC9pc3N1ZXMvNjk3IGZvciB0aGUgZGlzY3Vz c2lvbiB0aGVyZS4KLS0tCiBsaXNwL3Byb2dtb2Rlcy9qcy5lbCB8IDE1ICsrKysrKysrKysr LS0tLQogMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvanMuZWwgYi9saXNwL3Byb2dtb2Rlcy9q cy5lbAppbmRleCBlMDYyNTk1MWI2NS4uOGZkMDM4NmU2YWUgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL2pzLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2pzLmVsCkBAIC0zNzM4LDEw ICszNzM4LDE3IEBAIGpzLS10cmVlc2l0LWltZW51CiAgICAgICAgICAoZnVuYy10cmVlICh0 cmVlc2l0LWluZHVjZS1zcGFyc2UtdHJlZQogICAgICAgICAgICAgICAgICAgICAgbm9kZSAi ZnVuY3Rpb25fZGVjbGFyYXRpb24iIG5pbCAxMDAwKSkKICAgICAgICAgICh2YXItdHJlZSAo dHJlZXNpdC1pbmR1Y2Utc3BhcnNlLXRyZWUKLSAgICAgICAgICAgICAgICAgICAgbm9kZSAi bGV4aWNhbF9kZWNsYXJhdGlvbiIgbmlsIDEwMDApKSkKLSAgICBgKCgiQ2xhc3MiIC4gLChq cy0tdHJlZXNpdC1pbWVudS0xIGNsYXNzLXRyZWUpKQotICAgICAgKCJWYXJpYWJsZSIgLiAs KGpzLS10cmVlc2l0LWltZW51LTEgdmFyLXRyZWUpKQotICAgICAgKCJGdW5jdGlvbiIgLiAs KGpzLS10cmVlc2l0LWltZW51LTEgZnVuYy10cmVlKSkpKSkKKyAgICAgICAgICAgICAgICAg ICAgbm9kZSAibGV4aWNhbF9kZWNsYXJhdGlvbiIgbmlsIDEwMDApKQorICAgICAgICAgKGlt ZW51LWFsaXN0IG5pbCkpCisgICAgOzsgd2hlbiBhIHN1Yi10cmVlIGlzIGVtcHR5LCB3ZSBz aG91bGQgbm90IHJldHVybiB0aGF0IHBhaXIgYXQgYWxsCisgICAgOzsgaHR0cHM6Ly9naXRo dWIuY29tL21pbmFkL2NvbnN1bHQvaXNzdWVzLzY5NyNpc3N1ZWNvbW1lbnQtMTM0NTMwMjcz NAorICAgICh3aGVuIGZ1bmMtdHJlZQorICAgICAgKHNldHEgaW1lbnUtYWxpc3QgKGNvbnMg YCgiRnVuY3Rpb24iIC4gLChqcy0tdHJlZXNpdC1pbWVudS0xIGZ1bmMtdHJlZSkpIGltZW51 LWFsaXN0KSkpCisgICAgKHdoZW4gdmFyLXRyZWUKKyAgICAgIChzZXRxIGltZW51LWFsaXN0 IChjb25zIGAoIlZhcmlhYmxlIiAuICwoanMtLXRyZWVzaXQtaW1lbnUtMSB2YXItdHJlZSkp IGltZW51LWFsaXN0KSkpCisgICAgKHdoZW4gY2xhc3MtdHJlZQorICAgICAgKHNldHEgaW1l bnUtYWxpc3QgKGNvbnMgYCgiQ2xhc3MiIC4gLChqcy0tdHJlZXNpdC1pbWVudS0xIGNsYXNz LXRyZWUpKSBpbWVudS1hbGlzdCkpKQorICAgIGltZW51LWFsaXN0KSkKIAogOzs7IE1haW4g RnVuY3Rpb24KIAotLSAKMi4yNS4xCgo= --04f1092c324644f6aa046898ec265df1--