From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: master b573aaab76b 2/2: ; Make utility functions for getting the Eshell non-special regexps Date: Mon, 21 Oct 2024 14:26:21 -0700 Message-ID: References: <172948055644.3805440.7086621144248259008@vcs3.savannah.gnu.org> <20241021031557.6BAE930F2F1@vcs3.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31203"; mail-complaints-to="usenet@ciao.gmane.io" To: Andrea Corallo , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 21 23:27:00 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t2zvY-00080h-5C for ged-emacs-devel@m.gmane-mx.org; Mon, 21 Oct 2024 23:27:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t2zux-0008Lb-MZ; Mon, 21 Oct 2024 17:26:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2zuv-0008Kw-Up for emacs-devel@gnu.org; Mon, 21 Oct 2024 17:26:22 -0400 Original-Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t2zuu-0003Ru-EN; Mon, 21 Oct 2024 17:26:21 -0400 Original-Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-20c8c50fdd9so37103835ad.0; Mon, 21 Oct 2024 14:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729545978; x=1730150778; darn=gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=rxmvSPB/fKSdclZ1miHpROBmJGTiEcG7MlQrPml83aQ=; b=iXKoHlgmI0Tw/RbcsXF54CwtkwwA6yqQkkaPBT9ozmGObPjze/xcXhCJm9hFlDuDdq kqcw0GO/zwd9/eD7OQi/wlFt9DJ+LCNqeP1LPvRAGnJJSus9gGdDHyY6XhnkqOYMHFyH kkYz0Yok5FMGOdZOUCgLgqYRCtl1jdOByQ6GzFzOtY88ogmN1/hs0mMHB8y+qOTT7JRL JtOZtP57aEzyna4oG3cFFqgfOzmhZvXmXIByjXpre/f9p+qhtOeRUTQMJF4r0+GSPJXi 4u+h7M4RClxJxJt0Sb2bknyo+IBYwa99jQsHzIOaNk8+5C7kWlDeePHwgWmspfo9u7f6 oJgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729545978; x=1730150778; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rxmvSPB/fKSdclZ1miHpROBmJGTiEcG7MlQrPml83aQ=; b=POTj54ln4zIF6r6Dr7mWG8ovAHrA4YdASj30LYXIA/2V8XzRd7BmlzFsaJhk4aGRXd e7nP3kCNXiTIuoLZGA1QZKtV7zsZQmLT05bwxBPCpvYkIm/jGOa2D5yrbK4B7+Ks9o+X vQzM16TqcVuuMIWnvbaIgLZ/0HQrAJll0gybdACEbzfuYYRfgNpxUHE7RF5iBzFU579M X8zP9VrP8a2VPmVHz91snDL/ipevVBAyZ6wfHwgK0wD39t5oZA7aeES/A0W8ADeX4Boz UB9LrvyI4L6ed/ZfbSVdteuw3AonBA9jdbtwh1SHN0SvarF/9lglYWiMebsxahN6Na0J a+sQ== X-Forwarded-Encrypted: i=1; AJvYcCVycTyou4xJqPz8UNzik0AtZtJf5/pV0JVjqL9gX9Vn90FRln4d9l9iJTIHwPnfHpguv6sZv75LvxBhxw==@gnu.org X-Gm-Message-State: AOJu0Yznw59SY4WTwR9dJRHDDU1I/HLMlBwspCdAw+rAZdhcExahVcfG ne2cM+CLWp1XwP+aAGI0lB3B7KdzBTfhMGrOv3Ph86nCRK0AdB1P+15nug== X-Google-Smtp-Source: AGHT+IFpDlsIGBVMBFfAjbcQzs+tpmyAcxVJ3MIYvzXn1+DQyDvpNzFsUbxfBbjWx/OU/KYJIUsKmQ== X-Received: by 2002:a17:902:e5c8:b0:20b:4d50:e4c7 with SMTP id d9443c01a7336-20e96969a5amr14634785ad.0.1729545978220; Mon, 21 Oct 2024 14:26:18 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-20e7f0f400dsm30317015ad.255.2024.10.21.14.26.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Oct 2024 14:26:17 -0700 (PDT) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324714 Archived-At: On 10/21/2024 1:00 AM, Andrea Corallo wrote: > If I'm not wrong this commit once merged into master is causing the > following warnings: > > eshell/em-script.el:75:9: Warning: Unused lexical variable > ‘eshell-outside-quote-regexp’ > > eshell/em-script.el:74:9: Warning: Unused lexical variable > ‘eshell-inside-quote-regexp’ > > Would you ming having a look? Thanks for letting me know. It turns out there was an actual bug here that my previous change helped reveal: the previous code was trying to work around the fact that the Eshell startup scripts were running before the Eshell session was fully-initialized, which is iffy at best. I've now changed this so that there's a new 'eshell-after-initialize-hook' that em-script.el can use. That's more correct and lets us avoid the let-binding that caused this warning.