all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: Andrea Corallo <acorallo@gnu.org>, emacs-devel@gnu.org
Subject: Re: master b573aaab76b 2/2: ; Make utility functions for getting the Eshell non-special regexps
Date: Mon, 21 Oct 2024 14:26:21 -0700	[thread overview]
Message-ID: <a8ef17ef-41a2-e028-42aa-4bc8f284e5d6@gmail.com> (raw)
In-Reply-To: <yp1jze1ubpx.fsf@fencepost.gnu.org>

On 10/21/2024 1:00 AM, Andrea Corallo wrote:
> If I'm not wrong this commit once merged into master is causing the
> following warnings:
> 
> eshell/em-script.el:75:9: Warning: Unused lexical variable
> ‘eshell-outside-quote-regexp’
> 
> eshell/em-script.el:74:9: Warning: Unused lexical variable
> ‘eshell-inside-quote-regexp’
> 
> Would you ming having a look?

Thanks for letting me know. It turns out there was an actual bug here 
that my previous change helped reveal: the previous code was trying to 
work around the fact that the Eshell startup scripts were running before 
the Eshell session was fully-initialized, which is iffy at best.

I've now changed this so that there's a new 
'eshell-after-initialize-hook' that em-script.el can use. That's more 
correct and lets us avoid the let-binding that caused this warning.




  reply	other threads:[~2024-10-21 21:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <172948055644.3805440.7086621144248259008@vcs3.savannah.gnu.org>
     [not found] ` <20241021031557.6BAE930F2F1@vcs3.savannah.gnu.org>
2024-10-21  8:00   ` master b573aaab76b 2/2: ; Make utility functions for getting the Eshell non-special regexps Andrea Corallo
2024-10-21 21:26     ` Jim Porter [this message]
2024-10-22 16:31       ` Andrea Corallo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8ef17ef-41a2-e028-42aa-4bc8f284e5d6@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=acorallo@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.