From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses Date: Sat, 1 Jun 2024 04:56:35 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32286"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 71209@debbugs.gnu.org To: Randy Taylor , Noah Peart Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 01 03:57:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sDDzZ-0008DN-Ve for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Jun 2024 03:57:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sDDzI-0001Wg-RS; Fri, 31 May 2024 21:56:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDDzH-0001W9-38 for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 21:56:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sDDzG-0000Q6-Qy for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 21:56:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sDDzS-00086C-5C for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 21:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Jun 2024 01:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71209 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71209-submit@debbugs.gnu.org id=B71209.171720701831122 (code B ref 71209); Sat, 01 Jun 2024 01:57:02 +0000 Original-Received: (at 71209) by debbugs.gnu.org; 1 Jun 2024 01:56:58 +0000 Original-Received: from localhost ([127.0.0.1]:55529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDDzO-00085u-5m for submit@debbugs.gnu.org; Fri, 31 May 2024 21:56:58 -0400 Original-Received: from wfout2-smtp.messagingengine.com ([64.147.123.145]:33989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDDzM-00085h-3f for 71209@debbugs.gnu.org; Fri, 31 May 2024 21:56:56 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.west.internal (Postfix) with ESMTP id 9AAEE1C000AA; Fri, 31 May 2024 21:56:38 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 31 May 2024 21:56:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1717206998; x=1717293398; bh=R+9VuWvoFoSjKODZ+DZ5X/oq9nPug1T6rdOI8MFqiGs=; b= Z9AfPqqm/b5Irpeg45C+Gaahqe+8UjdqhIziA7cfaXBaVWJFzWMKAHjxO39Smrty sKPnGNhrDbdUSKkmAVIfNQIW/DdyBsITfdEaxeslAFkpyTMxJAcEImfROoAGiySQ oRThVFNTfx4W0El6DW0vcf35h3aVJGZhUB4zMrfPHx/zajg6Ep6hoPURVuVmlDfb Has8BSePGkh2nvxFot4SMxMtf+UvSkjvYOCgARE7+n1VRRl5On/s6GpFi/3WUcBe F0ZE43Kn7wCHpkGL13m9KSISbYIPuzgUuMnbzEgThAEDZ24n74iY6pBtvyvTCsQj L1RqFMHWMRMn4Pq/2/aeTQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717206998; x= 1717293398; bh=R+9VuWvoFoSjKODZ+DZ5X/oq9nPug1T6rdOI8MFqiGs=; b=l KfiBWGr6odqTq9/DzdDGMva/mkpSiD45ahPODqawu2FFnQl80/8U20DoODGSH0aa a3QHRrsrxCYieEW3c7plOjB5zwhfsQcFQ5pgctSMuHwECJzLgeerld7JdOqSvvLN tqbLrJgkMgdR89dlz0kA9gDOko3+amfdiC1/LkTtWtLy1NMpWNPmQ8qtREBKOwe9 RUq7QoSNXHcTUJZSqLRqXF0Llp//FDOPR0wnOcYkVZyPvJDVeGmWIZ6JwIUyj/WS Or2xw05yShYMs1DYhy3Wd1BxR8XRkCwS2JxI1QMh6atvbifZV9065Sgv2HqhFWyO P6U4hZM4Dz6GRI2IXQGXQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdekjedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 31 May 2024 21:56:36 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286309 Archived-At: On 01/06/2024 04:09, Randy Taylor wrote: > On Thursday, May 30th, 2024 at 09:25, Noah Peart wrote: >>> it seems we already highlight this when at treesit-font-lock-level 4? >> They get highlighted with `font-lock-variable-use-face` at level 4, but shouldn't >> they be getting `font-lock-variable-name-face` in the 'definition feature? >> > > Indeed, thanks. Could someone please install the patch? Thanks in advance. Now pushed to master. Thanks Noah! > Seems like c++-ts-mode will need to get updated too, as with: > for (const auto& i : things) {} > i gets font-lock-variable-use-face. I wonder if any other ts modes > have similar issues. I would probably rather call those "missing features" rather than issues. I've added such highlightings to some of the constructs for several treesit modes last year, but more can be missing, so contributions welcome.