From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: server.el test failures Date: Thu, 2 Mar 2023 14:15:49 -0800 Message-ID: References: <877h40vb8h.fsf@mail.jurta.org> <861qmvcglp.fsf@aarsen.me> <98e880a0-d076-cfd9-b39d-50c84fa8975a@gmail.com> <811d85e0-4032-68df-bc0c-1073ff5d1b96@cs.ucla.edu> <5a38c18d-263c-223b-7335-8395a10eb494@gmail.com> <00864fe6-b63a-685f-2d20-4e1fd5a5573e@cs.ucla.edu> <3e7c26d6-215a-6c29-5304-0e32f42b2174@gmail.com> <87zg8z5afj.fsf@gmail.com> <83ttz7giib.fsf@gnu.org> <87r0ub561t.fsf@gmail.com> <83sfergdgf.fsf@gnu.org> <87h6v6qlq7.fsf@gmail.com> <83ilfmgf88.fsf@gnu.org> <87cz5uq6s1.fsf@gmail.com> <84c54b68-e787-2bc5-0908-52d953b557d2@gmail.com> <83wn41fvc9.fsf@gnu.org> <878rggrict.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30117"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , eggert@cs.ucla.edu, emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 02 23:16:55 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXrEM-0007Z7-D2 for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Mar 2023 23:16:54 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXrDR-0004O1-GF; Thu, 02 Mar 2023 17:15:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXrDQ-0004Nr-JW for emacs-devel@gnu.org; Thu, 02 Mar 2023 17:15:56 -0500 Original-Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXrDP-0006R4-0b; Thu, 02 Mar 2023 17:15:56 -0500 Original-Received: by mail-pj1-x1033.google.com with SMTP id 6-20020a17090a190600b00237c5b6ecd7so4234998pjg.4; Thu, 02 Mar 2023 14:15:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677795352; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=qbPAenzKm7LQv2bNQBkOeo0R1dfRaYK3xfxDx127LeI=; b=ObxYWlw6cgRgTmiavQP9yDXAXB81w6NxyGzYRj+hXdUmsiSxnAuqxhb8zVbc1J7XUq bjPHJm/szvGlwlaG3LcrwTOXzxIaiGQCLXVkamfzI55H+CN9LGc8b206L951pNtMJFwl X0GiI5hTW+NhaqMxHYkP1XFcln+/N91yOERr2WoLW/32AOL3cXUmvVTZOuJIGHSKDygR 4V4neu+elGx1u/hR/1pfepbCMJk7dfmnTMe2MTA1SjBmBFGujLKnoCwyMV3ZvbpKlcu3 og+tOZyefIieVrhCvjtgO+xKjafpDqKK6aOaCn8cXXWQ466YsIiu9kr/5M2ge3nQWP/8 /kFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677795352; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qbPAenzKm7LQv2bNQBkOeo0R1dfRaYK3xfxDx127LeI=; b=UyceeK+y4XuK5RmPsjMWW8G0MmSIrUIO2/LrJhzsbddeFm3hI6EpK2S/2+MYDNFkjL ODzH0lYsczrk6hTz7LxG/uVl6zLhs+oY3gnVGltVAXL1lMndVUqT7i4AV8IcnlPs9RGr C3lOBwiCiuRjmMRtI4L6K1SiAnZ/ZJYsZ2x52jiG1mSvs73Zscjc/HafHqMiMAvYfcgu c5NjYoB5fiqk6xs8HgKKX940EDM8pzg7qq3jPVCigs+M2UAC1isHr5n2Z0j/GFXUeMSO 1ajKQCcUHWe1o1ZiuzJiH9b3ZbG8Vh6Bbh/crspzFCdRiZR//zDrmSJWmn8ACaf2399V ZOHA== X-Gm-Message-State: AO0yUKVK7VvOsc23GkD+4UlgyD4cy9lCeIjDK44CcJ8Vyv6zHbrrjDWJ +AJsvoIhACXvvswF0gCtI34= X-Google-Smtp-Source: AK7set8EPfC6Wu1pME/0Pmc/RP1YF4/2Pr5MZ0z7c4oOnmF3GggIkETPYUv1qs+F9Qthq7FqfUi0Yw== X-Received: by 2002:a05:6a20:938e:b0:cd:202c:5085 with SMTP id x14-20020a056a20938e00b000cd202c5085mr15139327pzh.55.1677795352534; Thu, 02 Mar 2023 14:15:52 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id r9-20020a62e409000000b005a54a978c1bsm197403pfh.7.2023.03.02.14.15.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Mar 2023 14:15:52 -0800 (PST) Content-Language: en-US In-Reply-To: <878rggrict.fsf@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::1033; envelope-from=jporterbugs@gmail.com; helo=mail-pj1-x1033.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303903 Archived-At: On 3/1/2023 12:22 AM, Robert Pluim wrote: >>>>>> On Tue, 28 Feb 2023 11:41:41 -0800, Jim Porter said: > Jim> + ;; When running in a batch session, we can't create a GUI frame. > > Itʼs not that we canʼt, itʼs that we shouldnʼt. If we install a SIGIO > handler and run the test with DISPLAY set, a GUI frame appears > briefly. Well, since we don't have a SIGIO handler (and merely adding one wouldn't be a useful change, it seems), I'd say "can't" applies for now at least. :) But it would probably make sense to expand this comment to explain *why*, since it's not as informative as it could be... > Jim> + (when noninteractive > Jim> + (push '(display . nil) parameters)) > Jim> + > > I think that might be better off using `alist-get' + `setf' to avoid > having two `display' elements in the parameters. Would that be safe? Since 'parameters' is an argument, we don't actually know how it was created or if modifying in-place would be ok. If it were just a regular quoted list, using 'setf' could cause problems.