Re: New warnings compiling emacs just now

[Gregory Heytings <gregory@heytings.org>]

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]


>> I'm compiling Emacs master right now (on macOS Catalina) and have 
>> detected a couple of warnings 'assignment to free variable repeat-map' 
>> (one in tab-bar.el and one in window.el) Which I haven't seen before...
>
> I don't see any warnings, so please show the warnings you see.
>

I see them (and have seen them for a week or two), too:

In toplevel form:
tab-bar.el:2093:33: Warning: assignment to free variable ‘repeat-map’
In toplevel form:
window.el:10261:33: Warning: assignment to free variable ‘repeat-map’

Patch attached.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-diff; name=Fix-two-assignment-to-free-variable-repeat-map-warni.patch, Size: 1189 bytes --]

From 38404247ab682bf9692bd5bc5d9c2a94aa22ef65 Mon Sep 17 00:00:00 2001
From: Gregory Heytings <gregory@heytings.org>
Date: Thu, 22 Apr 2021 07:42:19 +0000
Subject: [PATCH] Fix two "assignment to free variable 'repeat-map'" warnings.

---
 lisp/tab-bar.el | 2 ++
 lisp/window.el  | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el
index f3c2fb7ed9..e5abe6790d 100644
--- a/lisp/tab-bar.el
+++ b/lisp/tab-bar.el
@@ -2085,6 +2085,8 @@ tab-bar-switch-repeat-map
 (put 'tab-next 'repeat-map 'tab-bar-switch-repeat-map)
 (put 'tab-previous 'repeat-map 'tab-bar-switch-repeat-map)
 
+(defvar repeat-map)
+
 (defvar tab-bar-move-repeat-map
   (let ((map (make-sparse-keymap)))
     (define-key map "m" 'tab-move)
diff --git a/lisp/window.el b/lisp/window.el
index 071761ea50..6d798c5d75 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -10253,6 +10253,8 @@ ctl-x-4-map
 (define-key ctl-x-4-map "1" 'same-window-prefix)
 (define-key ctl-x-4-map "4" 'other-window-prefix)
 
+(defvar repeat-map)
+
 (defvar other-window-repeat-map
   (let ((map (make-sparse-keymap)))
     (define-key map "o" 'other-window)
-- 
2.30.2