From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#59575: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter Date: Sun, 27 Nov 2022 15:04:24 +0200 Message-ID: References: <83zgcdsw90.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26408"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: Eli Zaretskii , 59575@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 27 14:05:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozHLV-0006hW-ET for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Nov 2022 14:05:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozHLI-00087U-BD; Sun, 27 Nov 2022 08:05:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozHLD-00087C-Gf for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 08:05:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozHLD-0008J3-3u for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 08:05:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ozHLB-0004Ub-Sl for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 08:05:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Nov 2022 13:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59575 X-GNU-PR-Package: emacs Original-Received: via spool by 59575-submit@debbugs.gnu.org id=B59575.166955427517257 (code B ref 59575); Sun, 27 Nov 2022 13:05:01 +0000 Original-Received: (at 59575) by debbugs.gnu.org; 27 Nov 2022 13:04:35 +0000 Original-Received: from localhost ([127.0.0.1]:42253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozHKk-0004UH-Lb for submit@debbugs.gnu.org; Sun, 27 Nov 2022 08:04:34 -0500 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:41699) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozHKi-0004UB-Qc for 59575@debbugs.gnu.org; Sun, 27 Nov 2022 08:04:33 -0500 Original-Received: by mail-wr1-f45.google.com with SMTP id q7so12035815wrr.8 for <59575@debbugs.gnu.org>; Sun, 27 Nov 2022 05:04:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=6BymVVU0bznvOTSFz0mVQjiNxf9pmAYAFw5n45tSpWM=; b=KQ/iJk0TlPnbRv3+mqOoL00qDnnF8WYtRqwTSmRPdgt+U9LnelbPs+rzMTT6sHIAmr GcbnAzoWVRoWIGpSgQ7QiHfniINEcSzI9INr9cCACvFhfIOOiV7qlRQZK0vfh7XIzZIB TeH3OIZ2L1SfrrSuZz585aroFb6xavgolC/dfhSe2huyBC3D6PCDaDyh59sYWk8rM1OQ q+YwfsMyvLGUQv7x0ZrScWuaQNsjfGVLrd1ISnP91US53tGG2OImoQLixmIRzG9COFhZ ztZCw4qDe4Jbdh5qb8W0wFJaizw6G3NxVCnjZY+Kl1DkLRgDTI1tUyyikIcRQpW0Aur6 n6dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6BymVVU0bznvOTSFz0mVQjiNxf9pmAYAFw5n45tSpWM=; b=JBEIJIfhdK54/w9ZUCzgKXvhlv4rqgnk3q0r8BdouqvwAo85LhRqSrdtS4JKcWdjdT DLKWV88ZSohyJQCYk+9xB24LvMv4+89539b0p02fL/yF9zAfXRK6us+8EIoQUTALSb8t vUgjJp8oG4PMtWretvkNp2jH3LBGBtORKe9MH8k+pm+xz7C2dRGAPnMc/0Gns3sf+z6n y0LsV98y6WF/PjGUJKHUKrvaSTG/aQ7iNMg+dEeo+p9vg7S5l/gTATjD3+pYPiSVFfvO wrFNzndqQugp0iV2T2FcStAvjxVwpXDjetY5s1IPBbtHvU5eu0kwWSxLV2abm9tmVJEc VjVg== X-Gm-Message-State: ANoB5pnRojaCxbXj6YoAw/omXh6ZJwLAzHbCExI8Nt+4v8ZL6RQ93cR3 Bue7+6ItItWYUppq/DpESV8= X-Google-Smtp-Source: AA0mqf6CHKFGdhC6CyHIMLmRGxf1aMqAa/IZS7uIflFJGanD2w3bLer3IdpBHBY94qGjbAFIsTcDyw== X-Received: by 2002:a5d:4e49:0:b0:242:d4f:961 with SMTP id r9-20020a5d4e49000000b002420d4f0961mr3554757wrt.474.1669554267071; Sun, 27 Nov 2022 05:04:27 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id k1-20020a7bc401000000b003cfbe1da539sm11750447wmi.36.2022.11.27.05.04.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Nov 2022 05:04:26 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249208 Archived-At: On 27/11/22 13:22, Juanma Barranquero wrote: > On Sun, Nov 27, 2022 at 12:11 PM Juanma Barranquero > wrote: > > That should be changed to > >  (cl-ecase xref-file-name-display >      (abs group) >      (nondirectory > -     (if (string-match-p "\\`~?/" group) > +     (if (string-match-p "\\`\\(~\\|[A-Za-z]:\\)?/" group) >           (file-name-nondirectory group) >         group)) >      (project-relative > > or something similar. > > > Silly me, that should just use `file-name-absolute-p'. > > OK to fix this, regardless of what's decided for the original bug? Yes, please. The original idea was to avoid costly operations (in case the list of matches is long), but looks like file-name-absolute-p doesn't hit the disk.