all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ken Brown <kbrown@cornell.edu>
To: 34527@debbugs.gnu.org
Subject: bug#34527: 27.0.50; Cygwin now has timer_getoverrun
Date: Mon, 18 Feb 2019 15:16:32 +0000	[thread overview]
Message-ID: <a7b6ea74-296f-3464-9cb0-69d27f66ea84@cornell.edu> (raw)

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

The latest release of Cygwin supports the timer_getoverrun function, so
there's no longer a need for the workaround in profiler.c that defines
timer_getoverrun as a macro.  The attached patch causes the function to
be used rather than the macro when it exists.

OK for master?

Ken

[-- Attachment #2: 0001-Use-timer_getoverrun-on-Cygwin-when-possible.patch --]
[-- Type: text/plain, Size: 1596 bytes --]

From 162aa52538d38a0ca7f7969f79b1e1cd7f708e3c Mon Sep 17 00:00:00 2001
From: Ken Brown <kbrown@cornell.edu>
Date: Sun, 17 Feb 2019 12:10:26 -0500
Subject: [PATCH] Use 'timer_getoverrun' on Cygwin when possible

* configure.ac: Add a check for the 'timer_getoverrun' function.

* src/profiler.c [CYGWIN] : Define 'timer_getoverrun' as a
macro only on versions of Cygwin where it is not already
defined as a function.
---
 configure.ac   | 2 +-
 src/profiler.c | 7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/configure.ac b/configure.ac
index 58579008f3..c26eb6d1e8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -4126,7 +4126,7 @@ AC_DEFUN
 lrand48 random rint trunc \
 select getpagesize setlocale newlocale \
 getrlimit setrlimit shutdown \
-pthread_sigmask strsignal setitimer \
+pthread_sigmask strsignal setitimer timer_getoverrun \
 sendto recvfrom getsockname getifaddrs freeifaddrs \
 gai_strerror sync \
 getpwent endpwent getgrent endgrent \
diff --git a/src/profiler.c b/src/profiler.c
index 15a0eef0d3..293e52633a 100644
--- a/src/profiler.c
+++ b/src/profiler.c
@@ -232,9 +232,10 @@ static EMACS_INT current_sampling_interval;
 
 /* Signal handler for sampling profiler.  */
 
-/* timer_getoverrun is not implemented on Cygwin, but the following
-   seems to be good enough for profiling. */
-#ifdef CYGWIN
+/* timer_getoverrun is not implemented on Cygwin prior to
+   cygwin-3.0.0, but the following seems to be good enough for
+   profiling. */
+#if defined CYGWIN && !defined HAVE_TIMER_GETOVERRUN
 #define timer_getoverrun(x) 0
 #endif
 
-- 
2.17.0


             reply	other threads:[~2019-02-18 15:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18 15:16 Ken Brown [this message]
2019-02-18 16:21 ` bug#34527: 27.0.50; Cygwin now has timer_getoverrun Eli Zaretskii
2019-02-18 17:14   ` Ken Brown
2019-02-22 14:22     ` Ken Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7b6ea74-296f-3464-9cb0-69d27f66ea84@cornell.edu \
    --to=kbrown@cornell.edu \
    --cc=34527@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.