From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.bugs Subject: bug#63103: 30.0.50; nconc compiler optimization breaks user packages Date: Thu, 27 Apr 2023 14:55:00 +0200 Message-ID: References: <877cty45rx.fsf@gmail.com> <871qk5516v.fsf@posteo.net> <9DCB2C69-7C1E-48A0-8AE2-BD8B1C0E3A80@acm.org> <679f4102-4e3f-656f-18d9-4a3cc68ce595@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22645"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , Stefan Monnier , 63103-done@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 27 14:56:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ps1AU-0005fY-Bh for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Apr 2023 14:56:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ps1AL-0003w0-RG; Thu, 27 Apr 2023 08:56:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ps1AI-0003tj-Vb for bug-gnu-emacs@gnu.org; Thu, 27 Apr 2023 08:56:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ps1AI-0004ZT-4a for bug-gnu-emacs@gnu.org; Thu, 27 Apr 2023 08:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ps1AI-0008B7-13 for bug-gnu-emacs@gnu.org; Thu, 27 Apr 2023 08:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Apr 2023 12:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63103 X-GNU-PR-Package: emacs Original-Received: via spool by 63103-done@debbugs.gnu.org id=D63103.168260011331158 (code D ref 63103); Thu, 27 Apr 2023 12:56:01 +0000 Original-Received: (at 63103-done) by debbugs.gnu.org; 27 Apr 2023 12:55:13 +0000 Original-Received: from localhost ([127.0.0.1]:57726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps19V-00086Q-6V for submit@debbugs.gnu.org; Thu, 27 Apr 2023 08:55:13 -0400 Original-Received: from server.qxqx.de ([178.63.65.180]:40305 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps19T-00085I-4J for 63103-done@debbugs.gnu.org; Thu, 27 Apr 2023 08:55:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FuvncDiBYchlayF349oxaxP3064CPz4jZ4baDS5Oa1Y=; b=seMjLyHDAFjkLKIEgC3k88PHON eOekQ1ILaHKXG2zLK9RTWgIIx8TSHyMTMBK1DO8cDS6Se3T0iuIIdTk1XFfzm9bA7Stfcrv0OoDEb acm7eO4Bs2SNnamqiDfefbTWk7+piqG8SH5gpd4oRhVBjygY1KVh9k9+Z7TnPMuy830g=; Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260720 Archived-At: On 4/27/23 14:28, Mattias Engdegård wrote: > 27 apr. 2023 kl. 12.42 skrev Daniel Mendler : > >> I think it is >> kind of nice that `nconc' can be used as a tool to turn a proper list >> into an improper list and vice versa. > > It's a bit obscure, though -- Probably. I am not sure if I came up with this pattern independently. It is likely that I've seen it in some other packages. So it is good that this is fixed. > (setcdr (last X) nil) > > is a lot clearer than > > (nconc X nil) > > and when the latter is preferred for performance, a comment might be polite to the reader. The problem is that `setcdr' of `last' is not correct for the empty list. The two lines are not equivalent. > Anyway, a fix has been pushed to master, and the manual entry for `nconc` got an extra example. Thanks. Daniel