From: "Sebastián Monía" <sebastian@sebasmonia.com>
To: "Adam Porter" <adam@alphapapa.net>
Cc: "Eli Zaretskii" <eliz@gnu.org>,
jporterbugs@gmail.com, emacs-devel@gnu.org
Subject: Re: [PATCH] EWW - use revert--buffer-function to reload, and allow reload in eww-list-buffer
Date: Sat, 19 Oct 2024 16:51:51 -0400 [thread overview]
Message-ID: <a7570486-e723-4696-b38e-cff996764251@app.fastmail.com> (raw)
In-Reply-To: <thqnh69apzgp.fsf@sebasmonia.com>
I just realized that I sent this only to Adam instead of the
mailing list.
My assignment did come through, and I still think there's value
in merging the current patch (without auto-reverting).
On Thu, Oct 17, 2024, at 10:37 AM, Sebastián Monía wrote:
> Adam Porter <adam@alphapapa.net> writes:
>
> > On 10/14/24 21:59, Sebastián Monía wrote:
> >> I was looking into it, we "just" need a good 'buffer-stale-function'.
> >> All I could think of was to store the list used to populate the vtable
> >> in a buffer-local variable, and check if the list has changed?
> >
> > AFAIK it's generally good to avoid adding more buffer-local variables,
> > as their presence has a performance penalty in general.
>
> Noted!
>
> > Updating a buffer list buffer automatically could be done by hooking
> > into the machinery that renders a single EWW buffer and having it
> > update a buffer list buffer if one exists. But I guess that wouldn't
> > work exactly like `auto-revert-mode` and `buffer-stale-function`.
>
> That same machinery could trigger auto-revert by marking the "buffer list"
> buffer stale.
>
> > I don't mean to say what you should do; just throwing out some ideas. :)
>
> And it is much appreciated! :)
>
> I don't think we should hold on merging this for auto-reverting though.
> The patch is big enough as it is.
> IMHO.
>
>
> PS: still can't merge as my assignment didn't come through.
>
> --
> Sebastián Monía
> https://site.sebasmonia.com/
next prev parent reply other threads:[~2024-10-19 20:51 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 17:28 [PATCH] EWW - use revert--buffer-function to reload, and allow reload in eww-list-buffer Sebastián Monía
2024-08-16 17:48 ` Eli Zaretskii
2024-08-16 18:55 ` Sebastián Monía
2024-08-17 12:35 ` Sebastián Monía
2024-08-24 8:42 ` Eli Zaretskii
2024-08-24 17:27 ` Jim Porter
2024-08-30 20:01 ` Sebastián Monía
2024-09-14 7:32 ` Eli Zaretskii
[not found] ` <thqnjzf7s74l.fsf@sebasmonia.com>
2024-09-20 6:18 ` Eli Zaretskii
2024-09-20 15:06 ` Sebastián Monía
2024-09-20 17:43 ` Jim Porter
2024-09-21 2:14 ` Sebastián Monía
2024-10-02 12:53 ` Sebastián Monía
2024-10-03 0:20 ` Adam Porter
2024-10-03 3:17 ` Sebastián Monía
2024-10-03 4:05 ` Jim Porter
2024-10-03 12:47 ` Sebastián Monía
2024-10-03 23:41 ` Adam Porter
2024-10-11 22:14 ` Sebastián Monía
2024-10-12 8:05 ` Eli Zaretskii
2024-10-12 18:56 ` Jim Porter
2024-10-14 1:06 ` Sebastián Monía
2024-10-14 2:39 ` Adam Porter
2024-10-14 4:06 ` Sebastián Monía
2024-10-15 0:08 ` Adam Porter
2024-10-15 2:39 ` Sebastián Monía
2024-10-15 4:04 ` Adam Porter
2024-10-14 4:05 ` Jim Porter
2024-10-15 2:59 ` Sebastián Monía
2024-10-15 4:01 ` Adam Porter
[not found] ` <thqnh69apzgp.fsf@sebasmonia.com>
2024-10-19 20:51 ` Sebastián Monía [this message]
2024-10-20 17:50 ` Jim Porter
2024-10-21 1:57 ` Sebastián Monía
2024-10-03 21:58 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7570486-e723-4696-b38e-cff996764251@app.fastmail.com \
--to=sebastian@sebasmonia.com \
--cc=adam@alphapapa.net \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.