From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>, Pip Cet <pipcet@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Changes in GC and in pure space (was: [Emacs-diffs] master 5d4dd55: Fix lifetime error in previous patch)
Date: Mon, 22 Jul 2019 10:47:27 -0700 [thread overview]
Message-ID: <a7527cfd-f5d3-a4cd-ee11-8b9e6f90ba42@cs.ucla.edu> (raw)
In-Reply-To: <83blxmqfkq.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]
Eli Zaretskii wrote:
> After all, these two issues are not
> terribly urgent to fix (unlike, say, the unexec thingy).
As it happens, the issue with hash tables is bound up with the unexec thingy, in
that portable dumping currently can screw up hash tables with user-defined
tests. I discovered this over the weekend while looking into Pip Cet's proposed
changes to how portable dumping treats hash tables, and have a contrived test
case (see attached) that causes gethash to fail with "Lisp nesting exceeds
‘max-lisp-eval-depth’" in an Emacs started via a portable dump, even though the
same gethash works fine before dumping. I plan to install a workaround for this
soon. So all in all I think the hash-table changes should improve Emacs
stability even if we were planning to split off a new release branch next week,
much less September.
I take your point that getting rid of pure space might be a bridge too far now -
unless someone can show that pure space also runs afoul of portable dumping.
[-- Attachment #2: trouble.sh --]
[-- Type: application/x-shellscript, Size: 663 bytes --]
next prev parent reply other threads:[~2019-07-22 17:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190721193221.1964.53182@vcs0.savannah.gnu.org>
[not found] ` <20190721193222.8C19E20BE2@vcs0.savannah.gnu.org>
2019-07-22 4:12 ` [Emacs-diffs] master 5d4dd55: Fix lifetime error in previous patch Pip Cet
2019-07-22 13:40 ` Stefan Monnier
2019-07-23 1:06 ` Paul Eggert
2019-07-22 15:00 ` Changes in GC and in pure space (was: [Emacs-diffs] master 5d4dd55: Fix lifetime error in previous patch) Eli Zaretskii
2019-07-22 17:47 ` Paul Eggert [this message]
2019-07-22 18:19 ` Changes in GC and in pure space Eli Zaretskii
2019-07-22 19:58 ` Stefan Monnier
2019-07-23 1:43 ` Paul Eggert
2019-07-23 14:46 ` Eli Zaretskii
2019-07-23 16:27 ` Paul Eggert
2019-07-23 16:58 ` Eli Zaretskii
2019-07-23 2:25 ` Eli Zaretskii
2019-07-23 1:29 ` bug#36769: portable dumper mishandles user-defined hashtabs Paul Eggert
2019-07-23 2:06 ` Paul Eggert
2019-07-22 19:05 ` Changes in GC and in pure space (was: [Emacs-diffs] master 5d4dd55: Fix lifetime error in previous patch) Pip Cet
2019-07-23 14:56 ` Eli Zaretskii
2019-07-23 15:33 ` Changes in GC and in pure space Stefan Monnier
2019-07-24 3:06 ` Richard Stallman
2019-08-15 9:34 ` Changes in GC and in pure space (was: [Emacs-diffs] master 5d4dd55: Fix lifetime error in previous patch) Paul Eggert
2019-08-16 13:34 ` Pip Cet
2019-08-22 0:25 ` Paul Eggert
2019-08-22 2:06 ` Paul Eggert
2019-08-22 5:36 ` Paul Eggert
2019-09-04 6:05 ` Paul Eggert
2019-09-04 14:51 ` Eli Zaretskii
2019-09-04 16:56 ` Paul Eggert
2019-09-04 17:36 ` Daniel Colascione
2019-09-04 17:45 ` Changes in GC and in pure space Stefan Monnier
2019-09-04 18:34 ` Óscar Fuentes
2019-09-04 19:15 ` Paul Eggert
2019-09-05 7:04 ` Paul Eggert
2019-07-24 2:58 ` Changes in GC and in pure space (was: [Emacs-diffs] master 5d4dd55: Fix lifetime error in previous patch) Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7527cfd-f5d3-a4cd-ee11-8b9e6f90ba42@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.