all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, Drew Adams <drew.adams@oracle.com>
Cc: 21448@debbugs.gnu.org
Subject: bug#21448: 25.0.50; `unicode-property-table-internal' in Elisp manual
Date: Thu, 10 Sep 2015 08:27:46 -0700 (PDT)	[thread overview]
Message-ID: <a7354d8a-de19-45f5-843c-792465d2a123@default> (raw)
In-Reply-To: <<83fv2n573m.fsf@gnu.org>>

> OK, then please provide more details about what information should be
> added to explain the example.  I think the code is straightforward, it
> just loops over a char-table, which is clear from the code.  What is
> missing?
> 
> I really need that help, if you want any changes.  Just repeating that
> the example is not clear enough doesn't cut it.

Thank you for looking into this.  Let me start by saying that the
first part of the node, which explains categories, is very clear
and well put.

I think that all that is missing wrt explaining the example is to
say (in this node) what `uniprop-table' is here, and why and how
it is used.

A minor help might be to rename variable `uniprop-table' to, say,
`bidi-class-table' or `bidi-table'.  I don't know enough about bidi
or `unicode-property-table-internal' to really know what this
char-table is: what its char entries are mapped to.  Something to
do with character property `bidi-class' (a property I am  not
familiar with).  Maybe it means that a char entry is mapped by the
table to all of the chars in its bidi class?

These bidi things are clear to you, but not necessarily to a
reader of this node.  A few words about this might help.

If the use of `bidi-class-table' is clarified (explained a bit)
then I think the example becomes clear.  You iterate over
`bidi-class-table', and for any char that the table maps to R, AL,
or RLO, you modify that same char's entry in the new `category-table',
so that the char gets mapped in `category-table' to the character
?R (which represents its category) .

It might also help if function `modify-category-entry' were
presented before this example, but that's not critical.

HTH.  Feel free to close the bug if you disagree about adding
some explanation here.  (Well, it's already closed, I guess.)





  parent reply	other threads:[~2015-09-10 15:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<bb3f44a8-1141-4e3c-8694-26fe89e134e5@default>
     [not found] ` <<83io7j5rye.fsf@gnu.org>
2015-09-09 20:07   ` bug#21448: 25.0.50; `unicode-property-table-internal' in Elisp manual Drew Adams
2015-09-10  2:41     ` Eli Zaretskii
     [not found]   ` <<029d2a95-ca25-48be-bf19-2159ed753d81@default>
     [not found]     ` <<83fv2n573m.fsf@gnu.org>
2015-09-10 15:27       ` Drew Adams [this message]
2015-09-10 15:30         ` Drew Adams
2015-09-10 17:12         ` Eli Zaretskii
     [not found]       ` <<a7354d8a-de19-45f5-843c-792465d2a123@default>
     [not found]         ` <<831te65hcc.fsf@gnu.org>
2015-09-10 17:23           ` Drew Adams
2015-09-10 17:40             ` Eli Zaretskii
2015-09-09 14:57 Drew Adams
2015-09-09 19:10 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7354d8a-de19-45f5-843c-792465d2a123@default \
    --to=drew.adams@oracle.com \
    --cc=21448@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.