Re: "Final" version of tty child frames

[martin rudalics <rudalics@gmx.at>]

[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]

 > I've not yet understood where the third frame is created. Probably have to
 > see this in the debugger to get into this again.

Without really checking it must be here

       /* Use default-minibuffer-frame if possible.  */
       if (!FRAMEP (KVAR (kb, Vdefault_minibuffer_frame))
	  || ! FRAME_LIVE_P (XFRAME (KVAR (kb, Vdefault_minibuffer_frame))))
	{
	  Lisp_Object initial_frame;

	  /* If there's no minibuffer frame to use, create one.  */
	  initial_frame = call1 (Qmake_initial_minibuffer_frame,
				 display);
	  kset_default_minibuffer_frame (kb, initial_frame);
	}

'default-minibuffer-frame' on ttys is nil, only 'x-create-frame' and the
like set it AFAICT.  Even if it were some frame, it might be of no use:
On a tty the mini window to use _must_ be on the visible frame.  So
Emacs makes a new initial_frame and uses that frame's mini window.  But
the child frame gets another root frame and sooner or later this will
crash anyway.  The attached patch fixes it here.

martin (who can still post a bug report if you think it's needed)

[-- Attachment #2: tty-child-frame.diff --]
[-- Type: text/x-patch, Size: 927 bytes --]

diff --git a/src/frame.c b/src/frame.c
index 7c07100e944..94e466b14c6 100644
--- a/src/frame.c
+++ b/src/frame.c
@@ -1297,12 +1297,22 @@ make_terminal_frame (struct terminal *terminal, Lisp_Object parent,
 
       f = NULL;
       Lisp_Object mini = Fassq (Qminibuffer, params);
+
       if (CONSP (mini))
 	{
 	  mini = Fcdr (mini);
 	  struct kboard *kb = FRAME_KBOARD (XFRAME (parent));
+
 	  if (EQ (mini, Qnone) || NILP (mini))
-	    f = make_frame_without_minibuffer (Qnil, kb, Qnil);
+	    {
+	      /* A terminal root frame must have a minibuffer window.  */
+	      Lisp_Object mini_window
+		= root_frame (XFRAME (parent))->minibuffer_window;
+
+	      f = make_frame (false);
+	      fset_minibuffer_window (f, mini_window);
+	      store_frame_param (f, Qminibuffer, mini_window);
+	    }
 	  else if (EQ (mini, Qonly))
 	    error ("minibuffer-only child frames are not implemented");
 	  else if (WINDOWP (mini))