all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: "Óscar Fuentes" <ofv@wanadoo.es>,
	"Miguel Guedes" <miguel.a.guedes@gmail.com>
Cc: help-gnu-emacs@gnu.org
Subject: RE: completing-read does not accept spaces (was: Command timeclock-out)
Date: Thu, 16 Jan 2014 10:13:56 -0800 (PST)	[thread overview]
Message-ID: <a6cf7fbc-dfb6-4824-b623-1bd582d40701@default> (raw)
In-Reply-To: <8761pj3lek.fsf@wanadoo.es>

> > I've just noticed that when executing `timeclock-out' and inputting a
> > reason it does not accept spaces.  This command makes use of the
> > function `completing-read'.
> >
> > Is not accepting spaces when entering a reason for clocking out the
> > intended behaviour?
> 
> Reading the docstring of completing-read I see no reason why it should
> not accept spaces. So either the docstring is at fault or there is a bug
> on completing-read. 

No.  The doc to read is (elisp) `Completion Commands', in particular,
about the variables named `minibuffer-local-*-map'.

> Curiously, the function will complete the user's input to a string
> containing spaces if there is one on the collection of candidates:
> (completing-read "say: " (list "hello there"))

Irrelevant here.  As the doc I mentioned says, `SPC' is bound to
`minibuffer-complete-word', and that is what you are seeing.  `SPC' is
not bound to `self-insert-command' here - it is not inserting itself.
It is just completing a "word" at a time.

> Please submit a bug report (M-x report-emacs-bug) against completing-read.

No.  There is no bug here.  This is the behavior by design, like
it or not.

Do I personally think that `SPC' should generally be self-inserting
during completion?  You bet I do.  And so should `?'.  And so should
`C-j' (newline).  (And this is the case in Icicle mode, for instance.)

But that is not the opinion of Emacs Dev.  It took decades to finally
get `SPC' to be self-inserting for file-name completion (see variable
`minibuffer-local-filename-completion-map', in the same Elisp manual
node).  Patience. ;-)



  reply	other threads:[~2014-01-16 18:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16 15:14 Command timeclock-out Miguel Guedes
2014-01-16 17:07 ` completing-read does not accept spaces (was: Command timeclock-out) Óscar Fuentes
2014-01-16 18:13   ` Drew Adams [this message]
2014-01-16 18:36     ` completing-read does not accept spaces Óscar Fuentes
2014-01-16 18:50       ` Drew Adams
2014-01-16 19:01     ` Stefan Monnier
2014-01-23 12:29     ` Miguel Guedes
2014-01-23 14:20       ` Óscar Fuentes
2014-01-23 17:20       ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6cf7fbc-dfb6-4824-b623-1bd582d40701@default \
    --to=drew.adams@oracle.com \
    --cc=help-gnu-emacs@gnu.org \
    --cc=miguel.a.guedes@gmail.com \
    --cc=ofv@wanadoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.