From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: luangruo@yahoo.com, 71477@debbugs.gnu.org
Subject: bug#71477: 30.0.50; Lock files are not deleted on Windows 98
Date: Wed, 12 Jun 2024 10:57:10 -0700 [thread overview]
Message-ID: <a67b0d09-1699-4f93-aa2a-ae8b269c9c24@cs.ucla.edu> (raw)
In-Reply-To: <86sexiytlx.fsf@gnu.org>
On 2024-06-12 10:10, Eli Zaretskii wrote:
> But on all platforms except Windows 9X we shouldn't see a negative PID
> here, so what you say is purely theoretical, no?
No, because that value doesn't come from a pid_t that the system gave us
as a process ID. It comes from the file system, and so could be invalid
as a process ID. That's why the code already checks that pid <=
TYPE_MAXIMUM (pid_t). Such a check wouldn't be needed if the pid were a
valid process ID.
>> Even on MS Windows 98 we should check that TYPE_MINIMUM (pid_t) <= pid.
>
> Since pid_t is typedefed as 'int', that's always true, no?
No, because the code is checking 'pid', which is of type intmax_t not
pid_t. (And anyway pid_t need not be 'int'.)
> No. And our emulation of 'kill' fails with EPERM when called witgh
> both arguments zero.
In that case there's no need to worry about pid == 0 here.
> Fine with me, please install and I will followup.
OK, installed.
next prev parent reply other threads:[~2024-06-12 17:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87r0d4bzut.fsf.ref@yahoo.com>
2024-06-10 15:07 ` bug#71477: 30.0.50; Lock files are not deleted on Windows 98 Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-10 17:44 ` Eli Zaretskii
[not found] ` <87ikygb6hp.fsf@yahoo.com>
2024-06-11 6:47 ` Eli Zaretskii
[not found] ` <87bk47c4cd.fsf@yahoo.com>
2024-06-11 7:56 ` Eli Zaretskii
[not found] ` <871q53c2ur.fsf@yahoo.com>
2024-06-11 8:28 ` Eli Zaretskii
[not found] ` <87jzivamzp.fsf@yahoo.com>
2024-06-11 13:03 ` Eli Zaretskii
2024-06-11 13:34 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-12 8:25 ` Eli Zaretskii
2024-06-12 16:07 ` Paul Eggert
2024-06-12 17:10 ` Eli Zaretskii
2024-06-12 17:57 ` Paul Eggert [this message]
2024-06-13 8:06 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a67b0d09-1699-4f93-aa2a-ae8b269c9c24@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=71477@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.