all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 18163-done@debbugs.gnu.org
Subject: bug#18163: 24.4.50; REGRESSION, font-lock in `emacs-lisp-mode': spurious `font-lock-warning-face'
Date: Wed, 6 Aug 2014 11:04:39 -0700 (PDT)	[thread overview]
Message-ID: <a6556506-9a10-4c11-92ce-70e9300f2a65@default> (raw)
In-Reply-To: <jwv38d9mth2.fsf-monnier+emacsbugs@gnu.org>

> It's no error.  There's even a help-text explaining why it's highlighted
> this way (if you hover your mouse above the highlighted text).

I see.  Yes, I can see that that can be helpful.

It's unfortunate that the same face is used for this kind of warning
and for things like `error' and `user-error', which are not something
to be warned about.  It is handy to highlight those too (specially),
but they should not use a "warning" face, if that face is really
starting to be used to warn.

IOW using `font-lock-warning-face' to warn uncovers an (effectively
new) bug: its use for non-warnings is inappropriate.  It could
arguably have been considered appropriate (though poorly named) as
long as none of the uses involved warning.  There is no longer any
such justification.





  reply	other threads:[~2014-08-06 18:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01  4:23 bug#18163: 24.4.50; REGRESSION, font-lock in `emacs-lisp-mode': spurious `font-lock-warning-face' Drew Adams
2014-08-06 17:15 ` Stefan Monnier
2014-08-06 18:04   ` Drew Adams [this message]
2014-08-07  3:47   ` Leo Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6556506-9a10-4c11-92ce-70e9300f2a65@default \
    --to=drew.adams@oracle.com \
    --cc=18163-done@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.