From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Emacs 26 MacOS bugs Date: Tue, 6 Feb 2018 15:28:19 -0800 Organization: UCLA Computer Science Department Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------2A5A2FC709C36852D373FB42" X-Trace: blaine.gmane.org 1517959656 24916 195.159.176.226 (6 Feb 2018 23:27:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 6 Feb 2018 23:27:36 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 Cc: Emacs developers To: Noam Postavsky , Richard Stallman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 07 00:27:31 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ejCdq-0004ng-N9 for ged-emacs-devel@m.gmane.org; Wed, 07 Feb 2018 00:27:10 +0100 Original-Received: from localhost ([::1]:49413 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejCfq-0002c3-1x for ged-emacs-devel@m.gmane.org; Tue, 06 Feb 2018 18:29:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejCf5-0002a6-1a for emacs-devel@gnu.org; Tue, 06 Feb 2018 18:28:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejCf1-0004co-9Z for emacs-devel@gnu.org; Tue, 06 Feb 2018 18:28:26 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:47508) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ejCf1-0004cC-00; Tue, 06 Feb 2018 18:28:23 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D52FA1615B4; Tue, 6 Feb 2018 15:28:20 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id MzfJX4ooDJea; Tue, 6 Feb 2018 15:28:20 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EF3871615D3; Tue, 6 Feb 2018 15:28:19 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id m7aoQx75pN3Z; Tue, 6 Feb 2018 15:28:19 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9F9621615B4; Tue, 6 Feb 2018 15:28:19 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222601 Archived-At: This is a multi-part message in MIME format. --------------2A5A2FC709C36852D373FB42 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 02/06/2018 09:30 AM, Noam Postavsky wrote: > on w32 I get an assertion failure, patch attached. On Fedora 27 x86-64 I get a crash when running 'emacs --no-build-details'. There are several places in the Emacs code that crash when Fsystem_name returns a non-string. Proposed patch attached. --------------2A5A2FC709C36852D373FB42 Content-Type: text/plain; charset=UTF-8; name="0001-Fix-crashes-when-run-with-no-build-details.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Fix-crashes-when-run-with-no-build-details.txt" RnJvbSBjNzYwMmI0ZTllMDc0ZWI4ZDBmZDcwMWQwOTRmMWMyNDQ3MTNhNzBmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUdWUsIDYgRmViIDIwMTggMTU6MjU6NDUgLTA4MDAKU3ViamVjdDogW1BBVENI XSBGaXggY3Jhc2hlcyB3aGVuIHJ1biB3aXRoIC0tbm8tYnVpbGQtZGV0YWlscwpNSU1FLVZl cnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRGLTgKQ29u dGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKKiBzcmMveHJkYi5jIChnZXRfZW52aXJv bl9kYik6Ciogc3JjL3h0ZXJtLmMgKHNhbWVfeF9zZXJ2ZXIsIHhfdGVybV9pbml0KToKRG9u 4oCZdCBhc3N1bWUgRnN5c3RlbV9uYW1lIHJldHVybnMgYSBzdHJpbmcuCi0tLQogc3JjL3hy ZGIuYyAgfCAxOSArKysrKysrKysrKy0tLS0tLS0tCiBzcmMveHRlcm0uYyB8IDE2ICsrKysr KysrKysrLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgMTMgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL3hyZGIuYyBiL3NyYy94cmRiLmMKaW5kZXgg YjU1YzBmOTAxMS4uODM2YzE0Nzk0NyAxMDA2NDQKLS0tIGEvc3JjL3hyZGIuYworKysgYi9z cmMveHJkYi5jCkBAIC0zNzYsMTUgKzM3NiwxOCBAQCBnZXRfZW52aXJvbl9kYiAodm9pZCkK IAogICBpZiAoIXApCiAgICAgewotICAgICAgLyogVXNlIH4vLlhkZWZhdWx0cy1IT1NUTkFN RS4gICovCi0gICAgICBjaGFyICpob21lID0gZ2V0aG9tZWRpciAoKTsKLSAgICAgIHB0cmRp ZmZfdCBob21lbGVuID0gc3RybGVuIChob21lKTsKICAgICAgIExpc3BfT2JqZWN0IHN5c3Rl bV9uYW1lID0gRnN5c3RlbV9uYW1lICgpOwotICAgICAgcHRyZGlmZl90IGZpbGVuYW1lc2l6 ZSA9IChob21lbGVuICsgc2l6ZW9mIHhkZWZhdWx0cwotCQkJCSsgMSArIFNCWVRFUyAoc3lz dGVtX25hbWUpKTsKLSAgICAgIHAgPSBmaWxlbmFtZSA9IHhyZWFsbG9jIChob21lLCBmaWxl bmFtZXNpemUpOwotICAgICAgbGlzcHN0cGNweSAoc3RwY3B5IChzdHBjcHkgKGZpbGVuYW1l ICsgaG9tZWxlbiwgeGRlZmF1bHRzKSwgIi0iKSwKLQkJICBzeXN0ZW1fbmFtZSk7CisgICAg ICBpZiAoU1RSSU5HUCAoc3lzdGVtX25hbWUpKQorCXsKKwkgIC8qIFVzZSB+Ly5YZGVmYXVs dHMtSE9TVE5BTUUuICAqLworCSAgY2hhciAqaG9tZSA9IGdldGhvbWVkaXIgKCk7CisJICBw dHJkaWZmX3QgaG9tZWxlbiA9IHN0cmxlbiAoaG9tZSk7CisJICBwdHJkaWZmX3QgZmlsZW5h bWVzaXplID0gKGhvbWVsZW4gKyBzaXplb2YgeGRlZmF1bHRzCisJCQkJICAgICsgMSArIFNC WVRFUyAoc3lzdGVtX25hbWUpKTsKKwkgIHAgPSBmaWxlbmFtZSA9IHhyZWFsbG9jIChob21l LCBmaWxlbmFtZXNpemUpOworCSAgbGlzcHN0cGNweSAoc3RwY3B5IChzdHBjcHkgKGZpbGVu YW1lICsgaG9tZWxlbiwgeGRlZmF1bHRzKSwgIi0iKSwKKwkJICAgICAgc3lzdGVtX25hbWUp OworCX0KICAgICB9CiAKICAgZGIgPSBYcm1HZXRGaWxlRGF0YWJhc2UgKHApOwpkaWZmIC0t Z2l0IGEvc3JjL3h0ZXJtLmMgYi9zcmMveHRlcm0uYwppbmRleCAzNjRhOGE4ZGIwLi5iMTA2 NjRkZGE5IDEwMDY0NAotLS0gYS9zcmMveHRlcm0uYworKysgYi9zcmMveHRlcm0uYwpAQCAt MTIxNTAsNiArMTIxNTAsOCBAQCBzYW1lX3hfc2VydmVyIChjb25zdCBjaGFyICpuYW1lMSwg Y29uc3QgY2hhciAqbmFtZTIpCiB7CiAgIGJvb2wgc2Vlbl9jb2xvbiA9IGZhbHNlOwogICBM aXNwX09iamVjdCBzeXNuYW1lID0gRnN5c3RlbV9uYW1lICgpOworICBpZiAoISBTVFJJTkdQ IChzeXNuYW1lKSkKKyAgICBzeXNuYW1lID0gZW1wdHlfdW5pYnl0ZV9zdHJpbmc7CiAgIGNv bnN0IGNoYXIgKnN5c3RlbV9uYW1lID0gU1NEQVRBIChzeXNuYW1lKTsKICAgcHRyZGlmZl90 IHN5c3RlbV9uYW1lX2xlbmd0aCA9IFNCWVRFUyAoc3lzbmFtZSk7CiAgIHB0cmRpZmZfdCBs ZW5ndGhfdW50aWxfcGVyaW9kID0gMDsKQEAgLTEyNTcyLDE1ICsxMjU3NCwxOSBAQCB4X3Rl cm1faW5pdCAoTGlzcF9PYmplY3QgZGlzcGxheV9uYW1lLCBjaGFyICp4cm1fb3B0aW9uLCBj aGFyICpyZXNvdXJjZV9uYW1lKQogI2VuZGlmCiAKICAgTGlzcF9PYmplY3Qgc3lzdGVtX25h bWUgPSBGc3lzdGVtX25hbWUgKCk7Ci0gIHB0cmRpZmZfdCBuYnl0ZXM7Ci0gIGlmIChJTlRf QUREX1dSQVBWIChTQllURVMgKFZpbnZvY2F0aW9uX25hbWUpLCBTQllURVMgKHN5c3RlbV9u YW1lKSArIDIsCi0JCSAgICAgJm5ieXRlcykpCisKKyAgcHRyZGlmZl90IG5ieXRlcyA9IFNC WVRFUyAoVmludm9jYXRpb25fbmFtZSkgKyAxOworICBpZiAoU1RSSU5HUCAoc3lzdGVtX25h bWUpCisgICAgICAmJiBJTlRfQUREX1dSQVBWIChuYnl0ZXMsIFNCWVRFUyAoc3lzdGVtX25h bWUpICsgMSwgJm5ieXRlcykpCiAgICAgbWVtb3J5X2Z1bGwgKFNJWkVfTUFYKTsKICAgZHB5 aW5mby0+eF9pZCA9ICsreF9kaXNwbGF5X2lkOwogICBkcHlpbmZvLT54X2lkX25hbWUgPSB4 bWFsbG9jIChuYnl0ZXMpOwogICBjaGFyICpuYW1ldGFpbCA9IGxpc3BzdHBjcHkgKGRweWlu Zm8tPnhfaWRfbmFtZSwgVmludm9jYXRpb25fbmFtZSk7Ci0gICpuYW1ldGFpbCsrID0gJ0An OwotICBsaXNwc3RwY3B5IChuYW1ldGFpbCwgc3lzdGVtX25hbWUpOworICBpZiAoU1RSSU5H UCAoc3lzdGVtX25hbWUpKQorICAgIHsKKyAgICAgICpuYW1ldGFpbCsrID0gJ0AnOworICAg ICAgbGlzcHN0cGNweSAobmFtZXRhaWwsIHN5c3RlbV9uYW1lKTsKKyAgICB9CiAKICAgLyog RmlndXJlIG91dCB3aGljaCBtb2RpZmllciBiaXRzIG1lYW4gd2hhdC4gICovCiAgIHhfZmlu ZF9tb2RpZmllcl9tZWFuaW5ncyAoZHB5aW5mbyk7Ci0tIAoyLjE0LjMKCg== --------------2A5A2FC709C36852D373FB42--