all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Consistency for xref-show-{xrefs,definitions}-function
@ 2021-01-14 20:27 Gabriel do Nascimento Ribeiro
  2021-01-14 21:04 ` Daniel Martín
  2021-01-15 17:20 ` Dmitry Gutov
  0 siblings, 2 replies; 7+ messages in thread
From: Gabriel do Nascimento Ribeiro @ 2021-01-14 20:27 UTC (permalink / raw)
  To: emacs-devel

I noticed that the options 'xref-show-xrefs-function' and
'xref-show-definitions-function' are not symmetrical.

The defcustom for 'xref-show-xrefs-function' does not have type choices
as 'xref-show-definitions-function' has. Furthermore, it's quite strange
to configure it as follow:

(setq xref-show-xrefs-function
      'xref-show-definitions-completing-read)

I suggest to create similar functions for 'xref-show-xrefs-function',
which at this moment can be just aliases but can be independent
functions in the future, if necessary:
  - xref-show-xrefs-buffer
  - xref-show-xrefs-buffer-at-bottom
  - xref-show-xrefs-completing-read

Also, the docstrings of both options could be improved a little bit to
give more information about the default choices.

I can submit a patch if these suggestions are accepted.

Regards,
Gabriel



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-01-18  1:28 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-14 20:27 Consistency for xref-show-{xrefs,definitions}-function Gabriel do Nascimento Ribeiro
2021-01-14 21:04 ` Daniel Martín
2021-01-15 17:20 ` Dmitry Gutov
2021-01-16 18:35   ` Gabriel do Nascimento Ribeiro
2021-01-16 19:24     ` Dmitry Gutov
2021-01-16 20:31       ` Gabriel do Nascimento Ribeiro
2021-01-18  1:28         ` Dmitry Gutov

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.