all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tim Johnson <tim@akwebsoft.com>
To: MLEmacs <Help-gnu-emacs@gnu.org>
Subject: Adding an `or condition without changing code
Date: Sun, 12 Jan 2020 14:29:34 -0900	[thread overview]
Message-ID: <a51aef7f-2d1a-ad1b-76ed-0f3b3146bd49@akwebsoft.com> (raw)

Using emacs 26.1 on ubuntu

I'm implementing dired-single-buffer

The function of the same name has the following `let initialization

(let ((name (or default-dirname (dired-get-filename nil t)))) ;; 
default-dirname is an optional argument to dired-single-buffer

The two conditions to `or are not sufficient if I call 
dired-single-buffer from an unvisited buffer. The result is that `name 
is nil and a string-p, nil error is thrown.

A simple hack is to add a third condition to `or

(let ((name (or default-dirname (dired-get-filename nil t) "~/")))  ;; 
fall-back to /home/user

But, it IS a hack and means I have altered some good citizen's code.

How can that be resolved? Might the solution be a customization of dired?

 From the documentation of dired-get-filename I don't grok a solution....

thanks

-- 

Tim
tj49.com




             reply	other threads:[~2020-01-12 23:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-12 23:29 Tim Johnson [this message]
2020-01-13 14:37 ` Adding an `or condition without changing code Stefan Monnier
2020-01-13 18:55   ` Tim Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a51aef7f-2d1a-ad1b-76ed-0f3b3146bd49@akwebsoft.com \
    --to=tim@akwebsoft.com \
    --cc=Help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.