From: Gregory Heytings <gregory@heytings.org>
To: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
Cc: 48153@debbugs.gnu.org
Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer
Date: Mon, 03 May 2021 15:15:25 +0000 [thread overview]
Message-ID: <a4dfe72ae24d6edc772a@heytings.org> (raw)
In-Reply-To: <m1sg35lizr.fsf@mg559.lan>
>
> After typing C-x b or C-x C-f, the minor mode maps from the buffer that
> launched the minibuffer will override the keymap given to
> `read-from-minibuffer`, this seems to be a regression in emacs 28
> master.
>
> Reproduction:
>
> 1. Turn on `ido-mode`
> 2. Turn on some minor mode that rebinds `C-k` with `(define-key
> some-minor-mode-map (kbd "C-k") 'some-func)`
> 3. C-x b
> 4. Select a buffer and type C-k
>
> Expectation:
>
> C-k should be bound to `ido-kill-buffer-at-head` and calls it, but
> instead `some-func` is called.
>
> Since C-k is bound in `ido-completion-map`, and it is given to
> `read-from-minibuffer`, all the bindings in `ido-completion-map` should
> take precedence.
>
Thanks for your bug report. I'm unable to reproduce your recipe on recent
versions of the trunk (today, a week ago). I tried
(define-minor-mode test-mode "" :keymap (let ((map (make-sparse-keymap))) (define-key map (kbd "C-k") '(lambda () (interactive) (message "BAD !"))) map))
and C-k is indeed bound to 'ido-kill-buffer-at-head'. I suspect this
misbehavior is due to your configuration; if not, could you try to create
a recipe starting with emacs -Q?
next prev parent reply other threads:[~2021-05-03 15:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-02 6:58 bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Jimmy Yuen Ho Wong
2021-05-03 15:15 ` Gregory Heytings [this message]
2021-05-04 12:53 ` Jimmy Yuen Ho Wong
2021-05-04 13:13 ` Gregory Heytings
2021-05-04 13:52 ` Jimmy Yuen Ho Wong
2021-05-04 14:02 ` Gregory Heytings
2021-05-04 14:29 ` Gregory Heytings
2021-05-04 16:15 ` Jimmy Yuen Ho Wong
2021-05-04 16:36 ` Gregory Heytings
2021-05-04 22:40 ` Jimmy Yuen Ho Wong
2021-05-05 8:09 ` Gregory Heytings
2021-05-05 9:10 ` Jimmy Yuen Ho Wong
2021-05-05 12:15 ` Eli Zaretskii
2021-05-05 13:12 ` Gregory Heytings
2021-05-05 13:24 ` Jimmy Yuen Ho Wong
2021-05-05 14:17 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-06 10:55 ` Jimmy Yuen Ho Wong
2021-05-09 14:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-05 13:06 ` Gregory Heytings
2021-05-05 14:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4dfe72ae24d6edc772a@heytings.org \
--to=gregory@heytings.org \
--cc=48153@debbugs.gnu.org \
--cc=wyuenho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.