From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#56013: 28.1; "gio open" and "xdg-open" fail silently under eshell Date: Fri, 17 Jun 2022 10:17:08 -0700 Message-ID: References: <87h74kes5l.fsf@gnus.org> <87czf88yre.fsf@igel.home> <87ilozbivd.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26944"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56013@debbugs.gnu.org, Jeff Kowalski To: Lars Ingebrigtsen , Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 17 19:20:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o2Fe4-0006lB-5H for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Jun 2022 19:20:32 +0200 Original-Received: from localhost ([::1]:37736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2Fe2-00022q-RF for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Jun 2022 13:20:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2Fbf-000055-2k for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2022 13:18:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52965) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2Fbe-0006wE-Hy for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2022 13:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o2Fbe-0003g5-Dm for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2022 13:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jun 2022 17:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56013 X-GNU-PR-Package: emacs Original-Received: via spool by 56013-submit@debbugs.gnu.org id=B56013.165548623714083 (code B ref 56013); Fri, 17 Jun 2022 17:18:02 +0000 Original-Received: (at 56013) by debbugs.gnu.org; 17 Jun 2022 17:17:17 +0000 Original-Received: from localhost ([127.0.0.1]:46862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2Fav-0003f5-F6 for submit@debbugs.gnu.org; Fri, 17 Jun 2022 13:17:17 -0400 Original-Received: from mail-pg1-f175.google.com ([209.85.215.175]:41507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2Far-0003eq-JM for 56013@debbugs.gnu.org; Fri, 17 Jun 2022 13:17:15 -0400 Original-Received: by mail-pg1-f175.google.com with SMTP id w29so4558755pgl.8 for <56013@debbugs.gnu.org>; Fri, 17 Jun 2022 10:17:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=oC1f9ec7Pq8DY+P6v4y3WTifOQUH597xHY/7GpifOvg=; b=hbWyWU/KISZTCFhbhFWg8x1jmTeKW3bbs+pEu28U4Bf5FdLUJfAlYcUiPPNtXA5wMy DiTiXesnnsah/fjWlmBKxxS8fNDBdUWSmx5osnaFoAjTj5cXFnjbzBej2b/zoO+9uUls JHmpCQzeWLjGsH5xg8YsWgfghngDY80D/2TypZVosV/AhJBd9LdkGDAr9xoQLlaXNHVA y8S1YUsWUiT+Pvyxyzlc5rTVhPmR0JCNcxsKaxCI+an0CW4QFfWRPO544W7kPuZXNlFQ TYYof/D5lSzR+8gU/BE/Lv3F/TD2zpWMRbTr5Y1t7TjaJ40tniBCFPgThe1qp1tdszvX 3z/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oC1f9ec7Pq8DY+P6v4y3WTifOQUH597xHY/7GpifOvg=; b=e3vXVuV/1Im+GnfV9l3q3LznAtVZ7rCEtV/lhGXJj8nm1dCBS3FFsAtHqtXuLH3qgj NREqVX0Igk0kUQlW/mumtp5ueGnDlF1u5dG+PdBMJsRFAlWYdznDM/r80/uBzlu77bDj dkEos4ZT+Ybe3kfVPIwuYiK2FLij/rSeSuDJr1Lmzj6kAT9KgjusujBWiG2jE59aUC8x OjevPxS+nwxhxzBL3CKKzGCpLU3+MolYFuv4ZI8xuMCkp77h3RuFRdlLGwVWEC1Bc6ZX u8UAQwRsNIeYEXR1vZc7IoR2dTLkTnHsPMILYZ8xDwV0/Voc0XmcB6+yjE+oNiwuPPRP uWgw== X-Gm-Message-State: AJIora81A75mnAHn3YaVV9ci3RXw3YWL9KrS6sZC2kHVGACxwY8Bt/Z2 Z9gtgqsqiQWAqyfFgnmL/iE= X-Google-Smtp-Source: AGRyM1u/5guI+F0UM3CdeofnGfWLvAXbyTl9gMgk29BAI0BNvfAzlAUKHwqSt3TEZdV1agEYdgWbPA== X-Received: by 2002:a62:2584:0:b0:520:785d:2ba with SMTP id l126-20020a622584000000b00520785d02bamr11061451pfl.55.1655486227438; Fri, 17 Jun 2022 10:17:07 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id i10-20020a170902cf0a00b001641244d051sm3809244plg.257.2022.06.17.10.17.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jun 2022 10:17:07 -0700 (PDT) In-Reply-To: <87ilozbivd.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234713 Archived-At: On 6/17/2022 4:59 AM, Lars Ingebrigtsen wrote: > Andreas Schwab writes: > >> See bug#44824. > > Ah, right. The fix proposed there was: > > org.el: Avoid xdg-open silent failure > > * lisp/org.el (org-open-file): Use 'pipe :connection-type instead of > 'pty to prevent killing of background process on handler exit. > > Perhaps Jim has some comments here; added to the CCs. Yeah, this is an issue with how `start-file-process' is being called in Eshell (see `eshell-gather-process-output'). If I call `(setq process-connection-type nil)' before running gio in Eshell, it works fine. There's *almost* an existing Eshell function that would solve this: `eshell-needs-pipe-p'. Currently, it only returns t if certain programs are being piped *to*, but we could enhance that to allow specifying that some programs need a "pipe" (i.e. for `process-connection-type' to be nil) all the time. Then we'd just need to add gio and xdg-open to `eshell-needs-pipe' (which should probably be a defcustom while we're there).