From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Tassilo Horn" Newsgroups: gmane.emacs.bugs Subject: bug#39546: 28.0.50; Do not require subr-x at run time Date: Mon, 10 Feb 2020 21:17:08 +0100 Message-ID: References: <87k14uwnjl.fsf@gmail.com> <831rr2cvci.fsf@gnu.org> <83r1z2bau6.fsf@gnu.org> <87wo8up7x2.fsf@gnu.org> <83mu9qb4d0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="86006"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.1.7-802-g7a41c81-fmstable-20200203v1 Cc: 39546@debbugs.gnu.org, larsi@gnus.org, michael.albinus@gmx.de, Tino Calancha To: "Eli Zaretskii" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 10 21:19:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j1FWS-000MIj-El for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Feb 2020 21:19:12 +0100 Original-Received: from localhost ([::1]:38334 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1FWR-0004ax-EF for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Feb 2020 15:19:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54437) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1FWJ-0004ad-2F for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 15:19:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1FWI-0004pA-00 for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 15:19:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49525) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j1FWH-0004oK-RV for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 15:19:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j1FWH-0002sV-L3 for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 15:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Tassilo Horn" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Feb 2020 20:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39546 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39546-submit@debbugs.gnu.org id=B39546.158136593411048 (code B ref 39546); Mon, 10 Feb 2020 20:19:01 +0000 Original-Received: (at 39546) by debbugs.gnu.org; 10 Feb 2020 20:18:54 +0000 Original-Received: from localhost ([127.0.0.1]:55498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1FWA-0002s7-5A for submit@debbugs.gnu.org; Mon, 10 Feb 2020 15:18:54 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1FW6-0002rt-JI for 39546@debbugs.gnu.org; Mon, 10 Feb 2020 15:18:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54271) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j1FW0-0004EM-Lb; Mon, 10 Feb 2020 15:18:44 -0500 Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:50055) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1j1FVz-0000rB-Q7; Mon, 10 Feb 2020 15:18:43 -0500 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 51A9121FE5; Mon, 10 Feb 2020 15:18:43 -0500 (EST) Original-Received: from imap34 ([10.202.2.84]) by compute7.internal (MEProxy); Mon, 10 Feb 2020 15:18:43 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedriedugdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdfvrghs shhilhhoucfjohhrnhdfuceothhsughhsehgnhhurdhorhhgqeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnodhmvghsmhhtphgr uhhthhhpvghrshhonhgrlhhithihqdekieejfeekjeekgedqieefhedvleekqdhtshguhh eppehgnhhurdhorhhgsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id AABD41460061; Mon, 10 Feb 2020 15:18:42 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: <83mu9qb4d0.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175901 Archived-At: Am Mo, 10. Feb 2020, um 20:59, schrieb Eli Zaretskii: > > From: Tassilo Horn > > Cc: Tino Calancha , 39546@debbugs.gnu.org, > > larsi@gnus.org, michael.albinus@gmx.de > > Date: Mon, 10 Feb 2020 20:19:05 +0100 > > > > I've already submitted patches to hindent (and I think to some other 3rd > > party package providing code formatting by replacing with the output of > > some formatting tool) using that function. > > > > Anyway, if it is going to be moved, I'd to ask you to move it in > > emacs-27 so that I can check for and fix external usages I know of > > without having to distinguish emacs versions. > > Then maybe we shouldn't move it, just for these reasons. If we all think that replace.el is the right place and it has the benefit of being loaded at startup, then I'm all for it. The hindent PR is not yet merged anyway, and the other one was quickly accepted, so an addendum patch will be, too. I'd like to see more usages of that function. Basically every package providing support for external formatters should use it, e.g., I'm going to submit a patch for rust-mode providing formatting using rustfmt anytime soon. So better change it now than regretting that multiple not so uncommon packages require subr-x at runtime. Bye, Tassilo