bug#32107: 27.0.50; sql-connect/sql-send-paragraph broken

bug#32107: 27.0.50; sql-connect/sql-send-paragraph broken

[vividsnow]

Hi

Steps to reproduce:

* switch to *scratch*
* sql-mode
* sql-sqlite -> test.db
* sql-save-connection -> test
* kill *SQL* interactive buffer
* switch to *scratch*
* sql-connect -> test
* switch back to *scratch*
* try to send something (eg "select 1" ) via C-c C-c (sql-send-paragraph)
* got "user-error: No SQL process started"

In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30)
 of 2018-07-09, unofficial emacs-snapshot build: http://emacs.secretsauce.net built on lilbastard
Windowing system distributor 'The X.Org Foundation', version 11.0.12000000
System Description: Debian GNU/Linux buster/sid

Recent messages:

Quit [2 times]
Mark set
funcall-interactively: End of buffer
Configured using:
 'configure --build x86_64-linux-gnu --prefix=/usr
 --sharedstatedir=/var/lib --libexecdir=/usr/lib
 --localstatedir=/var/lib --infodir=/usr/share/info
 --mandir=/usr/share/man --with-pop=yes
 --enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/27.0.50/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/27.0.50/site-lisp:/usr/share/emacs/site-lisp
 --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib
 --libexecdir=/usr/lib --localstatedir=/var/lib
 --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes
 --enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/27.0.50/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/27.0.50/site-lisp:/usr/share/emacs/site-lisp
 --with-x=yes --with-x-toolkit=gtk3 --with-toolkit-scroll-bars
 'CFLAGS=-g -O2
 -fdebug-prefix-map=/build/emacs-snapshot-yDDGTZ/emacs-snapshot-20180708+emacs-26.1-2454-g9d09ced1d5d=.
-fstack-protector-strong
 -Wformat -Werror=format-security -Wall -fno-omit-frame-pointer'
 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' LDFLAGS=-Wl,-z,relro'

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY
ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 THREADS LCMS2

Important settings:
  value of $LANG: en_US.utf8
  locale-coding-system: utf-8-unix

Major mode: SQL[ANSI]

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
/usr/share/emacs-snapshot/site-lisp/cmake-data/cmake-mode hides /usr/share/emacs/site-lisp/cmake-mode
/usr/share/emacs/27.0.50/site-lisp/debian-startup hides /usr/share/emacs/site-lisp/debian-startup

Features:
(shadow sort mail-extr cl-extra emacsbug message rmc puny seq byte-opt
gv bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822
mml mml-sec password-cache epa derived epg epg-config gnus-util rmail
rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils help-fns radix-tree help-mode cus-edit
cus-start cus-load wid-edit sql easymenu view thingatpt comint
ansi-color ring cl-loaddefs cl-lib elec-pair time-date mule-util tooltip
eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel
term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode
lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote dbusbind inotify lcms2 dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty
make-network-process emacs)

Memory information:
((conses 16 127893 30849)
 (symbols 48 22510 1)
 (miscs 40 61 203)
 (strings 32 36492 2196)
 (string-bytes 1 965149)
 (vectors 16 17126)
 (vector-slots 8 529928 14258)
 (floats 8 68 186)
 (intervals 56 333 1)
 (buffers 992 15))

bug#32107: 27.0.50; sql-connect/sql-send-paragraph broken

[Filipp Gunbin]

tags 32107 notabug

On 10/07/2018 00:08 +0300, vividsnow wrote:

> Hi
>
> Steps to reproduce:
>
> * switch to *scratch*
> * sql-mode
> * sql-sqlite -> test.db
> * sql-save-connection -> test
> * kill *SQL* interactive buffer
> * switch to *scratch*
> * sql-connect -> test
> * switch back to *scratch*
> * try to send something (eg "select 1" ) via C-c C-c (sql-send-paragraph)
> * got "user-error: No SQL process started"

That seems to work as expected.  From sql-mode buffer, you set "target"
SQLi buffer with sql-set-sqli-buffer (actually, it sets sql-buffer var).

Then if you kill the SQLi buffer and get a new one, sql-set-sqli-buffer
needs to be called again.

See also function sql-set-sqli-buffer-generally.

Filipp

bug#32107: 27.0.50; sql-connect/sql-send-paragraph broken

[vividsnow]

sql-set-sqli-buffer not working either.

Lets say I have saved connection: test (as in first example)
Then:

* sql-connect -> test
* switch to *scratch*
* sql-mode
* sql-set-set-sql-buffer
* minibuffer asks new database connection details, not buffer name

On 07/10/2018 07:52 PM, Filipp Gunbin wrote:
> tags 32107 notabug
> 
> On 10/07/2018 00:08 +0300, vividsnow wrote:
> 
>> Hi
>>
>> Steps to reproduce:
>>
>> * switch to *scratch*
>> * sql-mode
>> * sql-sqlite -> test.db
>> * sql-save-connection -> test
>> * kill *SQL* interactive buffer
>> * switch to *scratch*
>> * sql-connect -> test
>> * switch back to *scratch*
>> * try to send something (eg "select 1" ) via C-c C-c (sql-send-paragraph)
>> * got "user-error: No SQL process started"
> 
> That seems to work as expected.  From sql-mode buffer, you set "target"
> SQLi buffer with sql-set-sqli-buffer (actually, it sets sql-buffer var).
> 
> Then if you kill the SQLi buffer and get a new one, sql-set-sqli-buffer
> needs to be called again.
> 
> See also function sql-set-sqli-buffer-generally.
> 
> Filipp
> 

bug#32107: 27.0.50; sql-connect/sql-send-paragraph broken

[Filipp Gunbin]

On 11/07/2018 00:01 +0300, vividsnow wrote:

> sql-set-sqli-buffer not working either.
>
> Lets say I have saved connection: test (as in first example)
> Then:
>
> * sql-connect -> test
> * switch to *scratch*
> * sql-mode
> * sql-set-set-sql-buffer
> * minibuffer asks new database connection details, not buffer name

Yes, I can reproduce this.  Fixed on master, could you please try?

Filipp

bug#32107: 27.0.50; sql-connect/sql-send-paragraph broken

[vividsnow]

Yes, it works now. Thank you.

On 07/11/2018 05:34 AM, Filipp Gunbin wrote:
> On 11/07/2018 00:01 +0300, vividsnow wrote:
> 
>> sql-set-sqli-buffer not working either.
>>
>> Lets say I have saved connection: test (as in first example)
>> Then:
>>
>> * sql-connect -> test
>> * switch to *scratch*
>> * sql-mode
>> * sql-set-set-sql-buffer
>> * minibuffer asks new database connection details, not buffer name
> 
> Yes, I can reproduce this.  Fixed on master, could you please try?
> 
> Filipp
>