From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jared Finder via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68765: 30.0.50; Adding window-tool-bar package. Date: Mon, 26 Feb 2024 14:38:39 -0800 Message-ID: References: <07df5e8408054bcae5968066b0cebf34@finder.org> <86fry0vihy.fsf@gnu.org> <86fry08di9.fsf@mail.linkov.net> Reply-To: Jared Finder Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39914"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 68765@debbugs.gnu.org, Philip Kaludercic , Stefan Monnier To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 26 23:40:07 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rejdn-000ABG-C6 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Feb 2024 23:40:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rejdK-0007Ek-Jl; Mon, 26 Feb 2024 17:39:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rejdJ-0007EP-1x for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2024 17:39:37 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rejdI-0006AU-Q5 for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2024 17:39:36 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rejdi-0003gx-5h for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2024 17:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jared Finder Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Feb 2024 22:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68765 X-GNU-PR-Package: emacs Original-Received: via spool by 68765-submit@debbugs.gnu.org id=B68765.170898715014046 (code B ref 68765); Mon, 26 Feb 2024 22:40:02 +0000 Original-Received: (at 68765) by debbugs.gnu.org; 26 Feb 2024 22:39:10 +0000 Original-Received: from localhost ([127.0.0.1]:45106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rejcr-0003eT-Np for submit@debbugs.gnu.org; Mon, 26 Feb 2024 17:39:09 -0500 Original-Received: from greenhill.hpalace.com ([192.155.80.58]:58354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rejco-0003eI-Us for 68765@debbugs.gnu.org; Mon, 26 Feb 2024 17:39:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=finder.org; s=2018; t=1708987120; bh=6/RDwljyZMqmpemwOrCTR2ww4pS5ASxLroudTvMgnGY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2AqtxF1XtYtuOD0FglLXBO5sjI/nfIl+7Efwry3g6cyLdJ6NIulx2EkqBW9MO43pD LRQhxAjW/jbEA7B1XMquYU0M5vKCZg2NxwDibICIPMXK174QRR73qkSGOsONN3qWmo OiT+4vv9cT1VVzcFT/oItpAdJvQEk8P7Z9+D1UK6Y9qyNmvkXEMTjFYGnm4qe61lcQ WKi6hxD0zkO5hpHssPMARLBQ1+aaz8HduNLpJwSu9Y+urrSH7KalvPZIPRbF3W/5hz yy9yhuFcWsjxLSKHKPk4PXPbrMG2UruN8NL+XO3Uh9KyhZdsH+vST/wqvFzgNfltmi TjWB5YTbeBcFA== Original-Received: from mail.finder.org (unknown [192.155.80.58]) by greenhill.hpalace.com (Postfix) with ESMTPSA id 4EB5D499; Mon, 26 Feb 2024 22:38:40 +0000 (UTC) In-Reply-To: <86fry08di9.fsf@mail.linkov.net> X-Sender: jared@finder.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280709 Archived-At: On 2024-02-10 09:25, Juri Linkov wrote: >>> * lisp/tab-line.el (tab-line-format-template): Add separator space. >>> (tab-line-display-order): New user variable to control display order. >>> (tab-line--runtime-display-order, tab-line--cookie): New internal >>> variables. >>> (tab-line-set-display): New function for modes to call to enable only >>> their content. >>> (tab-line-mode): Call `tab-line-set-display'. >> >> Juri, would you please review this part of the changeset? > > I'm not sure if this provides a clean interface. > Have you tried to show both window-tool-bar and tab-line tabs > on the same tab-line? Do you think this combination is usable? > Or maybe better just repurpose the tab-line in window-tool-bar.el > exclusively for window-local tool-bar? The implementation I provided works fine for me with both window-tool-bar-mode and tab-line-mode enabled as long as there are not too many tabs. I could see further adding a way to specify the max width tabs are able to take up if you think that's necessary. -- MJF