From: Drew Adams <drew.adams@oracle.com>
To: 25032@debbugs.gnu.org
Subject: bug#25032: 25.1; `bookmark-set-internal', `bookmark-set-no-overwrite'
Date: Fri, 25 Nov 2016 16:21:12 -0800 (PST) [thread overview]
Message-ID: <a2aaddd0-ce03-44f8-831f-5e0cbc1a0896@default> (raw)
1. Why is "internal" function `bookmark-set-internal' a _command_
(interactive)? What sense does an "internal" command make? It seems
that the `interactive' spec here was a copy+paste mistake. It should
be removed, I think.
2. The `interactive' spec for `bookmark-set-internal' seems wrong
anyway. NAME is the raw prefix arg? And then NAME is simply taken
as is (as STR) and compared using `string-equal'? This cannot be
correct.
3. Similarly, why does the doc string of `bookmark-set-internal' say
"_Interactively_..."? It should just say that it prompts for a
bookmark name and then... And "error" is not easily and commonly
understood as a verb - use "raise an error" instead.
4. `bookmark-set-internal' should preferably not accept both args PROMPT
and NAME. If NAME is present (e.g. for non-interactive use of
`bookmark-set') then PROMPT makes no sense and is not used (and the
doc string is wrong about PROMPT in that case).
5. In `bookmark-set-internal', a nil third arg should have been used to
mean overwrite, not raise an error, as overwriting is still, and
always has been, the default behavior of `bookmark-set'. You should
have introduced the new value `error', not the new value `overwrite',
and kept the default (nil) behavior as overwriting.
You will no doubt argue that this does not matter because
`bookmark-set-internal' is "internal". But the main command is
still, and should still be `bookmark-set'. `bookmark-set-internal'
should reflect _its_ behavior for the default case (nil).
6. Error messages, like other messages, should not end with a period.
No doubt it is "too late" for #4 and #5. Hopefully not for the rest.
In GNU Emacs 25.1.1 (x86_64-w64-mingw32)
of 2016-09-17 built on LAPHROAIG
Windowing system distributor 'Microsoft Corp.', version 6.1.7601
Configured using:
'configure --without-dbus --without-compress-install CFLAGS=-static'
next reply other threads:[~2016-11-26 0:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-26 0:21 Drew Adams [this message]
2019-06-12 9:09 ` bug#25032: 25.1; `bookmark-set-internal', `bookmark-set-no-overwrite' Stefan Kangas
2019-07-02 5:23 ` Stefan Kangas
2019-07-02 5:27 ` Stefan Kangas
2019-07-02 16:48 ` Eli Zaretskii
2019-07-02 17:07 ` Stefan Kangas
2019-07-06 8:55 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2aaddd0-ce03-44f8-831f-5e0cbc1a0896@default \
--to=drew.adams@oracle.com \
--cc=25032@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.