From: Mario Frasca <mario@anche.no>
To: Kyle Meyer <kyle@kyleam.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: `with` as a list.
Date: Sun, 31 May 2020 20:47:52 -0500 [thread overview]
Message-ID: <a2a828cb-67e5-fda1-3096-f4f1a9939976@anche.no> (raw)
In-Reply-To: <874krvvdr3.fsf@kyleam.com>
On 31/05/2020 19:19, Kyle Meyer wrote:
> You've been sending a diff,
> presumably from the point you branched off of to the tip of your branch.
> In that case, you're already presenting each iteration you've sent as
> one change; it just lacks a commit message.
right, that's indeed what I did, and this is also what I thought, so no
need to rebase, squash or whatever, as long as I make sure that the diff
I'm sending you is about this single issue, and let's agree on the
commit message, because after all I'm adding a function to a software I
don't really know.
I hope to send an updated patch soon, that will also include the docs.
I have no strong opinion on workflows, just trying to understand the one
used here.
btw: if I had write permissions to the repositories, I would be adding
test cases, and reviewing the docstrings, some of which I find
misleading. your remark on setf/setq could also be addressed in the
code. and some of the code ought to be refactored, as to allow for unit
tests.
ciao, MF
next prev parent reply other threads:[~2020-06-01 1:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 16:07 `with` as a list Mario Frasca
2020-05-28 13:34 ` [PATCH] [FEATURE] " Mario Frasca
2020-05-30 6:22 ` Kyle Meyer
2020-05-30 14:23 ` Mario Frasca
2020-05-30 14:38 ` Mario Frasca
2020-05-30 20:23 ` Kyle Meyer
2020-05-30 21:29 ` Mario Frasca
2020-05-31 20:18 ` Mario Frasca
2020-06-01 0:19 ` Kyle Meyer
2020-06-01 1:47 ` Mario Frasca [this message]
2020-06-01 2:31 ` Kyle Meyer
2020-06-03 15:09 ` Mario Frasca
2020-06-03 15:13 ` Bastien
2020-06-03 15:18 ` Mario Frasca
2020-06-03 15:29 ` Bastien
2020-06-03 17:08 ` Mario Frasca
2020-06-03 22:15 ` Mario Frasca
2020-06-03 15:25 ` Mario Frasca
2020-06-03 15:30 ` Bastien
2020-05-30 16:01 ` Mario Frasca
2020-05-30 20:25 ` Kyle Meyer
2020-05-30 21:36 ` Mario Frasca
2020-05-31 0:36 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2a828cb-67e5-fda1-3096-f4f1a9939976@anche.no \
--to=mario@anche.no \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.