all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 23387-done@debbugs.gnu.org
Subject: bug#23387: 25.0.93; Unicode quote inserted in Python mode outside of strings
Date: Mon, 2 May 2016 09:04:18 -0700	[thread overview]
Message-ID: <a2876c56-af94-7cd5-02f5-b2c8fc640bda@cs.ucla.edu> (raw)
In-Reply-To: <wvr4wpnj9lzy.fsf@a.muc.corp.google.com>

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

Thanks for the bug report and patch, but I ran into a problem with the 
patch. Suppose I do this:

emacs -Q
M-x electric-quote-mode
M-x customize-variable RET electric-quote-string, set it to t, save
M-x python-mode
'abc'

That is, I type apostrophe-a-b-c-apostrophe in Python mode. With the 
patch, the buffer will contain:

'abc’

The opening apostrophe is OK, but the closing apostrophe is considered 
to be inside a string so it is transmogrified into a right single 
quotation mark. A Python programmer would want both to be apostrophes.

I installed the attached patches into emacs-25 instead, as they should 
address this problem too. Please give it a try.

[-- Attachment #2: 0001-Don-t-electrically-quote-in-Python.patch --]
[-- Type: application/x-patch, Size: 1773 bytes --]

[-- Attachment #3: 0002-Add-electric-quote-string-unit-test.patch --]
[-- Type: application/x-patch, Size: 1001 bytes --]

  parent reply	other threads:[~2016-05-02 16:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-27 14:14 bug#23387: 25.0.93; Unicode quote inserted in Python mode outside of strings Philipp Stephani
2016-04-28 17:11 ` Philipp Stephani
2016-04-28 17:22   ` Philipp Stephani
2016-04-30 11:59     ` Philipp Stephani
2016-05-02 16:04 ` Paul Eggert [this message]
2016-05-03 20:44   ` Philipp Stephani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2876c56-af94-7cd5-02f5-b2c8fc640bda@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=23387-done@debbugs.gnu.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.