all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#43822: 28.0.50; build failed on revno.5ec2115
       [not found] ` <20201004194200.7B7A420A23@vcs0.savannah.gnu.org>
@ 2020-10-06  0:21   ` Katsumi Yamaoka
  2020-10-06  8:04     ` Juri Linkov
  2020-10-06  6:07   ` master 5ec2115: Use '…' for ellipsis in truncate-string-to-width by default (bug#41250) Herbert J. Skuhra
  1 sibling, 1 reply; 11+ messages in thread
From: Katsumi Yamaoka @ 2020-10-06  0:21 UTC (permalink / raw)
  To: 43822; +Cc: Juri Linkov

Hi,

On Sun, 04 Oct 2020 15:41:59 -0400, Juri Linkov wrote:
> branch: master
> commit 5ec21155c39aab8a452d190a260e6912d1d9a920
> Author: Juri Linkov <juri@linkov.net>
> Commit: Juri Linkov <juri@linkov.net>

>     Use '…' for ellipsis in truncate-string-to-width by default (bug#41250)

Probably because of this change, building Emacs got to fail (on
at least Cygwin platform).  Before the change (96a8e8) it's ok.
An output of make is below.  Where I added (setq debug-on-error t)
to `skkdic-convert-postfix' in "lisp/international/ja-dic-cnv.el".

Note that Emacs tries to load the file named "...".  I couldn't
find how `lookup-nested-alist' calls `load-with-code-conversion',
sorry.

[...]
make[2]: Entering directory '/Work/Emacs/lisp'
make -C ../leim all EMACS="../src/bootstrap-emacs.exe"
make[3]: Entering directory '/Work/Emacs/leim'
  GEN      ../lisp/leim/ja-dic/ja-dic.el
  INFO     Processing OKURI-ARI entries
  INFO     Processing POSTFIX entries
Debugger entered--Lisp error: (invalid-read-syntax "?")
  read(#<buffer  *load*>)
  eval-buffer(#<buffer  *load*> nil "/Work/Emacs/lisp/international/..." nil t)  ; Reading at buffer position 2307
[...]
  load-with-code-conversion("/Work/Emacs/lisp/international/..." "/Work/Emacs/lisp/international/..." nil t)
  lookup-nested-alist("行" (skkdic-postfix-list) nil nil t)
  skkdic-convert-postfix(#<buffer  *skkdic-unannotated*> #<buffer *skkdic-work*>)
  skkdic-convert("/Work/Emacs/leim/SKK-DIC/SKK-JI..." "/Work/Emacs/lisp/leim/ja-dic")
  batch-skkdic-convert()
  funcall(batch-skkdic-convert)
[...]
make[3]: *** [Makefile:143: ../lisp/leim/ja-dic/ja-dic.el] Error 255
make[3]: Leaving directory '/Work/Emacs/leim'
make[2]: *** [Makefile:352: leim] Error 2
make[2]: Leaving directory '/Work/Emacs/lisp'
make[1]: *** [Makefile:794: ../lisp/loaddefs.el] Error 2
make[1]: Leaving directory '/Work/Emacs/src'
make: *** [Makefile:424: src] Error 2

Thanks.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: master 5ec2115: Use '…' for ellipsis in truncate-string-to-width by default (bug#41250)
       [not found] ` <20201004194200.7B7A420A23@vcs0.savannah.gnu.org>
  2020-10-06  0:21   ` bug#43822: 28.0.50; build failed on revno.5ec2115 Katsumi Yamaoka
@ 2020-10-06  6:07   ` Herbert J. Skuhra
  2020-10-06  7:58     ` Juri Linkov
  1 sibling, 1 reply; 11+ messages in thread
From: Herbert J. Skuhra @ 2020-10-06  6:07 UTC (permalink / raw)
  To: emacs-devel, Juri Linkov

On Sun, 04 Oct 2020 21:41:59 +0200, Juri Linkov wrote:
> 
> branch: master
> commit 5ec21155c39aab8a452d190a260e6912d1d9a920
> Author: Juri Linkov <juri@linkov.net>
> Commit: Juri Linkov <juri@linkov.net>
> 
>     Use '…' for ellipsis in truncate-string-to-width by default (bug#41250)
>     
>     * lisp/international/mule-util.el (truncate-string-ellipsis):
>     Change the default value to nil.
>     (truncate-string-ellipsis): New function.
>     (truncate-string-to-width): Use the value returned from the
>     function 'truncate-string-ellipsis'.
>     
>     * lisp/tab-bar.el (tab-bar-tab-name-truncated):
>     * lisp/tab-line.el (tab-line-tab-name-ellipsis):
>     Take advantage of the improvement of the ellipsis default value
>     in truncate-string-to-width and truncate-string-ellipsis.
>     
>     * doc/lispref/display.texi (Size of Displayed Text):
>     Improve description of truncate-string-ellipsis.
> ---
>  doc/lispref/display.texi        |  3 ++-
>  etc/NEWS                        |  6 ++++++
>  lisp/international/mule-util.el | 21 +++++++++++++++++----
>  lisp/tab-bar.el                 | 10 +++-------
>  lisp/tab-line.el                |  3 +--
>  5 files changed, 29 insertions(+), 14 deletions(-)

Hi,

after this commit I can no longer do a clean build:

% git clean -xfd
% ./autogen.sh
% ./configure --prefix=/usr/local/emacs --with-x-toolkit=lucid --with-mailutils
% make

  GEN      ../lisp/leim/ja-dic/ja-dic.el
  INFO     Processing OKURI-ARI entries
  INFO     Processing POSTFIX entries
Loading macroexp.elc...
Invalid read syntax: "?"
make[3]: *** [Makefile:143: ../lisp/leim/ja-dic/ja-dic.el] Error 255
make[3]: Leaving directory '/home/herbert/source/emacs/leim'
make[2]: *** [Makefile:352: leim] Error 2
make[2]: Leaving directory '/home/herbert/source/emacs/lisp'
make[1]: *** [Makefile:794: ../lisp/loaddefs.el] Error 2
make[1]: Leaving directory '/home/herbert/source/emacs/src'
make: *** [Makefile:424: src] Error 2

--
Herbert



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: master 5ec2115: Use '…' for ellipsis in truncate-string-to-width by default (bug#41250)
  2020-10-06  6:07   ` master 5ec2115: Use '…' for ellipsis in truncate-string-to-width by default (bug#41250) Herbert J. Skuhra
@ 2020-10-06  7:58     ` Juri Linkov
  2020-10-06  8:42       ` Herbert J. Skuhra
                         ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Juri Linkov @ 2020-10-06  7:58 UTC (permalink / raw)
  To: Herbert J. Skuhra; +Cc: emacs-devel

> after this commit I can no longer do a clean build:
>
> % git clean -xfd
> % ./autogen.sh
> % ./configure --prefix=/usr/local/emacs --with-x-toolkit=lucid --with-mailutils
> % make
>
>   GEN      ../lisp/leim/ja-dic/ja-dic.el
>   INFO     Processing OKURI-ARI entries
>   INFO     Processing POSTFIX entries
> Loading macroexp.elc...
> Invalid read syntax: "?"
> make[3]: *** [Makefile:143: ../lisp/leim/ja-dic/ja-dic.el] Error 255
> make[3]: Leaving directory '/home/herbert/source/emacs/leim'
> make[2]: *** [Makefile:352: leim] Error 2
> make[2]: Leaving directory '/home/herbert/source/emacs/lisp'
> make[1]: *** [Makefile:794: ../lisp/loaddefs.el] Error 2
> make[1]: Leaving directory '/home/herbert/source/emacs/src'
> make: *** [Makefile:424: src] Error 2

The problem is that the source file mule-util.el can't use the Unicode
character '…'.  Please see http://debbugs.gnu.org/41250 for the discussion.

This is fixed now.



^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#43822: 28.0.50; build failed on revno.5ec2115
  2020-10-06  0:21   ` bug#43822: 28.0.50; build failed on revno.5ec2115 Katsumi Yamaoka
@ 2020-10-06  8:04     ` Juri Linkov
  2020-10-06 18:27       ` Juri Linkov
  0 siblings, 1 reply; 11+ messages in thread
From: Juri Linkov @ 2020-10-06  8:04 UTC (permalink / raw)
  To: Katsumi Yamaoka; +Cc: 43822

>>     Use '…' for ellipsis in truncate-string-to-width by default (bug#41250)
>
> Probably because of this change, building Emacs got to fail (on
> at least Cygwin platform).  Before the change (96a8e8) it's ok.
> An output of make is below.  Where I added (setq debug-on-error t)
> to `skkdic-convert-postfix' in "lisp/international/ja-dic-cnv.el".
>
> Note that Emacs tries to load the file named "...".  I couldn't
> find how `lookup-nested-alist' calls `load-with-code-conversion',
> sorry.

This breakage is fixed now.  Please see bug#41250 for the discussion.
This bug could be left open until a more general solution is found.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: master 5ec2115: Use '…' for ellipsis in truncate-string-to-width by default (bug#41250)
  2020-10-06  7:58     ` Juri Linkov
@ 2020-10-06  8:42       ` Herbert J. Skuhra
  2020-10-06 13:09       ` Stefan Monnier
  2020-10-06 15:36       ` Drew Adams
  2 siblings, 0 replies; 11+ messages in thread
From: Herbert J. Skuhra @ 2020-10-06  8:42 UTC (permalink / raw)
  To: Juri Linkov; +Cc: emacs-devel

On Tue, Oct 06, 2020 at 10:58:32AM +0300, Juri Linkov wrote:
> > after this commit I can no longer do a clean build:
> >
> > % git clean -xfd
> > % ./autogen.sh
> > % ./configure --prefix=/usr/local/emacs --with-x-toolkit=lucid --with-mailutils
> > % make
> >
> >   GEN      ../lisp/leim/ja-dic/ja-dic.el
> >   INFO     Processing OKURI-ARI entries
> >   INFO     Processing POSTFIX entries
> > Loading macroexp.elc...
> > Invalid read syntax: "?"
> > make[3]: *** [Makefile:143: ../lisp/leim/ja-dic/ja-dic.el] Error 255
> > make[3]: Leaving directory '/home/herbert/source/emacs/leim'
> > make[2]: *** [Makefile:352: leim] Error 2
> > make[2]: Leaving directory '/home/herbert/source/emacs/lisp'
> > make[1]: *** [Makefile:794: ../lisp/loaddefs.el] Error 2
> > make[1]: Leaving directory '/home/herbert/source/emacs/src'
> > make: *** [Makefile:424: src] Error 2
> 
> The problem is that the source file mule-util.el can't use the Unicode
> character '…'.  Please see http://debbugs.gnu.org/41250 for the discussion.
> 
> This is fixed now.

Thanks. But now I get:

Loading macroexp.elc...
Invalid read syntax: "\\N{HORIZONTAL ELLIPSIS}"
make[3]: *** [../lisp/leim/ja-dic/ja-dic.el] Error 255
make[2]: *** [leim] Error 2
make[1]: *** [../lisp/loaddefs.el] Error 2
make: *** [src] Error 2

-- 
Herbert



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: master 5ec2115: Use '…' for ellipsis in truncate-string-to-width by default (bug#41250)
  2020-10-06  7:58     ` Juri Linkov
  2020-10-06  8:42       ` Herbert J. Skuhra
@ 2020-10-06 13:09       ` Stefan Monnier
  2020-10-06 15:36       ` Drew Adams
  2 siblings, 0 replies; 11+ messages in thread
From: Stefan Monnier @ 2020-10-06 13:09 UTC (permalink / raw)
  To: Juri Linkov; +Cc: Herbert J. Skuhra, emacs-devel

> The problem is that the source file mule-util.el can't use the Unicode
> character '…'.

Yes, it can.  It's some other code which messes things up.


        Stefan




^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: master 5ec2115: Use '…' for ellipsis in truncate-string-to-width by default (bug#41250)
  2020-10-06  7:58     ` Juri Linkov
  2020-10-06  8:42       ` Herbert J. Skuhra
  2020-10-06 13:09       ` Stefan Monnier
@ 2020-10-06 15:36       ` Drew Adams
  2020-10-06 15:54         ` Stefan Monnier
  2 siblings, 1 reply; 11+ messages in thread
From: Drew Adams @ 2020-10-06 15:36 UTC (permalink / raw)
  To: Juri Linkov, Herbert J. Skuhra; +Cc: emacs-devel

> The problem is that the source file mule-util.el can't use the Unicode
> character '…'.  Please see
> https://urldefense.com/v3/__http://debbugs.gnu.org/41250__;!!GqivPVa7Brio!Myw
> 9NLEyEGq9q15InHIL4DosZcvKPlrhRBDjGAthnl2obqktBvxncP_YLpQWXegw$  for the
> discussion.

FWIW, in that bug (#41250) thread, I expressed 
the opinion about the ellipsis that we should
use "..." and not "…", which is not so readable.

The ellipsis is used to indicate truncation.
By using "..." we include two more chars, but
it suffices to truncate two additional chars,
to end with the same width of text.  (And users
can control the max width by an option.)

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=41250#144

That opinion was ignored, and instead hoops were
jumped through to try to use "…".  IMO, not only
is it not worth trying to do that, the result,
if successful, is worse.

That "…" char is pretty useless, in general.
Its appearance has nothing in common with that
of a real ellipsis, at least when a fixed-width
font is used.



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: master 5ec2115: Use '…' for ellipsis in truncate-string-to-width by default (bug#41250)
  2020-10-06 15:36       ` Drew Adams
@ 2020-10-06 15:54         ` Stefan Monnier
  2020-10-06 16:04           ` Drew Adams
  0 siblings, 1 reply; 11+ messages in thread
From: Stefan Monnier @ 2020-10-06 15:54 UTC (permalink / raw)
  To: Drew Adams; +Cc: Herbert J. Skuhra, emacs-devel, Juri Linkov

> That "…" char is pretty useless, in general.
> Its appearance has nothing in common with that
> of a real ellipsis, at least when a fixed-width
> font is used.

FWIW, I've been using "…" for that ellipsis for a long time now, and
I use a fixed-width font (misc-fixed-semicondensed) pretty
much everywhere.  So obviously my opinion disagrees with yours.

I did end up using "……" at a few places (mostly for the
outline-minor-mode ellipses), tho, because while I find "..." too long,
"…" ended up a bit too short for my taste in that case.

For `truncate-string-to-width` (which is also used to truncate elements
which are significantly shorter than a line's width (contrary to the
outline-minor-mode ellipses) typically in multi-column tabular data),
I found the extra 2 chars very welcome.


        Stefan




^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: master 5ec2115: Use '…' for ellipsis in truncate-string-to-width by default (bug#41250)
  2020-10-06 15:54         ` Stefan Monnier
@ 2020-10-06 16:04           ` Drew Adams
  0 siblings, 0 replies; 11+ messages in thread
From: Drew Adams @ 2020-10-06 16:04 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Herbert J. Skuhra, emacs-devel, Juri Linkov

> > That "…" char is pretty useless, in general.
> > Its appearance has nothing in common with that
> > of a real ellipsis, at least when a fixed-width
> > font is used.
> 
> FWIW, I've been using "…" for that ellipsis for a long time now, and
> I use a fixed-width font (misc-fixed-semicondensed) pretty
> much everywhere.  So obviously my opinion disagrees with yours.
> 
> I did end up using "……" at a few places (mostly for the
> outline-minor-mode ellipses), tho, because while I find "..." too long,
> "…" ended up a bit too short for my taste in that case.
> 
> For `truncate-string-to-width` (which is also used to truncate elements
> which are significantly shorter than a line's width (contrary to the
> outline-minor-mode ellipses) typically in multi-column tabular data),
> I found the extra 2 chars very welcome.

OK.

There's an argument for users to be able to customize
the string, beyond just the overall length/width.



^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#43822: 28.0.50; build failed on revno.5ec2115
  2020-10-06  8:04     ` Juri Linkov
@ 2020-10-06 18:27       ` Juri Linkov
  2020-10-06 22:28         ` Katsumi Yamaoka
  0 siblings, 1 reply; 11+ messages in thread
From: Juri Linkov @ 2020-10-06 18:27 UTC (permalink / raw)
  To: Katsumi Yamaoka; +Cc: 43822

tags 43822 fixed
close 43822 28.0.50
quit

>>>     Use '…' for ellipsis in truncate-string-to-width by default (bug#41250)
>>
>> Probably because of this change, building Emacs got to fail (on
>> at least Cygwin platform).  Before the change (96a8e8) it's ok.
>> An output of make is below.  Where I added (setq debug-on-error t)
>> to `skkdic-convert-postfix' in "lisp/international/ja-dic-cnv.el".
>>
>> Note that Emacs tries to load the file named "...".  I couldn't
>> find how `lookup-nested-alist' calls `load-with-code-conversion',
>> sorry.
>
> This breakage is fixed now.  Please see bug#41250 for the discussion.
> This bug could be left open until a more general solution is found.

Stefan fixed this in bug#41250, so closing this report as well.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#43822: 28.0.50; build failed on revno.5ec2115
  2020-10-06 18:27       ` Juri Linkov
@ 2020-10-06 22:28         ` Katsumi Yamaoka
  0 siblings, 0 replies; 11+ messages in thread
From: Katsumi Yamaoka @ 2020-10-06 22:28 UTC (permalink / raw)
  To: Juri Linkov; +Cc: 43822

On Tue, 06 Oct 2020 11:04:22 +0300, Juri Linkov wrote:
> This breakage is fixed now.  Please see bug#41250 for the discussion.
> This bug could be left open until a more general solution is found.

Oh, I understood it to be due to misplaced let-bound
`coding-system-for-read' that prevents mule-util.el, in which
"…" is added recently, from being autoloaded.

On Tue, 06 Oct 2020 21:27:26 +0300, Juri Linkov wrote:
> Stefan fixed this in bug#41250, so closing this report as well.

Works fine now.  Thanks.





^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2020-10-06 22:28 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20201004194159.3503.69418@vcs0.savannah.gnu.org>
     [not found] ` <20201004194200.7B7A420A23@vcs0.savannah.gnu.org>
2020-10-06  0:21   ` bug#43822: 28.0.50; build failed on revno.5ec2115 Katsumi Yamaoka
2020-10-06  8:04     ` Juri Linkov
2020-10-06 18:27       ` Juri Linkov
2020-10-06 22:28         ` Katsumi Yamaoka
2020-10-06  6:07   ` master 5ec2115: Use '…' for ellipsis in truncate-string-to-width by default (bug#41250) Herbert J. Skuhra
2020-10-06  7:58     ` Juri Linkov
2020-10-06  8:42       ` Herbert J. Skuhra
2020-10-06 13:09       ` Stefan Monnier
2020-10-06 15:36       ` Drew Adams
2020-10-06 15:54         ` Stefan Monnier
2020-10-06 16:04           ` Drew Adams

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.