From: Dmitry Gutov <dmitry@gutov.dev>
To: Eli Zaretskii <eliz@gnu.org>, Spencer Baugh <sbaugh@janestreet.com>
Cc: 70968@debbugs.gnu.org, monnier@iro.umontreal.ca, juri@linkov.net
Subject: bug#70968: 29.2.50; choose-completion on an emacs22-style completion deletes text after point
Date: Sat, 14 Sep 2024 18:18:46 +0300 [thread overview]
Message-ID: <a20796c1-a431-4206-bb71-e3c005c55efc@gutov.dev> (raw)
In-Reply-To: <86o74qh9wv.fsf@gnu.org>
On 14/09/2024 12:17, Eli Zaretskii wrote:
> B. Deprecate the emacs22 style and replace it with a new style called
> `ignore-suffix` which has this bug fixed, and which replaces emacs22
> in the default value of completion-styles.
Note that while this is a viable option, we're still lacking a mechanism
which would fix the problem for the new completion style.
And then we'd have two code paths for this behavior that somehow need to
distinguish between these styles.
With the original proposal we would delegate to the style's completion
logic, but it would apparently behave the same between emacs22 and the
new style.
> Option C is from my POV the least desirable one: it adds some
> complicated logic, which will almost certainly produce unintended
> results, as everything in this completion-related mess we have.
That's probably true, but whether it will make things more complicated
or not would also depend on the overall design. With some effort, it
could be the opposite - but with more changes across the board, overall
not backward compatible ones.
> I'm okay with adding a new style, per B, but why do we need to
> deprecate emacs22 at the same time? Let users who want this new
> behavior customize their completion styles to use this new style
> instead of emacs22.
I don't envy the person who's going to write documentation and has to
describe the distinction between these two styles, that they differ in
this particular place of the UI, and are otherwise the same.
Deprecating the old style would at least say that this complication is a
wart which would someday go away, and we could take a shortcut in the
implementation (e.g. hardcode the value `emacs22` in some check).
next prev parent reply other threads:[~2024-09-14 15:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 20:26 bug#70968: 29.2.50; choose-completion on an emacs22-style completion deletes text after point Spencer Baugh
2024-05-16 8:13 ` Eli Zaretskii
2024-05-16 17:26 ` Dmitry Gutov
2024-05-16 18:25 ` Eli Zaretskii
2024-08-26 0:08 ` Dmitry Gutov
2024-09-07 7:30 ` Eli Zaretskii
2024-09-08 2:02 ` Dmitry Gutov
2024-09-08 11:12 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-10 16:54 ` Spencer Baugh via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-14 9:17 ` Eli Zaretskii
2024-09-14 15:18 ` Dmitry Gutov [this message]
2024-09-14 16:00 ` Eli Zaretskii
2024-09-16 19:54 ` Spencer Baugh via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-16 17:40 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-16 18:28 ` Eli Zaretskii
2024-06-20 15:45 ` Spencer Baugh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a20796c1-a431-4206-bb71-e3c005c55efc@gutov.dev \
--to=dmitry@gutov.dev \
--cc=70968@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
--cc=monnier@iro.umontreal.ca \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.