From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: VOTE: Changing completions-common-part face's default Date: Fri, 8 Nov 2019 12:15:14 +0200 Message-ID: References: <4c5631d4-9dfd-04c6-c573-b83c67fcc2fa@yandex.ru> <87pni7p83l.fsf@gmail.com> <87h83ipoi0.fsf@gmail.com> <93235eb5-8e04-7182-e2a4-49fbe610ee2b@yandex.ru> <28d4ae09-daca-324b-2fa6-9d7138d710fa@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="53646"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 08 11:16:37 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iT1Jj-000DoZ-NK for ged-emacs-devel@m.gmane.org; Fri, 08 Nov 2019 11:16:35 +0100 Original-Received: from localhost ([::1]:51554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iT1Ji-00045X-1i for ged-emacs-devel@m.gmane.org; Fri, 08 Nov 2019 05:16:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45751) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iT1IW-0003ze-UO for emacs-devel@gnu.org; Fri, 08 Nov 2019 05:15:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iT1IV-0003sk-7R for emacs-devel@gnu.org; Fri, 08 Nov 2019 05:15:20 -0500 Original-Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:37163) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iT1IV-0003ri-0n for emacs-devel@gnu.org; Fri, 08 Nov 2019 05:15:19 -0500 Original-Received: by mail-wr1-x42e.google.com with SMTP id t1so6381134wrv.4 for ; Fri, 08 Nov 2019 02:15:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LxrHlTUX3Vnh/z1j/mlJVgL73AbR1/fkwCx5Qft2JkE=; b=bAbqz72ExPE/eupGMpeknloBwDwLLVAVCt2HYSwQGUaC4XF5G9IIzPVYWVmBcIWMnj 26ZS7LRIztyCY1U+tsJCyfgvXE6bgGUujXE8mX4emvPzvAYvReB9lqxfvRIeUXngvgQ7 KxZbUTXT8x1Y81TJ1PLG1kz1uF2rsYg1u3x0zRPfOOTV7cqp/9K5hRqty+S/az16p7f5 m9KkcvlEnOJxyjFN46F8UfSPZqks5LZVzqso+djqpTlPQ2eUTL1BI637SQOffJPhxHzz pIpZmXFiAdGKnzCMtQ+M9RkG4cXKroq7n3WekiwCPh31ZiSARPYFr2F0p8BC00Gm8lEA whKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LxrHlTUX3Vnh/z1j/mlJVgL73AbR1/fkwCx5Qft2JkE=; b=GLvwgbzrLn4LqnN3O7JDTMeMxthgIyeKYgH0gU+BqrAGwwP01DV/HztpLUg1yCBk+h 3m13h+3OOPqH2sObhVCTvuFV/t++aMxUxSg7Fd5SqwkTfqkg8FV4AGpMFn8+z/wnYCOL BweDGc7CBmh2nlMVjwEdT9B9u9dErnhaZXhnwnP1c59dDzlfAPnNikYPRa8dUPvuKcW3 ri8WSlhuVl1ad4+D7CWQtD7QVWdZhOPv2sxJzEmnuHVke35zwn2VlxXcTPLwwtRr7nhS PiH4yIvGOFMus2z7R0e62YqOzx1IgmeaZpbm7xv8C4wgtmRUQFIP9WKfUGhVGI2dkfDJ +DoA== X-Gm-Message-State: APjAAAUyKX5Ki+z5mYFe3doTramEUpCzzijY2t/MYEl2hVfzsGCmpBtD E/Bj8hCFDmsLk1LbQ1NP4175ZHcJpnI= X-Google-Smtp-Source: APXvYqxc+/pcK3JXDYjEpzmEOUFIF3fGjMmjCcZlwW0PZD+8YH9kZRAiW3/OShZ0KD9AIsP3rSBgpQ== X-Received: by 2002:adf:ed84:: with SMTP id c4mr7294542wro.333.1573208117240; Fri, 08 Nov 2019 02:15:17 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id g184sm8735537wma.8.2019.11.08.02.15.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Nov 2019 02:15:15 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241974 Archived-At: On 07.11.2019 17:08, Stefan Monnier wrote: >> which brings back the main objection to using it for prefix completion. > > To be honest, I'm not completely sure what is the main objection. > I chose `blue3` so far because while noticeable it seems to me that it > doesn't affect the overall legibility nor makes the first-diff > less noticeable. Excessive highlighting is something we've been normally avoiding in Emacs, for its distracting properties. > So, yes, it's "useless" highlighting for basic/prefix-completion, but > that's pretty much a given. "useless" is compatible with "harmless". That's also true. >> I recognize others feel differently, though. >> So if blue4 also works for your stated goal, which is > > I could live with "blue4" but it's significantly less visible, so > I think the only role it could play is to advertise the existence of the > face, but nothing else: I expect that very few people who want to see > the common-part (e.g. because they're using flex) will find it > sufficient, whereas I suspect that `blue3` would be "good enough" for > a non-negligible fraction of those users. Like Joao said, blue4 will seem like a half-measure, and I generally don't support those. So while I'd prefer my first suggestion (wait until flex is used universally), I'd like to retract my personal objection here. blue3 is a good enough color, and it fits the default theme. So unless we can agree on a better idea, and unless other people object, let's go with blue3 and call it a day. > It is better than what we have, IMO, so I'm willing to "retreat" to > `blue4` for this "first step" if you really think `blue3` harms the > basic/prefix-completion case. If we have more time to think on this, I'd try to consider how to better help the pcmpl/flex cases by using completions-first-difference on more characters instead. And/or adding an extra face for the other "non-matching" characters. For "fabrobazor" example and input "foo", "abr", "b" and "az" would be highlighted with that new face. And "r" still with first-difference. Information-wise, the result should be the same as highlighting the common part. Not quite sure what colors to use, though.