From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#15329: saveplace restores dired positions to random places Date: Sun, 15 Dec 2013 13:43:42 -0800 (PST) Message-ID: References: <87mwnj1414.fsf@mail.jurta.org> <8761u6ow6t.fsf@kwarm.red-bean.com> <87d2odvk36.fsf@mail.jurta.org> <87hacy829m.fsf@floss.red-bean.com> <87sittlvd7.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1387143863 15194 80.91.229.3 (15 Dec 2013 21:44:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 Dec 2013 21:44:23 +0000 (UTC) Cc: 15329@debbugs.gnu.org To: Juri Linkov , Karl Fogel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 15 22:44:27 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VsJUA-0005Ti-FT for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Dec 2013 22:44:26 +0100 Original-Received: from localhost ([::1]:52588 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsJU9-0003E0-Rw for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Dec 2013 16:44:25 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsJTy-00035f-IO for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2013 16:44:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VsJTn-0000rX-FQ for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2013 16:44:14 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsJTn-0000rN-Bs for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2013 16:44:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VsJTm-000284-Q0 for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2013 16:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Dec 2013 21:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15329 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 15329-submit@debbugs.gnu.org id=B15329.13871438288155 (code B ref 15329); Sun, 15 Dec 2013 21:44:02 +0000 Original-Received: (at 15329) by debbugs.gnu.org; 15 Dec 2013 21:43:48 +0000 Original-Received: from localhost ([127.0.0.1]:52169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VsJTY-00027T-90 for submit@debbugs.gnu.org; Sun, 15 Dec 2013 16:43:48 -0500 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:27462) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VsJTV-00027K-M8 for 15329@debbugs.gnu.org; Sun, 15 Dec 2013 16:43:46 -0500 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rBFLhhZO018904 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 15 Dec 2013 21:43:44 GMT Original-Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBFLhgPR006957 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 15 Dec 2013 21:43:43 GMT Original-Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBFLhgeg016977; Sun, 15 Dec 2013 21:43:42 GMT In-Reply-To: <87sittlvd7.fsf@mail.jurta.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82031 Archived-At: > - (if (not buffer-file-name) > - (message "Buffer `%s' not visiting a file" (buffer-name)) > + (if (not (or buffer-file-name dired-directory)) > + (message "Buffer `%s' not visiting a file or directory" > + (buffer-name)) Is `dired-directory' really the right test here? I am used to seeing (derived-mode-p 'dired-mode) for that purpose (assuming I understand the purpose here). There is, BTW, nothing in the doc string of `dired-directory' that says what a nil value means. Should code now instead be using `dired-directory' to test whether the mode is (derived from) Dired? If so, then at the very least the doc string of that variable should describe such a Boolean meaning: nil means not in Dired mode or a mode derived from it (or whatever the completely correct interpretation is).