From: Drew Adams <drew.adams@oracle.com>
To: Juri Linkov <juri@jurta.org>, Karl Fogel <kfogel@red-bean.com>
Cc: 15329@debbugs.gnu.org
Subject: bug#15329: saveplace restores dired positions to random places
Date: Sun, 15 Dec 2013 13:43:42 -0800 (PST) [thread overview]
Message-ID: <a1c7df06-ca7e-4952-9bd8-b9f7e83d669a@default> (raw)
In-Reply-To: <87sittlvd7.fsf@mail.jurta.org>
> - (if (not buffer-file-name)
> - (message "Buffer `%s' not visiting a file" (buffer-name))
> + (if (not (or buffer-file-name dired-directory))
> + (message "Buffer `%s' not visiting a file or directory"
> + (buffer-name))
Is `dired-directory' really the right test here? I am used to seeing
(derived-mode-p 'dired-mode) for that purpose (assuming I understand the
purpose here).
There is, BTW, nothing in the doc string of `dired-directory' that says
what a nil value means. Should code now instead be using
`dired-directory' to test whether the mode is (derived from) Dired?
If so, then at the very least the doc string of that variable should
describe such a Boolean meaning: nil means not in Dired mode or a mode
derived from it (or whatever the completely correct interpretation is).
next prev parent reply other threads:[~2013-12-15 21:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 20:45 bug#15329: saveplace restores dired positions to random places Juri Linkov
2013-09-11 20:45 ` Juri Linkov
2013-09-11 20:45 ` Juri Linkov
2013-09-12 16:12 ` Karl Fogel
2013-09-12 19:13 ` Stefan Monnier
2013-09-12 19:13 ` Stefan Monnier
2013-09-12 20:52 ` Juri Linkov
2013-10-03 21:37 ` Karl Fogel
2013-10-03 21:37 ` Karl Fogel
2013-12-15 20:20 ` Juri Linkov
2013-12-15 21:43 ` Drew Adams [this message]
2013-12-16 20:58 ` Juri Linkov
2013-12-16 21:15 ` Drew Adams
2013-12-20 20:20 ` Juri Linkov
2013-12-21 2:09 ` Karl Fogel
2013-09-12 20:52 ` Juri Linkov
2013-09-12 16:12 ` Karl Fogel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1c7df06-ca7e-4952-9bd8-b9f7e83d669a@default \
--to=drew.adams@oracle.com \
--cc=15329@debbugs.gnu.org \
--cc=juri@jurta.org \
--cc=kfogel@red-bean.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.