From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.devel Subject: Re: so-long tests Date: Sat, 13 Jul 2019 21:41:10 +1200 Message-ID: References: <83sgra1jn6.fsf@gnu.org> <1046d298-c0bc-a69f-39a7-011aa993c9da@orcon.net.nz> <83k1cm1h49.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="197008"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 13 11:41:21 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmEWu-000p71-CQ for ged-emacs-devel@m.gmane.org; Sat, 13 Jul 2019 11:41:20 +0200 Original-Received: from localhost ([::1]:54310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmEWs-0005ph-K5 for ged-emacs-devel@m.gmane.org; Sat, 13 Jul 2019 05:41:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54864) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmEWq-0005pb-HS for emacs-devel@gnu.org; Sat, 13 Jul 2019 05:41:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmEWp-0005Rx-HG for emacs-devel@gnu.org; Sat, 13 Jul 2019 05:41:16 -0400 Original-Received: from smtp-2.orcon.net.nz ([60.234.4.43]:43573) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hmEWp-0005O4-67; Sat, 13 Jul 2019 05:41:15 -0400 Original-Received: from [116.251.203.142] (port=19642 helo=[192.168.20.103]) by smtp-2.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1hmEWl-00013q-23; Sat, 13 Jul 2019 21:41:11 +1200 In-Reply-To: <83k1cm1h49.fsf@gnu.org> Content-Language: en-US X-GeoIP: NZ X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 60.234.4.43 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238550 Archived-At: On 13/07/19 8:19 PM, Eli Zaretskii wrote: >> Hence test/lisp/so-long-tests/* > > Why do we need the exception in this case? Exceptions should > be reserved for exceptional cases. The reason I used that directory structure is that I ended up using multiple test files. My initial tests were indeed written as a test/lisp/so-long-tests.el file, but I switched to the alternative structure when I added additional files. Going by the docs, it hadn't occurred to me that doing so would be in any way controversial. My reading was that either approach was fine. -Phil