From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: marty hiatt Newsgroups: gmane.emacs.devel Subject: vtable's beginning/end-of-table functions broken/fix Date: Thu, 28 Sep 2023 15:08:07 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13762"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 28 20:39:33 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qlvvA-0003IT-96 for ged-emacs-devel@m.gmane-mx.org; Thu, 28 Sep 2023 20:39:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qlvuU-0001DO-H7; Thu, 28 Sep 2023 14:38:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlqkZ-0007uq-P2 for emacs-devel@gnu.org; Thu, 28 Sep 2023 09:08:15 -0400 Original-Received: from mx0.riseup.net ([198.252.153.6]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlqkW-0004Po-L3 for emacs-devel@gnu.org; Thu, 28 Sep 2023 09:08:14 -0400 Original-Received: from fews02-sea.riseup.net (fews02-sea-pn.riseup.net [10.0.1.112]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx0.riseup.net (Postfix) with ESMTPS id 4RxDLL18Gwz9sVn for ; Thu, 28 Sep 2023 13:08:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1695906490; bh=5SUL4UO+hJPUiCjui6KCYvMX9dNNmMwZEMDDvox6c4E=; h=Date:To:From:Subject:From; b=U22zY0CuRPgm1iD1L7wCrzljS/g3DGAuLiBJ0jOyPK7PWrlvmVaaN/vzkUr6/HyTS 1SQUeCILA85OC7CMjxtN1RsZw2Pu9KU8PWpBIwVhF1DcdMslKA1iT2+XnuyAVv9VvC T3Z4N9dFyDpUG+A0D+UzVz+WccP2yLiFXrVbmXXA= X-Riseup-User-ID: C5CA112DF181A627C4E8A1AC8DD1F59157B998F73071DB5AA7726B88C0E131F0 Original-Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews02-sea.riseup.net (Postfix) with ESMTPSA id 4RxDLK4qXbzFqgj for ; Thu, 28 Sep 2023 13:08:09 +0000 (UTC) Content-Language: en-US Received-SPF: pass client-ip=198.252.153.6; envelope-from=mousebot@riseup.net; helo=mx0.riseup.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 28 Sep 2023 14:38:49 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311131 Archived-At: vtable.el's functions `vtable-beginning-of-table` and `vtable-end-of-table` seem broken to me. when i try to use `vtable-revert-command` on a table in a buffer that contains other text, reverting or re-sorting it removes everything in the buffer apart from the table. to fix it, it looks like the call to `text-property-search-backward` for the former or `text-property-search-forward` for the latter requires a third argument (PREDICATE) of `t` rather than nil. from the docstring: "Two special values of PREDICATE can also be used: If PREDICATE is t, that means the value of PROPERTY must `equal' VALUE to be considered a match. If PREDICATE is nil (which is the default), the value of PROPERTY will match if it is not `equal' to VALUE." with PREDICATE set to nil, the beginning/end-of-table functions use `point-min` and `point-max instead.