From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 81204b2: Port xref-tests to master branch Date: Sat, 7 May 2016 23:44:16 +0300 Message-ID: References: <20160506170958.15680.28097@vcs.savannah.gnu.org> <80c49bb5-7eec-68d5-4449-ce8c97713276@yandex.ru> <417c83b5-df98-684e-2d81-951706c04f98@yandex.ru> <572E50C8.702@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1462653880 11336 80.91.229.3 (7 May 2016 20:44:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 7 May 2016 20:44:40 +0000 (UTC) Cc: Glenn Morris , Phillip Lord To: Paul Eggert , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 07 22:44:34 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1az95T-00027X-PS for ged-emacs-devel@m.gmane.org; Sat, 07 May 2016 22:44:31 +0200 Original-Received: from localhost ([::1]:35078 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1az95S-0007bp-EY for ged-emacs-devel@m.gmane.org; Sat, 07 May 2016 16:44:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1az95P-0007YB-1C for emacs-devel@gnu.org; Sat, 07 May 2016 16:44:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1az95M-0002DO-Ss for emacs-devel@gnu.org; Sat, 07 May 2016 16:44:25 -0400 Original-Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:33328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1az95H-0002A3-Jv; Sat, 07 May 2016 16:44:19 -0400 Original-Received: by mail-wm0-x242.google.com with SMTP id r12so14211014wme.0; Sat, 07 May 2016 13:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=GhnTB3N80AwaHfHOGdRhD/Xwkx6XkhoyE9+Z4WNcco4=; b=Ts9p51rJ55S2Fjjhanei8dCOY5EabdtuEYUWpgR6oYOaaahuLFINnMdVNUm44iC6Mh Tcle+m/gvCeAqcBh5Z8cVU41Td11pOXgvau+6XkiHaQ4ErNQEJiqYgXxd3u2J/KcffN6 VInqi9R5lTtEdVdTOAPughBXFADO4ZiybiHiwz9r3+6yFiQs9eAYcwkw7GCt9SOwkdzL +sIBMtwlXr4ClbXXMeQRIp4Dvgpbthzn57yJY7Qr731cvayep5qCu7hX7cOTs8044ROs 5zgjntE1u97rzFx5X2OWOkPLiVF4Cl8sw1/XLT1e+DYYPVOdlgCIQsbij74ycmoFqn9A WY0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=GhnTB3N80AwaHfHOGdRhD/Xwkx6XkhoyE9+Z4WNcco4=; b=CmFIuHkwwoqNBqh7DlKhlKYLn3tGIGGiCxTwbaWXi+UxpsjjZfapZL+NM4AtENUU1E 73XD7qfLjJ1iNevu/shXvm4Pv9SejfQJQZqciG8+Nl6Ov84cqoJKGHVVCQma26/ee1S7 eUdly8ozAniSYTGDui2gFApzKA+3G8MOoxkseuzJaNLFNrMGvqcfsDXUHTqNI7r3gZ39 Ofbr0GYhcQzgBreCCMEtSyq8flbCqYBoRrvQmTX/BKjgXg7x27pnO9nADONhRBfpxg6B 78Ug7TuvvDfin1Q2C/e8XhIjcuT0gm2M2xsUlDwku9sCnGLb2hf06D7txq6bD6wNXAUU NlBg== X-Gm-Message-State: AOPr4FVi83nH1hLKujvPJ91xMQmBcBcF4KaSlJQ58kC37y8llUsYjqb6lOQpG2mzFwVlPA== X-Received: by 10.194.80.162 with SMTP id s2mr26089784wjx.116.1462653858877; Sat, 07 May 2016 13:44:18 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id u12sm15358375wmu.12.2016.05.07.13.44.17 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 07 May 2016 13:44:18 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1 In-Reply-To: <572E50C8.702@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203681 Archived-At: On 05/07/2016 11:32 PM, Paul Eggert wrote: > That being said, the master branch should use the same pattern for all the tests > that consult the data file. Preferably yes, but if some authors are fine with using ERT from command line only, they could keep the current pattern if it's somehow preferable. I just don't want to see interactive-friendly patterns stomped out. On a related note, most test code uses test/data and (getenv "EMACS_TEST_DIRECTORY"), but package-tests.el use the previous pattern (which I prefer) and test/lisp/emacs-lisp/package-resources/ (which seems rather inconsistent). > I adjusted the xref tests to use the pattern I saw > elsewhere; if the pattern is wrong, we should fix it everywhere. Yes, no blame here. I just hadn't noticed it right away. > Extra points if > you can figure out how to fix it without breaking merges from the emacs-25 > branch, which uses a slightly different architecture in this area. I don't think changes to tests on emacs-25 are going to be a significant problem much more.